| Opserty |
09-07-2007 02:03 PM |
[JS] There must be a better way to do this
Ok a little background info first. :p Basically put we have added a couple of AJAX menus to our postbit template to enable our moderators to hand out warns and bans quickly without the need to leave the page. I basically hacked together a bit of Javascript which I found using good old google. However I'm almost certain there is a better way to do what we are doing because at the moment we have to output a whole javascript function (shown below) for each post.
HTML Code:
<script type="text/javascript">
// JavaScript Document
function sendWarnData1242913(frmName, divID)
{
var XMLHttpRequestObject = false;
if (window.XMLHttpRequest)
{
XMLHttpRequestObject = new XMLHttpRequest();
}
else if (window.ActivexObject)
{
XMLHttpRequestObject = new ActiveXObject("Microsoft.XMLHTTP");
}
var url = 'showthread.php?do=XXXX';
var obj = document.getElementById(divID);
var frm = frmName;
if(XMLHttpRequestObject)
{
XMLHttpRequestObject.open("POST", url);
XMLHttpRequestObject.setRequestHeader('Content-Type','application/x-www-form-urlencoded');
XMLHttpRequestObject.send("post=" + frm.post.value + "&id=" + frm.id.value + "&alert=" + frm.alert.value + "&warningid=" + frm.warningid.value + "&comment=" + frm.comment.value);
obj.innerHTML = "<img src='images/ajaxloading.gif' alt='Loading' />" ;
XMLHttpRequestObject.onreadystatechange = function()
{
if (XMLHttpRequestObject.readyState == 4 && XMLHttpRequestObject.status == 200)
{
obj.innerHTML = XMLHttpRequestObject.responseText;
}
}
}
}
</script>
Our form looks something like this:
HTML Code:
<form action="#" method="post" id="opwarnform1242913" id="opwarnform1242913" name="opwarnform">
<input type="hidden" id="post" name="post" value="1242913" />
<input type="hidden" id="id" name="id" value="7198" />
<input type="hidden" id="alert" name="alert" value="" />
Warning Type: <br />
<select name="warningid">
<option value="1">Wrong Forum</option><option value="8">Double Posted</option><option value="9">Other</option><option value="10">URL in Topic Title</option><option value="18">Not meeting Sig request requirements</option><option value="13">Failed to give constructive criticism</option><option value="17">Marketplace Negative Comment</option><option value="6">Offensive word / phrase</option><option value="11">Affiliate Referral Links</option><option value="4">Warez</option><option value="20">Spamming</option><option value="2">Flaming</option><option value="7">Unfound Ripper Accusation</option>
</select> <br /><br />
Comment:<br />
<input type="text" id="comment" value="" class="smallfont" name="comment" /><br /><br />
<input style="padding:1px;" type="button" onclick="sendWarnData1242913(this.form, 'warndiv1242913')" class="button" value="Warn" />
</form>
I tried merely sending the request via a single function, however I found that it is not possible to 'reset' the result and therefore it is not possible to warn more then once on a page. Maybe I am doing something wrong?
P.S. I'm not a big JS user so don't rip my head off, please. :D
Thanks in advanced. |
More Information