vb.org Archive - query code standards

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)

- - query code standards (https://vborg.vbsupport.ru/showthread.php?t=156244)

Antivirus

08-25-2007 06:43 PM

query code standards

I'm aware that both give me the same result, however with regards to an interger in a WHERE clause, which method is better? Enclosing the int within '2' or without. Is either method faster, or less likely to create problems elsewhere?

PHP Code:


		
			
$check = $db->query_first("

    SELECT eventid FROM " . TABLE_PREFIX . "scst_event 

    WHERE eventid = '" . $vbulletin->GPC['eventid'] . "' 

    AND userid = '" . $vbulletin->userinfo['userid'] . "' LIMIT 0, 1

");

or like this:

PHP Code:


		
			
$check = $db->query_first("

    SELECT eventid FROM " . TABLE_PREFIX . "scst_event 

    WHERE eventid = " . $vbulletin->GPC['eventid'] . " 

    AND userid = " . $vbulletin->userinfo['userid'] . " LIMIT 0, 1

");

thanks :)

Kirk Y

08-25-2007 06:53 PM

I've always been told that integers shouldn't be quoted.

Attilitus

08-25-2007 06:57 PM

Yep, its more efficient to not quote integers as PHP will view them as a string and will thus be forced to do a conversion before searching for it in an int field.

Antivirus

08-25-2007 07:44 PM

ah, i see - that makes sense, thanks for clarifying it.

Quite often, in native vb code, i have seen something like '" . $vbulletin->userinfo['userid'] . "' so I was confused as to why. Thanks

All times are GMT. The time now is 01:11 AM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01014 seconds Memory Usage 1,719KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_php_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (4)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: