vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   ibProArcade Archive (https://vborg.vbsupport.ru/forumdisplay.php?f=174)
-   -   [Bugfix] Tournament Time Played Not Updated If Score lower than previous score (https://vborg.vbsupport.ru/showthread.php?t=130755)

Starc 11-04-2006 12:22 PM
[Bugfix] Tournament Time Played Not Updated If Score lower than previous score
 
Applies to Version 2.5.7.
It seem that the "time played" in a tournament is not updated if the game score is lower than the previous score of that tournament 'rung'.

Bugfix below:

Code:
Open arcade.php
Locate the following code near line 3932:
if ( (($thisscore > $savearray[1]) && $scoretype == "high") || (($thisscore > 0 && $savearray[1]==0) && $scoretype == "low") || (($thisscore < $savearray[1]) && $scoretype == "low") && ($thisscore != 0) )
                                {
                    // Save new game score in that spot
                    $DB->query("UPDATE ibf_tournament_players SET rungscore=".$player_score.", timeplayed='".time()."', notified=0 WHERE mid=".$this->arcade->user['id']." AND tid=".$tid." AND rung=".$savearray[0]);
                          $savearray[1] = $thisscore;
                    }

Change this to the following:
                                if ( (($thisscore > $savearray[1]) && $scoretype == "high") || (($thisscore > 0 && $savearray[1]==0) && $scoretype == "low") || (($thisscore < $savearray[1]) && $scoretype == "low") && ($thisscore != 0) )
                                {
                    // Save new game score in that spot
                    $DB->query("UPDATE ibf_tournament_players SET rungscore=".$player_score.", timeplayed='".time()."', notified=0 WHERE mid=".$this->arcade->user['id']." AND tid=".$tid." AND rung=".$savearray[0]);
                          $savearray[1] = $thisscore;
                    }
                    else
                    {
                  // Bugfix 2006/11/04 by Starc - also update time played when player has not improved score!
                        $DB->query("UPDATE ibf_tournament_players SET timeplayed='".time()."' WHERE mid=".$this->arcade->user['id']." AND tid=".$tid." AND rung=".$savearray[0]);
                    }

Please note that this is an unofficial bugfix. I did not ask Mr. Zeropage for permission on this, so if this does not work, please don't bug him about it. Mr. Zeropage, please feel free to include this in your next version.

Hope this helps someone out there who experiences the same problem :)

Stifmeister2 11-04-2006 02:13 PM
Wow man... I dunno where you came but you seem to be pretty skilled coder.. :) Already helped me once. ;)


Keep up the good work. :)

MrZeropage 11-04-2006 05:10 PM
@starc:
nice fix, thanks for that, but you missed one additional parameter (notified) so I did a final fix in the v2.5.8+ code :)


All times are GMT. The time now is 03:19 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01044 seconds
  • Memory Usage 1,715KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (3)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete