Is this query "proper" for 3.6.x?
 

I have this query in one of the plugins, this code came from a product for 3.5.3, and im wondering if this is still ok for 3.6, or if there is an updated way to do what this query is doing.

$db->query_first

And

$vbulletin->db->query_write

Thanks :)

noone can tell me if this needs to be updated or not?

Yep...

query_first() to fetch first row
query_first_slave() for fetching first row using slave server (if available)
query_read() for reading
query_read_slave() for reading using slave server (if available)
query_write() for writing to the database

Your best bet is to just dig into the class files to find this stuff out... It just takes a sec.

./includes/class_core.php

Erm, well the answer to his question is "no", neither of the two queries he posted needs to be changed.

lol, well in my defence I could say I was answering post #2

Thanks for catching my typo, Paul, though the two _slave() functions were added.

i dont know what id be looking for in the class files.
:)
thanks for thei nfo

yes, for the most part......Some of the write's within the actual query changed, so if you are trying to upgrade a certain mod by yourself, you may run into trouble if the field isn't present anymore......This has been a learning curve i have been going through too........

well i havent gotten any errors, i was just wondering cause i remember reading something about vbulletin using clean_gpc now or something??

what would tneed to be replaced by clean_gpc?

The query function and clean_array_gpc are separate functions.

clean_array_gpc sanitizes functions, while the query functions run queries to the database.

If you are looking at porting an older modification you would be replacing vBulletin's legacy globalize() function with $vbulletin->input->clean_array_gpc()