vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   Any way to optimize my code or cut down on queries? (https://vborg.vbsupport.ru/showthread.php?t=122610)

zeroality 07-31-2006 04:16 AM

Any way to optimize my code or cut down on queries?
 
1 Attachment(s)
I took this MOD:
https://vborg.vbsupport.ru/showthread.php?t=97403

And turned it into this:
Attachment 51318

I did it without any real prior knowledge of php or mySQL so I'm sure my code is very inefficient. I pieced it together from what was already in the MOD and got the rest from trial & error.

Here's the plugin code. Any feedback is appreciated, thank you.

Original Code:
Code:

// ### LATEST NEWS BY TANTAWI ############################################
                $latesta = $db->query_first('SELECT title,threadid,views,replycount FROM ' . TABLE_PREFIX . 'thread WHERE 1 AND forumid = 28 ORDER BY dateline DESC  LIMIT 1');
                $lns_show = "<a href=\"showthread.php?"  . $vbulletin->session->vars['sessionurl'] . "t=$latesta[threadid]\">$latesta[title]</a>";

My Code:
Code:

// ### LATEST NEWS BY TANTAWI ############################################
                $latesta = $db->query_first('SELECT title,threadid,views,replycount,postusername,dateline FROM ' . TABLE_PREFIX . 'thread WHERE 1 AND forumid = 28 ORDER BY dateline DESC  LIMIT 0 , 1');
                $lns_show = "<a href=\"showthread.php?"  . $vbulletin->session->vars['sessionurl'] . "t=$latesta[threadid]\">$latesta[title]</a>";
                $lnsurl_show = "<a href=\"showthread.php?"  . $vbulletin->session->vars['sessionurl'] . "t=$latesta[threadid]\">[Read More]</a>";
                $lns2_show = "<b>Replies:</b> $latesta[replycount] <b>Views:</b> $latesta[views]";
                $lns3_show = "<a href=\"http://pokerealm.net/forums/member.php?do=getinfo&username=$latesta[postusername]\">$latesta[postusername]</a>";

                $latgetpost = $db->query_first('SELECT pagetext FROM ' . TABLE_PREFIX . 'post WHERE 1 AND threadid = ' . $latesta[threadid]. ' ORDER BY dateline ASC  LIMIT 0 , 1');
                $lat_show = "$latgetpost[pagetext]";
                $postchars = 250;
                $cuttedpost = substr($latgetpost[pagetext],$postchars,1);
                if($cuttedpost !=" "){
                while($cuttedpost !=" "){
                $i=1;
                $postchars=$postchars+$i;
                $cuttedpost = substr($latgetpost[pagetext],$postchars,1);
                }
                }
                $cuttedpost = substr($latgetpost[pagetext],0,$postchars);

                $authshow = vbdate($vbulletin->options['dateformat'], $latesta['dateline']);
                $authshow2 = vbdate($vbulletin->options['timeformat'], $latesta['dateline']);

                $amtans = $db->query_first('SELECT threadcount FROM ' . TABLE_PREFIX . 'forum WHERE 1 AND forumid = 28 ORDER BY forumid DESC  LIMIT 0 , 1');
                $amt_show = "$amtans[threadcount]";


zeroality 07-31-2006 08:57 PM

Bump.

Paul M 07-31-2006 09:06 PM

In your queries, you can remove the bold bits as per the example below;

Code:

SELECT threadcount FROM ' . TABLE_PREFIX . 'forum WHERE 1 AND forumid = 28 ORDER BY forumid DESC  LIMIT 0 , 1
'WHERE 1' is totally pointless, and the limit is unnecessary as you are using query_first.


All times are GMT. The time now is 04:45 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01345 seconds
  • Memory Usage 1,722KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (3)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete