vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   variable not returning in function (https://vborg.vbsupport.ru/showthread.php?t=120434)

harmor19 07-06-2006 02:50 AM
variable not returning in function
 
I'm sort of copying vBulletin's code that cleans data. If I echo the variable in the function it works but if I return the variable and echo it outside the function it doesn't.

Here is the code.
PHP Code:
<?php


function clean($mthd, $arr)
{
    
    if($mthd == "p")
    {
        
        foreach (array_keys($arr) as $val) 
        {
               go_clean($val, 'p');
        }
    }
}

function go_clean(&$val, $mthd)
{
    
    $efinfo = array();
    
    if($mthd == "p")
    {
      $efinfo[$val] = $_POST[$val];
    }
      
     return $efinfo; 
     
     //echo "$val: ". $_POST[$val] ."<br /> ";
    
}

$_POST['username'] = "harmor";
$_POST['password'] = "andrew123";

$data = array('username' => 'STR', 'password' => 'STR', 'age' => 'INT', 'email' => 'STR');
clean('p', $data);

echo $efinfo['username'];


?>
What does the "and" symbol in this function do? go_clean(&$val, $mthd)
I just added it to see if it changed anything but it didn't.

Chris Graham 07-14-2006 07:10 PM
I take it you're learning to code as this 'cleaning code' does absolutely nothing ;). Here's something that will 'clean' PHP's magic quotes...

Code:
<?php


function clean($mthd, $arr)
{
   
    if($mthd == "p")
    {
       
        $efinfo = array();
        foreach (array_keys($arr) as $val)
        {
              $efinfo = array_merge($efinfo, go_clean($val, 'p'));
        }
        return $efinfo;
    }
}

function go_clean(&$val, $mthd)
{
   
    $efinfo = array();
   
    if($mthd == "p")
    {
      $efinfo[$val] = $_POST[$val];
      if (get_magic_quotes_gpc()) $efinfo[$val]=stripslashes($efinfo[$val]);
    }
     
    return $efinfo;
   
    //echo "$val: ". $_POST[$val] ."<br /> ";
   
}

$_POST['username'] = "harmor";
$_POST['password'] = "andrew123";

$data = array('username' => 'STR', 'password' => 'STR', 'age' => 'INT', 'email' => 'STR');
$efinfo = clean('p', $data);

echo $efinfo['username'];


?>
Note the key differences:
- we're doing something (using stripslashes) to do some cleaning. I don't know what you're wanting to clean, but this is at least something.
- the clean function will now process the data go_clean returns, putting it all into one big merged array
- the clean function returns the merged array

Now, it's horribly overcomplex code (there's no need for two functions), but hopefully it's a nice example :).

What the "&" does by the way is a bit complex. Basically a normal function treats variables passed into it as new data, and the function could change that data and not affect the data that was passed into the function. If "&" is put before the parameter names then PHP will bind the passed data to the data in the function, so that if you make a change in the function, the actual passed source data will also be changed.


All times are GMT. The time now is 04:13 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01031 seconds
  • Memory Usage 1,726KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (1)bbcode_php_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (2)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete