vb.org Archive - redundant queries from installation code?

CMX,

I've been looking at your vb Plaza installation code, and wondering why you use alot of seperate queries while you can merge them together? Shouldnt it save queries, and run better/faster in the installation process?

example:

PHP Code:


		
			
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user ADD COLUMN vbbux DECIMAL(30, 5) NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user ADD COLUMN vbbank DECIMAL(30, 5) NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user ADD COLUMN vbp_nextbankinterest INT UNSIGNED NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user ADD COLUMN vbp_lastbirthday INT UNSIGNED NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user ADD COLUMN vbp_displayflags INT UNSIGNED NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user ADD COLUMN vbp_otherflags INT UNSIGNED NOT NULL DEFAULT '0'");
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user ADD COLUMN vbp_vbplazaoptions INT UNSIGNED NOT NULL DEFAULT '0'");

why dont use

PHP Code:


		
			
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user 
ADD COLUMN vbbux DECIMAL(30, 5) NOT NULL DEFAULT '0', 
ADD COLUMN vbbank DECIMAL(30, 5) NOT NULL DEFAULT '0',
ADD COLUMN vbp_nextbankinterest INT UNSIGNED NOT NULL DEFAULT '0',
ADD COLUMN vbp_lastbirthday INT UNSIGNED NOT NULL DEFAULT '0',
ADD COLUMN vbp_displayflags INT UNSIGNED NOT NULL DEFAULT '0',
ADD COLUMN vbp_otherflags INT UNSIGNED NOT NULL DEFAULT '0',
ADD COLUMN vbp_vbplazaoptions INT UNSIGNED NOT NULL DEFAULT '0',
...

OR with

PHP Code:


		
			
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user DROP COLUMN vbbux");
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user DROP COLUMN vbbank");
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user DROP COLUMN vbp_nextbankinterest");
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user DROP COLUMN vbp_lastbirthday");
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user DROP COLUMN vbp_displayflags");
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user DROP COLUMN vbp_otherflags");

PHP Code:


		
			
$db->query_write("ALTER TABLE " . TABLE_PREFIX . "user 
DROP COLUMN vbbux, 
DROP COLUMN vbbank,
DROP COLUMN vbp_nextbankinterest,
DROP COLUMN vbp_lastbirthday,
DROP COLUMN vbp_displayflags,
DROP COLUMN vbp_otherflags,
...

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.02326 seconds Memory Usage 1,727KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (4)bbcode_php_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (2)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: