| Gastongr |
04-18-2006 04:53 AM |
Need to know if this small code is well written
Hello,
some time ago i took a piece of code from a hack and made this file which displays the latest 5 threads whereever you put it.
PHP Code:
<?php
$db_host = "localhost";
$db_name = "databasename";
$db_user = "username";
$db_pw = "dbpassword";
$forum_url = "http://www.webmastershelp.com";
$limit = "5";
$postedcolor = "#404040";
$fontface = "arial,verdana,geneva";
$txtlimit = "50";
$num = "0";
mysql_connect($db_host, $db_user, $db_pw)
OR die ("Cannot connect to your database");
mysql_select_db($db_name) OR die("Cannot connect to your database");
$tsql = mysql_query("SELECT threadid,title,postusername FROM thread ORDER BY threadid DESC LIMIT $limit");
while($tget=mysql_fetch_array($tsql))
{
$num = $num+1;
$title = $tget['title'];
$tid = $tget['threadid'];
$poster = $tget['postusername'];
echo "<strong>$num.</strong> <a href=\"$forum_url/showthread.php?t=$tid\">$title</a><br /><font color=\"$postedcolor\" face=\"$fontface\" size='1'><i>posted by $poster</i></font><br /><br />";
}
?>
I'm getting mysql errors because "i have reachead" the max allowed mysql conections,
so my question is, could those errors be due to this small file?, is it well done?. i have modifyed it a lot but just small things, i don't really know php.
Could someone tell me if this code is ok?
well,
now that i think about it, i'm using three files like that one.
one for latest threads, one for latest members and one for topposters.
they all connect to the database and request information in everypage. these are the other two:
Newest members
PHP Code:
<?php
$db_host = "localhost";
$db_name = "databasename";
$db_user = "username";
$db_pw = "dbpassword";
$forum_url = "http://www.webmastershelp.com";
$limit = "5";
$txtlimit = "50";
$num = "0";
mysql_connect($db_host, $db_user, $db_pw)
OR die ("Cannot connect to your database");
mysql_select_db($db_name) OR die("Cannot connect to your database");
$tsql = mysql_query("SELECT userid,username FROM user ORDER BY userid DESC LIMIT $limit");
while($tget=mysql_fetch_array($tsql))
{
$num = $num+1;
$title = $tget['username'];
$tid = $tget['userid'];
$poster = $tget['joindate'];
echo "<strong>$num.</strong> <a href=\"$forum_url/member.php?u=$tid\">$title</a><br />";
}
?>
top posters
PHP Code:
<?php
$db_host = "localhost";
$db_name = "databasename";
$db_user = "username";
$db_pw = "dbpassword";
$forum_url = "http://www.webmastershelp.com";
$limit = "5";
$txtlimit = "50";
$num = "0";
mysql_connect($db_host, $db_user, $db_pw)
OR die ("Cannot connect to your database");
mysql_select_db($db_name) OR die("Cannot connect to your database");
$tsql = mysql_query("SELECT userid,username,posts,homepage FROM user ORDER BY posts DESC LIMIT $limit");
while($tget=mysql_fetch_array($tsql))
{
$posts = $tget[posts];
$num = $num+1;
$tid = $tget['userid'];
$title = $tget['username'];
$posts = $tget['posts'];
$homepage = $tget['homepage'];
echo "<strong>$num.</strong> <a href=\"";
if ($homepage == '')
{
echo "$forum_url/member.php?u=$tid\">$title</a>";
}
else
{
echo "$homepage\" target=\"_blank\">$title</a>";
}
echo " <font color=\"$postedcolor\" face=\"$fontface\" size='1'><i>$posts posts</i></font><br />";
}
?>
Anyway to reduce the conections used by these scripts? |
More Information