vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   Multiquote (https://vborg.vbsupport.ru/showthread.php?t=91185)

Andreas 06-26-2005 10:00 PM

Multiquote
 
Multiquote

Credits
This is a port of the vB 3.0.X-Version of Multiquote made by Chroder - all credits to him and Hoffi for the images.

Description (copy & paste as I am lazy ;))
This multiquote hack allows your members to select multiple posts to quote from. These posts can be on a different
page, in a different thread, or on an entirely different forum. Don't worry, the hack checks to make sure the user
has read permissions on the post so no sneaky members can insert random post ID's in hopes to find what's going on
in your secret staff forums.

This Hack is not designed to work with Quick Reply, it also does not quote the last post of a Thread if you click the New Reply button, as this button is meant to reply without quoting the last post.

Details
1 Plugin XML
1 Phrase
1 Template Edit
2 Images
1 JS File
No file edits!

Note: As I did not test this extensivly i'll class it as Beta :)

Please only click Install if you actually have installed/are using this Hack, and click Uninstall when you don't use it any longer!

Bad Bunny 06-27-2005 05:54 PM

Niiice. Thanks to the original hack author, and to you, Kirby.

Allan 06-27-2005 09:23 PM

screenshot please :)

Bad Bunny 06-27-2005 09:28 PM

Quote:

Originally Posted by Allan
screenshot please :)

It's an update of the thread he linked to. Go look at the link for your screenshots.

Chris M 06-27-2005 10:23 PM

Excellent hack Kirby :)

Will be installing this as soon as I get Beta 3 fixed :)

Satan

Frenck 06-28-2005 04:37 AM

Nice hack :) Just what I needed

Forum-Style 06-28-2005 05:21 AM

Very nice, be counting me in for this one :) Great job.

Frenck 06-28-2005 05:37 AM

It seems that it doesn't work with posts that already contain a quote!?

Andreas 06-28-2005 07:17 AM

It does, but just like the normal Quote function it does not quote Quotes :)

Frenck 06-28-2005 07:41 AM

I know, but overhere it does not quote those posts at all!

Normal posts (without any quotes) works fine, single or multiple.
When I use your plugin to quote posts that already have quotes themselfs, than it does not quote anything.

Tested it on a clean vbulletin 3.5.0 beta 3 installation...

One note, maybe that's the problem, I'm quoting a post wich contains a quote of myself...

Andreas 06-28-2005 07:50 AM

Hmm, seems to work just fine for me.
Do you have a Board where I can test this, or tell me exactly how to reproduce the problem?

Frenck 06-28-2005 07:52 AM

I will create a account for you on my dev site. Keep track of your pm inbox ;)

Andreas 06-28-2005 08:25 AM

Problem solved: No problem existed :)
Just misunderstanding:
If you select the last post of a Thread for Multiquote and then click the Big Reply Button it will not be quoted, as this button sets noquote=1 for the last Post.
This is intended behaviour.

jpt62089 06-28-2005 05:54 PM

isnt this a plug in? if so why is it in code mods?

Andreas 06-28-2005 06:01 PM

It comes with an additional JS File, so as of our definition it is not a Plugin ...

jpt62089 06-28-2005 06:10 PM

it does not change the original code tho.... or does it?

Andreas 06-28-2005 06:12 PM

No, it does not touch any vBulletin files.

jpt62089 06-28-2005 06:14 PM

Quote:

Originally Posted by KirbyDE
No, it does not touch any vBulletin files.

then it should be a plug in.... vb.org plugin definition: "Plugins are addons that do NOT require ANY source code modification."

Andreas 06-28-2005 06:16 PM

... if they do not come with additional files.
That's the current definition.
Anyway, this discussion is OT here.

If you want to further discuss this matter we should move on to Site Feedback.

Chris M 06-29-2005 08:58 PM

Code:

  <if+condition="$post['replylink'] AND $show['multiquote']">
          <img+src="$stylevar[imgdir_misc]/mq_img_off.gif"+alt="$vbphrase[multiquote]"+border="0"+width="21"+height="15"+name="multiquote_$post[postid]"+id="multiquote_$post[postid]"+onclick="toggleMultiQuote($post[postid],+this)"+style="cursor:pointer"+/>
  </if>

Invalid template content - Eventually found it:p
Change:
Code:

<if condition="$post['replylink'] AND $show['multiquote']">
to:
Code:

<if condition="$show['replylink'] AND $show['multiquote']">
:)

Satan

Andreas 06-29-2005 09:10 PM

But $show['replylink'] is defined nowhere ....

Chris M 06-29-2005 09:16 PM

Well it wouldn't work with $post['replylink'], and does work with $show['replylink'] for me o_O

Satan

Chris M 06-29-2005 09:22 PM

This is the error I get when I use $post['replylink']:

Quote:

The following error occurred when attempting to evaluate this template:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/xxxx/public_html/forums/includes/adminfunctions_template.php(3504) : eval()'d code on line 188

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.
Satan

Andreas 06-29-2005 09:27 PM

Strange. Does work just fine for me.
And I really can't understand why this would happen, seeing as postbit itself uses $post['replylink']
Anyone else expiriencing the problem?

Chris M 06-29-2005 09:41 PM

Quote:

Originally Posted by KirbyDE
Strange. Does work just fine for me.
And I really can't understand why this would happen, seeing as postbit itself uses $post['replylink']
Anyone else expiriencing the problem?

Hrm strange now I don't see the image on showthread when I use $show['replylink'] and when I try and use your template code it gives me that error :ermm:

It also gives me this error upon trying to view a thread when I click "continue" regardless:

Quote:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/xxxx/public_html/forums/includes/class_postbit.php(241) : eval()'d code on line 188
Satan

Andreas 06-29-2005 09:52 PM

Really strange. Which Version do you use?
Although it does not make sense, did you try to just put the Code in a new Template and save it, does this compile without errors?

Chris M 06-29-2005 09:56 PM

Of vB? 3.5.0 Beta 3 :)

I put it in it's own template, and got this:

Quote:

The following error occurred when attempting to evaluate this template:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/xxxx/public_html/forums/includes/adminfunctions_template.php(3504) : eval()'d code on line 1

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.
It's obviously something wrong in this line:
Code:

<if condition="$post['replylink'] AND $show['multiquote']">
:ermm:

Satan

Andreas 06-29-2005 10:02 PM

Well, if you put only this line then the </if> is missing ...

HTML Code:

<if condition="$post['replylink'] AND $show['multiquote']">
        <img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>

This is the whole code and does compile just fine for me?

Chris M 06-29-2005 10:05 PM

Strange - I took out the ' s and it was fine o_O

Another problem though, unrelated to templates... I think...

If I have a thread with, say, 5 replies - If I select the multi-quote button for posts, 1, 3, 4 and 5, it will only quote posts 1, 3 and 4 :ermm:

What is happening to the last post in the thread?

Edit: The template code you posted above works, but the same code from your .txt file doesn't o_O Weird :p

Satan

Joe Gronlund 06-29-2005 10:08 PM

Quote:

Originally Posted by KirbyDE
Strange. Does work just fine for me.
And I really can't understand why this would happen, seeing as postbit itself uses $post['replylink']
Anyone else expiriencing the problem?


I did with beta 3 just today

Joe Gronlund 06-29-2005 10:11 PM

Quote:

Originally Posted by KirbyDE
Well, if you put only this line then the </if> is missing ...

HTML Code:

<if condition="$post['replylink'] AND $show['multiquote']">
        <img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>

This is the whole code and does compile just fine for me?


yaa that works :)

Andreas 06-29-2005 10:19 PM

Quote:

Originally Posted by hellsatan
What is happening to the last post in the thread?

https://vborg.vbsupport.ru/showpost....0&postcount=13

Quote:

Edit: The template code you posted above works, but the same code from your .txt file doesn't o_O Weird :p
That's really weird, as I just copypasted from the Readme ...

Chris M 06-29-2005 10:27 PM

Bleh - What's the point in multi-quoting if you cannot quote the last post either? :p

Satan

Andreas 06-29-2005 10:32 PM

You can, you must just click Quote.
It's intended behaviour if the Big Reply Button not to quote the last Post, so I kept this.

Do you want a Setting to turn Off this behaviour? :D

Chris M 06-29-2005 10:39 PM

Quote:

Originally Posted by KirbyDE
You can, you must just click Quote.
It's intended behaviour if the Big Reply Button not to quote the last Post, so I kept this.

Do you want a Setting to turn Off this behaviour? :D

Yes please :)

I know I will forget to do this otherwise, and my users, when I have some, will get doublely confused :p

Satan

Bad Bunny 06-30-2005 02:34 AM

Quote:

Originally Posted by Joe Gronlund
I did with beta 3 just today

I'm not sure if this has been brought up, or if anyone had an issue with it. But when I installed it, I had to change all the plus signs to spaces.
I'm on a mac using the default text editor.

Also, I would like to point out that most of my users use quick reply, and we have it so no click is required. If it were possible to have all the normal functionality, but have the quotes selected appear inside a post, it would be useful. But as it is right now, it is a little confusing for novice users.

amykhar 07-07-2005 04:12 PM

With so many people using quick reply now, it's a shame this doesn't integrate with the quick reply box at all.

Biker_GA 07-07-2005 04:26 PM

Quote:

Originally Posted by hellsatan
Edit: The template code you posted above works, but the same code from your .txt file doesn't o_O Weird :p

Satan

I ran into this issue just now as well. The code from the text file didn't work, yet the copied code from Kirby's post worked just fine.

Andreas 07-07-2005 04:42 PM

Quote:

Originally Posted by amykhar
With so many people using quick reply now, it's a shame this doesn't integrate with the quick reply box at all.

Hmm, how do wou want it to integrate?
Of cour I could make it so QR takes all the Quotes selected for MQ, but does that make sense?

Biker_GA 07-07-2005 04:59 PM

Question.. Can the order that the quotes are displayed be reversed? It's showing the most recent post/quote first, rather than the oldest.


All times are GMT. The time now is 04:49 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01470 seconds
  • Memory Usage 1,828KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_code_printable
  • (2)bbcode_html_printable
  • (14)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (2)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete