vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.0 Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=33)
-   -   Kill 1 Query In BBCode Manager (ACP) (https://vborg.vbsupport.ru/showthread.php?t=77264)

Zero Tolerance 02-28-2005 10:00 PM

Kill 1 Query In BBCode Manager (ACP)
 
While looking through bbcode.php in admincp/, i noticed that a global query was executed on all of it's pages, however only 2 actions need this query to be executed, so its a useless query on other pages within the BBCode Manager.

In admincp/bbcode.php
Find:
PHP Code:

$bbcodes $DB_site->query("SELECT bbcodetag, bbcodereplacement, twoparams FROM " TABLE_PREFIX "bbcode");
$searcharray = array();
$replacementarray = array();
$doubleRegex "/(\[)(%s)(=)(['\"]?)([^\"']*)(\\4])(.*)(\[\/%s\])/siU";
$singleRegex "/(\[)(%s)(])(.*)(\[\/%s\])/siU";

while (
$bbcode $DB_site->fetch_array($bbcodes))
{
    if (
$bbcode['twoparams'])
    {
        
$regex sprintf($doubleRegex$bbcode['bbcodetag'], $bbcode['bbcodetag']);
    }
    else
    {
        
$regex sprintf($singleRegex$bbcode['bbcodetag'], $bbcode['bbcodetag']);
    }
    
$searcharray[] = $regex;
    
$replacementarray[] = $bbcode['bbcodereplacement'];


Replace It With:
PHP Code:

if($_REQUEST['do'] == "test" || $_REQUEST['do'] == "modify"){

    
$bbcodes $DB_site->query("SELECT bbcodetag, bbcodereplacement, twoparams FROM " TABLE_PREFIX "bbcode");
    
$searcharray = array();
    
$replacementarray = array();
    
$doubleRegex "/(\[)(%s)(=)(['\"]?)([^\"']*)(\\4])(.*)(\[\/%s\])/siU";
    
$singleRegex "/(\[)(%s)(])(.*)(\[\/%s\])/siU";

    while (
$bbcode $DB_site->fetch_array($bbcodes))
    {
        if (
$bbcode['twoparams'])
        {
            
$regex sprintf($doubleRegex$bbcode['bbcodetag'], $bbcode['bbcodetag']);
        }
        else
        {
            
$regex sprintf($singleRegex$bbcode['bbcodetag'], $bbcode['bbcodetag']);
        }
        
$searcharray[] = $regex;
        
$replacementarray[] = $bbcode['bbcodereplacement'];
    }


I know it's not much, but every little helps!

- Zero Tolerance

nexialys 03-01-2005 03:29 PM

hum.. a Mini Hack... why not release this in the Bug Reports at vb.com ?!!!

Zero Tolerance 03-01-2005 03:33 PM

Hey, 1 thing at a time, here: http://www.vbulletin.com/forum/bugs....iew&bugid=3864

And yes a mini mod, however its result is optomizing the forum, so i put it in here instead :p

- Zero Tolerance

Zachery 03-01-2005 03:38 PM

at least its not being run on ever non acp page :)

ericgtr 03-01-2005 06:54 PM

Quote:

Originally Posted by nexialys
hum.. a Mini Hack... why not release this in the Bug Reports at vb.com ?!!!

Geez dude, you are always the first to post and discredit mods in any way possible, nothing better to do?

Zero, thanks for posting this up, every little bit helps streamline the process. :)

Bad Bunny 03-02-2005 01:40 PM

Quote:

Originally Posted by nexialys
hum.. a Mini Hack... why not release this in the Bug Reports at vb.com ?!!!

Yeah, it does seem like you're the unofficial homeland security of v.org. Nex.

Anyway! Keen eye, and thanks for this.

Zero Tolerance 03-02-2005 02:18 PM

Heh, well i got an expected reply from the vb team:

Quote:

Originally Posted by Scott MacVicar
Not a bug, the code isn't executed enough to justify the change.

Disapointing really, justification of the change shouldn't be based on how much it is executed, executing once is more than enough, personally if i saw a minor area where i could improve the script, i go for it, no matter how small it is. Meh =/

- Zero Tolerance

eva01_ 03-02-2005 02:26 PM

wow that is just a bunch of crap from them, you would think that if they find something that fixes it ever so slightly they would do it

vbulletin seems to me like micro++++

now then we just need something that is like Apple where they care ;)

Polo 03-02-2005 03:53 PM

Quote:

Originally Posted by Zero Tolerance
personally if i saw a minor area where i could improve the script, i go for it, no matter how small it is. Meh =/

- Zero Tolerance

I'm with you on this one Zero Tolerance..... :ermm:

yoyoyoyo 03-02-2005 04:08 PM

I agree- it is total crap for them to give you that reply- what is the point of NOT fixing it?

Corriewf 03-02-2005 04:36 PM

Yeah, I dont run my air conditioning much in my car but when it needs to be charged I am filling that chit up.

eva01_ 03-02-2005 06:20 PM

maybe we will have to create our own forum code that whenever there is a problem it gets fixed no matter how small. :P

either way, great catch zero ^^

Paul M 03-02-2005 06:47 PM

Given some of the very minor bugs they have fixed I find that reply very strange.

Corriewf 03-02-2005 06:56 PM

Yeah, given that the excuse for updating vb versions everyday is discovering problems and fixing them right away..................................

neocorteqz 03-03-2005 02:44 PM

And such a simple fix too. as I see, it's only two lines.

When i upgrade I'll be sure to apply this.

Zero Tolerance 03-03-2005 02:46 PM

Quote:

Originally Posted by neocorteqz
And such a simple fix too. as I see, it's only two lines.

When i upgrade I'll be sure to apply this.

Yeah, the code is just wrapped in an if statement, easy as pie :)

- Zero Tolerance

neocorteqz 03-05-2005 12:08 AM

Quote:

Originally Posted by Zero Tolerance
Yeah, the code is just wrapped in an if statement, easy as pie :)

- Zero Tolerance

You would figure it's such a quick modification they would consider it.

diettalk 03-05-2005 11:28 AM

Isn't reducing a query a good thing... especially on busy boards?

Oblivion Knight 03-05-2005 01:03 PM

Quote:

Originally Posted by diettalk
Isn't reducing a query a good thing... especially on busy boards?

It doesn't really matter in the Admin CP so much.. Still if a query can be killed where it isn't needed, that can only be a good thing and I don't see why Jelsoft aren't taking this into consideration.

neocorteqz 03-05-2005 09:36 PM

Quote:

Originally Posted by Oblivion Knight
It doesn't really matter in the Admin CP somuch.. Still if a query can be killed where it isn't needed, that canonly be a good thing and I don't see why Jelsoft aren't taking thisinto consideration.

Now if my admin panel would load faster, I'd be a happy camper. :D

I agree with you. For the query minded. This would make us happy.

Polo 03-06-2005 03:58 AM

Quote:

Originally Posted by Oblivion Knight
Still if a query can be killed where it isn't needed, that can only be a good thing and I don't see why Jelsoft aren't taking this into consideration.

I totally with you Oblivion Knight

Oblivion Knight 03-16-2005 11:41 AM

I have a feeling this change is the cause of an error when removing custom BB Codes..
Warning: Empty regular expression in /admincp/bbcode.php on line 300


[EDIT]
Yup, I removed the if statement and the error disappeared when removing another custom BB Code.

Yorixz 08-04-2005 05:07 PM

Thanks; all improvements in speed are welcome ;)


All times are GMT. The time now is 02:04 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01263 seconds
  • Memory Usage 1,780KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_php_printable
  • (9)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (23)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete