vb.org Archive - Upgrade from 2.3.0 to 2.3.2 VIA code changes

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 2.x Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=4)

- - Upgrade from 2.3.0 to 2.3.2 VIA code changes (https://vborg.vbsupport.ru/showthread.php?t=57206)

Upgrade from 2.3.0 to 2.3.2 VIA code changes

This hack will allow you to upgrade your board from 2.3.0 to 2.3.2 by using code changes instead of over writing the files.

I will try and help support this hack, if you run into any problems come here and ask for help.

Notice: You still need to run upgrade.php!!

Be Sure to backup your files and database before applying the changes!

I take no responsobility for any damages!

This hack is ONLY for vBulletin 2.3.0!

There may be some mistakes in the file edits if you find any let me know ASAP so I can update the hack.

My bad. Pressed Enter too soon.

I'm not done with it yet so please stand by.

This sounds great but why do you still have to run upgrade php? I mean if its via code means you need to replace/add all the new stuff that came in vb2.3.2 right? or ..am I mistaken oO.

*I think* upgrade.php is still required to make the changes to the database.

I look forward to upgrading to vb2.3.2 the Hostc way, because replacing all the files and then rehacking them would take me several hours.

I agree same here kaotic ^^ and I see..about the database thing I guess Hostc will explain better once hes done.

Quote:

Originally Posted by Airs

I agree same here kaotic ^^ and I see..about the database thing I guess Hostc will explain better once hes done.

The upgrade script will update the database to the current version.

Update:

I should have this finished by tomorrow.

But this will affect all current hacks, right?

Quote:

Originally Posted by MaDCaT75

But this will affect all current hacks, right?

No it will not (unless by luck a modified part of version upgrade is already a modified part of one of your hacks) and this is the whole point of this hack: You can upgrade your board without losing your hacks.. :)

I like these hacks much, unfortunately people don't take time to release them much as they require a lot of work to note what you are doing while upgrading.. So thx to hostc!

So... you're going to set it up today?

Er, is this actually going to be done?

Yea,
I was wondering the same thing!! Should this be in the full release forums when there is nothing there?

Yeah, I hate being teased like this...

Moving this thread to General Hacking Discussion... since the hack is not ready yet...

Sorry for being slow. I've been busy the last couple of days.

I'm at work so I do not have the files on this system.

I have a couple of touch ups to do and I will release it.

Man, great idea hack, but that's a lot of work.

Quote:

Originally Posted by bluecat

Man, great idea hack, but that's a lot of work.

It's that or rehack your board. Baring in mind how many hacks some people have (25/30+ :rolleyes: ) I can understand this being quicker ;)

I did not include the & changes because there were too many file edits.

These are not needed in vb 2.3.2 :)

Now if someone would just do the same but from a 2.2.9 version ... :D

Quote:

Originally Posted by cinq

Now if someone would just do the same but from a 2.2.9 version ... :D

I will be doing one for that version too soon enough.

Is this ready now? and if so has anyone tried it? Please can you let me know. My board is heavily hacked and i don't want to ruin it by running this and it not working.

Thnx

Quote:

Be Sure to backup your files and database before applying the changes!

i'm too scared to try it

Quote:

Originally Posted by MaDCaT75

i'm too scared to try it

Read my above post....

I WOULD BACK UP MY DATABASE BUT I AM NOT IN CONTROL OF THE FORUM'S SERVER

Then have your host do it.

Quote:

Originally Posted by MaDCaT75

I WOULD BACK UP MY DATABASE BUT I AM NOT IN CONTROL OF THE FORUM'S SERVER

Look at this hack - https://vborg.vbsupport.ru/showthread.php?t=37655 - it allows you to run a backup of your Db from the admin panel and also do a restore if anything goes wrong.
It is an excellent hack which has saved me a hell of a lot of work on several occasions.
But to ask again has anyone tried this hack?

edit:

Ok, I have done all the code changes - as laid out in the install.txt and I came across 2 issues:

1.

Code:

FIND:



    if (!isset($mailcache["$touser[templatesetid]"]['email_notify']))



REPLACE WITH:



    if (!isset($mailcache["$touser[templatesetid]"]['emailsubject_notify']))

I couldn't find the

Code:

if (!isset($mailcache["$touser[templatesetid]"]['email_notify']))

and
2.

Code:

FIND:



  makeforumjump();



REPLACE THE BELOW IT with THIS:





  

  // set default value for $daysprune 

  if (empty($daysprune) OR $daysprune < 1) {

          $daysprune = 30;

  }

replace what???

apart from that everything is working ok - I am not sure (because of the two issues above) if it is perfect but if you can let me know about these two issues then thnx it has saved me a hell of a lot of work.

edit: 21:46 GMT

Ok, i have played with it a bit and there is some errors still, there is one } which have to be deleted from both the index.php and forumdisplay.php - but can't remember where exactly sorry - think it was about line 890 - 900
Also when someone tries to vote on a poll I am getting the following error message.

Code:

Database error in vBulletin 2.3.2:



Invalid SQL: UPDATE forum SET lastpost=1064522787 WHERE forumid IN ()

mysql error: You have an error in your SQL syntax.  Check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1



mysql error number: 1064



Date: Thursday 25th of September 2003 08:46:27 PM

any ideas?

Give me a bit, will update it.

Quote:

Originally Posted by Hostc

Give me a bit, will update it.

Ok thnx

Quote:

Originally Posted by Hostc

I will be doing one for that version too soon enough.

Really?

[high]* cirisme can't wait...[/high]

Jiggy,

To fix your poll problem.

in POLL.PHP

Find:

Code:

 // don't do this any more - see http://www.vbulletin.com/forum/showthread.php?t=77713

          //$foruminfo=getforuminfo($threadinfo['forumid']);

          //$DB_site->query("UPDATE forum SET lastpost=$ourtimenow WHERE forumid IN ($foruminfo[parentlist])");

And Remove that. Thats fixed.

NOW For the rest of the updates:

OPEN ROOT\MEMBER2.PHP
FIND:

PHP Code:


		
			
 makeforumjump();

REPLACE THE CODE BELOW IT WITH:

PHP Code:


		
			
 // set default value for $daysprune
    if (empty($daysprune) OR $daysprune < 1) {
     $daysprune = 30;
  }

(Updated coding in showthread.php)

FIND AND REMOVE:

PHP Code:


		
			
$perpage = intval($perpage);

FIND AND REMOVE: (First instance)

PHP Code:


		
			
if ($getpagenum[posts]%$perpage==0) {
      $pagenumber=$getpagenum[posts]/$perpage;
    } else {
      $pagenumber=intval($getpagenum[posts]/$perpage)+1;
    }

FIND:

PHP Code:


		
			
 if ($getpagenum[posts]%$perpage==0) {
      $pagenumber=$getpagenum[posts]/$perpage;
    } else {
      $pagenumber=intval($getpagenum[posts]/$perpage)+1;
    }

REPLACE WITH:

PHP Code:


		
			
 }
  if ($bbuserinfo['maxposts']!=-1 and $bbuserinfo['maxposts']!=0 and $bbuserinfo['maxposts'] <= $newmaxposts) {
   sanitize_pageresults($getpagenum[posts], $pagenumber, $perpage, $newmaxposts, $bbuserinfo['maxposts']);
  } else {
    sanitize_pageresults($getpagenum[posts], $pagenumber, $perpage, $newmaxposts, $maxposts);
  }
  $pagenumber = ceil($getpagenum['posts']/$perpage);

Nope - the poll.php is still not working.... I get the error message

Code:

Database error in vBulletin 2.3.2:



Invalid SQL: UPDATE forum SET lastpost=1064534122 WHERE forumid IN ()

mysql error: You have an error in your SQL syntax.  Check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1

also you are still not very clear about what should be replaced in the member2.php...

you say

Quote:

find makeforumjump(); and REPLACE THE CODE BELOW IT WITH:

well below it i have...

Code:



  // set defaults

  $perpage = intval($perpage);

  if ($perpage==0 or $perpage>200) {  //max of 200, per several users requests

    $perpage=$maxthreads;

  }



  $pagenumber = intval($pagenumber);

  if (!isset($pagenumber) or $pagenumber==0) {

      $pagenumber=1;

  }



  // display threads

  $limitlower=($pagenumber-1)*$perpage+1;

  $limitupper=($pagenumber)*$perpage;



    // set default value for $daysprune 

  if (empty($daysprune) OR $daysprune < 1) {

          $daysprune = 30;

}

  // look at thread limiting options

  $datecut='';

  unset ($daysprunesel);

  if ($daysprune!=1000) {

    $datecut="AND lastpost >= ".(time() - ($daysprune*86400));

  }

  $daysprunesel[$daysprune]="selected";



  if (trim($bbuserinfo[ignorelist])!="") {

    $ignoreusers="AND thread.postuserid<>".implode(" AND thread.postuserid<>",explode(" ",trim($bbuserinfo[ignorelist])));

  } else {

    $ignoreusers="";

  }



  $threadscount=$DB_site->query_first("SELECT COUNT(*) AS threads

                                       FROM thread,subscribethread

                                       WHERE subscribethread.threadid=thread.threadid

                                                                             AND subscribethread.userid='$bbuserinfo[userid]'

                                                 AND thread.visible=1 $datecut $ignoreusers");

  $totalallthreads=$threadscount[threads];



sanitize_pageresults($totalallthreads, $pagenumber, $perpage, 200, $maxthreads);



  // display threads

  $limitlower=($pagenumber-1)*$perpage+1;

  $limitupper=($pagenumber)*$perpage;





  if ($limitupper>$totalallthreads) {

    $limitupper=$totalallthreads;

    if ($limitlower>$totalallthreads) {

      $limitlower=$totalallthreads-$perpage;

    }

  }

  if ($limitlower<=0) {

    $limitlower=1;

  }



  if ($showdots and $bbuserinfo[userid] >= 1) {

    $dotuserid = "DISTINCT post.userid,";

    $dotjoin = "LEFT JOIN post ON (thread.threadid = post.threadid AND post.userid = '$bbuserinfo[userid]' AND post.visible = 1)";

  } else {

    $dotuserid = "";

    $dojoin = "";

  }



  $getthreadids=$DB_site->query("SELECT thread.threadid

                FROM thread,subscribethread

                WHERE subscribethread.threadid=thread.threadid

                  AND subscribethread.userid='$bbuserinfo[userid]'

                   AND thread.visible=1 $datecut $ignoreusers

                 ORDER BY lastpost DESC

        LIMIT ".($limitlower-1).",$perpage

        ");

  $totalthreads=$DB_site->num_rows($getthreadids);



  if ($totalthreads>0) {

   // check to see if there are any threads to display. If there are, do so, otherwise, show message



        $threadids="thread.threadid IN (0";

        while ($thread=$DB_site->fetch_array($getthreadids)) {

                $threadids.=",".$thread[threadid];

        }

        $threadids.=")";



    $threads=$DB_site->query("SELECT $dotuserid icon.title as icontitle,icon.iconpath,thread.threadid,thread.title,

                lastpost,forumid,pollid,open,replycount,postusername,postuserid,lastposter,thread.dateline,views,

                thread.iconid,notes,thread.visible

                FROM thread

                LEFT JOIN icon ON (icon.iconid = thread.iconid)

                $dotjoin

                WHERE $threadids

                ORDER BY lastpost DESC");



    $pagenumbers = '';

    $threadbits = '';

    while ($thread=$DB_site->fetch_array($threads)) {

      if (($bbuserinfo[maxposts] != -1) and ($bbuserinfo[maxposts] != 0))

      {   $maxposts = $bbuserinfo[maxposts];  }

      if (($thread[replycount]+1)>$maxposts and $linktopages) {



        $totalpages=($thread[replycount]+1)/$maxposts;

        if ($totalpages!=intval($totalpages)) {

          $totalpages=intval($totalpages)+1;

        }



        $acurpage=0;

        $pagenumbers="";

        while ($acurpage++<$totalpages) {

          if ($acurpage==$maxmultipage) {

            eval("\$pagenumbers .= \"".gettemplate("forumdisplay_multipagenav_more")."\";");

            break;

          } else {

            eval("\$pagenumbers .= \"".gettemplate("forumdisplay_multipagenav_pagenumber")."\";");

          }

        }

        eval("\$thread[pagenav] = \"".gettemplate("forumdisplay_multipagenav")."\";");

      } else {

        $thread[pagenav]="";

      }



      $thread[icon]="&nbsp;";

      if ($thread[iconid]!=0)

      {

        $thread[icon]="<img src=\"$thread[iconpath]\" alt=\"$thread[icontitle]\" width=\"15\" height=\"15\" border=\"0\">";

      }

      if ($thread[pollid]!=0) {

        $thread[icon]="<img src=\"{imagesfolder}/poll.gif\" alt=\"Poll\" width=\"15\" height=\"15\" border=\"0\">";

      }



      if ($wordwrap!=0) {

        $thread[title]=dowordwrap($thread[title]);

      }



      $replies=$thread[replycount];

      $views=$thread[views];

      $thread[lastreplydate]=vbdate($dateformat,$thread[lastpost]);

      $thread[lastreplytime]=vbdate($timeformat,$thread[lastpost]);



      $thread[gotonew]="";



      $thread[newoldhot]="folder";

      if (!$thread[open]) {

        $thread[newoldhot]="lock".$thread[newoldhot];

      }

      if ($thread[replycount]>=$hotnumberposts or $thread[views]>=$hotnumberviews and $usehotthreads) {

        $thread[newoldhot]="hot".$thread[newoldhot];

      }

      if ($bbuserinfo[lastvisitdate]=="Never") {

        $thread[newoldhot]="new".$thread[newoldhot];

      } elseif ($thread[lastpost]>$bbuserinfo[lastvisit]) {

          if (get_bbarraycookie('threadview', $thread['threadid']) < $thread['lastpost']) {

         $thread[newoldhot]="new".$thread[newoldhot];

          }

          eval("\$thread[gotonew] = \"".gettemplate("forumdisplay_gotonew")."\";");

      }

      if ($showdots and $bbuserinfo[userid] >= 1 and $bbuserinfo[userid] == $thread[userid]) {

         $thread[newoldhot] = "dot_" . $thread[newoldhot];

      }



      eval("\$threadbits .= \"".gettemplate("subscribe_threadbit")."\";");



    }



    $DB_site->free_result($threads);



        $pagenav = getpagenav($totalallthreads,"member2.php?s=$session[sessionhash]&action=viewsubscription&daysprune=$daysprune&perpage=$perpage");



    eval("\$threadslist = \"".gettemplate("subscribe_threads")."\";");

  } else {

    eval("\$threadslist = \"".gettemplate("subscribe_nothreads")."\";");

  }



  // draw cp nav bar

  $cpnav[1]="{secondaltcolor}";

  $cpnav[2]="{secondaltcolor}";

  $cpnav[3]="{secondaltcolor}";

  $cpnav[4]="{secondaltcolor}";

  $cpnav[5]="{secondaltcolor}";

  $cpnav[6]="{secondaltcolor}";

  $cpnav[7]="{secondaltcolor}";

        $cpmenu[8]="class=\"fjsel\" selected";



  eval("\$cpnav = \"".gettemplate("usercpnav")."\";");



  eval("dooutput(\"".gettemplate("subscribe")."\");");

}



?>

which is a hell of a lot of code to work...

another issue i have - and its making me more and more tempted to remove this and restore my forums to the way they were before - is that when i try to lauch the hack vbwar i get an error in the functions.php

Code:

Warning: Division by zero in /home/unklem/public_html/forums/admin/functions.php on line 794

which is part of logicans hack - but when i uninstall that hack the page is just blank... any ideas before i resort back to my old site?

You need to check the vBwar hack and find the file edit that contains edits for functions.php and see what has changed.

in poll.php

Find:

PHP Code:


		
			
       $DB_site->query("UPDATE thread SET lastpost=$ourtimenow WHERE threadid=$threadinfo[threadid]");

Below that add

PHP Code:


		
			
  $DB_site->query("UPDATE forum SET lastpost=$ourtimenow WHERE forumid IN ($foruminfo[parentlist])");

Ok, for MEMBER2.php

Find:

PHP Code:


		
			
  makeforumjump();
  // set defaults
  $perpage = intval($perpage);
  if ($perpage==0 or $perpage>200) {  //max of 200, per several users requests
    $perpage=$maxthreads;
  }
  $pagenumber = intval($pagenumber);
  if (!isset($pagenumber) or $pagenumber==0) {
      $pagenumber=1;
  }
  // display threads
  $limitlower=($pagenumber-1)*$perpage+1;
  $limitupper=($pagenumber)*$perpage;
  if (!isset($daysprune) or $daysprune==0 or $daysprune==-1) {
    $daysprune=30;
  }

Replace with:

PHP Code:


		
			
     makeforumjump(); 
    // set default value for $daysprune
    if (empty($daysprune) OR $daysprune < 1) {
     $daysprune = 30;
  }

Nope that didn't work. Sorry but i have had to revert back to my old forums - I am sure that this hack works, everything else apart from the poll and the wars did so I assume that it was due to the vbwars hack that it failed.
I will ask in that thread if there is any solution and then i will redo your hack.
Thanks for your help in trying to fix it though.

Hmm, did you try uninstalling vbwar on 2.3.0 then try reupgrading? Then reinstall vbwar?

What do you get by upgrading to 2.3.2 this way? if anyone can say ><

I installed and get these errors :(
Invalid SQL: SELECT *
FROM user,userfield
WHERE 1=1 AND
user.userid = userfield.userid
AND usergroupid NOT IN (1,3,4)
ORDER BY username ASC
LIMIT 0,
mysql error: You have an error in your SQL syntax near '' at line 7

mysql error number: 1064

And

Invalid SQL:
SELECT
post.*,post.username AS postusername,post.ipaddress AS ip,style.title AS styletitle,user.*,userfield.*,icon.title as icontitle,icon.iconpath,
attachment.attachmentid,attachment.filename,attach ment.visible AS attachmentvisible,attachment.counter,LENGTH(attach ment.filedata)/1024 AS attachsize
,avatar.avatarpath,NOT ISNULL(customavatar.avatardata) AS hascustomavatar,customavatar.dateline AS avatardateline
FROM post
LEFT JOIN icon ON icon.iconid=post.iconid
LEFT JOIN user ON user.userid=post.userid
LEFT JOIN userfield ON userfield.userid=user.userid
LEFT JOIN avatar ON avatar.avatarid=user.avatarid
LEFT JOIN customavatar ON customavatar.userid=user.userid
LEFT JOIN attachment ON attachment.attachmentid=post.attachmentid
LEFT JOIN style ON style.styleid = user.styleid
WHERE post.threadid='1342'
ORDER BY dateline LIMIT 0,

mysql error: You have an error in your SQL syntax near '' at line 16

mysql error number: 1064

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01840 seconds Memory Usage 1,884KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (8)bbcode_code_printable (10)bbcode_php_printable (10)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (40)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: