Closed Poll thread title
 

A user requested that if a poll is closed the thread be preceeded by Closed Poll: instead of just Poll:.

Here's a few lines of code that did it for us. (see attachment )

All you have to do is insert a few lines of code to forumdisplay.php.

Good luck, hope it helps.

History:

• 1.4
  Added closed poll functionality to search.php in showresult function.
• 1.3
  Added field to poll table lookup.
  Added condition to show poll closed when timeout has occured.
  Elimiated HTML tags for bold since the default vB prefixes are not bold.
• 1.2
  Removed HTML tag for font color.
• 1.1
  Added condition to show poll closed if thread or poll is closed.
• 1.0
  Initial release.

Here's a preview.

Nice

Good idea - i'm going to use this :)

- miSt

nice idea

Nice :D

good idea

...doesn't seem to do anything....strange.....

EDIT: Nevermind. It doesn't work when locking a poll (locking the entire thread, that is).

Does this add a query for every poll in the forum? Or just the closed ones?

A query occurs for each thread with a poll attached that is going to be displayed to see if it is open or closed.

The guys that wrote vB are sharp, we're not dealing with "ALL" the posts in the forum when we do a display. We get the number of threads that is set in the admin panel displayed. So, if I'm reading this code correctly, a forum display of 15 threads occuring would yield - worst case senario if all 15 threads have polls - 15 additional queries per forumdisplay. This is usually about 3 or 4 from what I've seen. Boards with more polls may want to be aware of the over head though.


Thanks. That help?

Regards

We do not have this issue. When we lock a thread with a closed poll, the closed poll tag still shows. Maybe you can show the block of code you edited so we can debug.

Regards

I have a forum that is just for polls. So all of the threads would have polls. Ouch. ;)

When ya think about it in the terms of the amount of queries some pages have, IMHO 15 indexed queries is not really an ouch. I'd think most of the lookups would actually be cached after the first time it ran as well. If you have a way of benchmarking then perhaps a true measure of the overhead could be taken. I'm curious to know how effiecent a single field indexed lookup is or isn't.

Thanks for the reply.

Regards

Your idea here might be a good thing to add to my Polls Start Date and Time hack. I could have it automatically do a Poll Closed when the poll is over. Could I save some queries doing it that way?

Unfortunatly I'm not familiar with the code you refer to, but I'd be glad to look at it. Perhaps we can create a tighter piece of code for the Poll closed hack.

Got a link? Can ya post the code snippet for the hack and where it goes in what form?

Thanks

It's in my signature in this message. ;)

I followed the instructions. I created a new thread, locked the entire thread, and get "Poll:" still.

Anyone else having this problem?

Locking the poll works, but not the thread.

Does it say Closed Poll: before you close the thread?

If the poll is closed yes, they are seperate functions.

Here is the link to my poll hack. Let me know if you think we can combine the two. ;)

https://vborg.vbsupport.ru/attachmen...&postid=372862

Cool addition, small, yet very useful. *clicks install*

Nice idea. :)

It only says "Closed Poll:" when the poll is closed via the moderator edit button. When closing the entire thread all that appears is "Poll:" like normal.

A new version 1.1 is posted with a new condition to show the poll closed if the thread is closed.

Thanks for the feedback.

Regards

I was toast last night and really couldn't see well enough to read your code. I'll look closer at it today.

No problem. Just when you get some time. ;)

OK to this line you need to add the active column name.

That will enable you to do this conditional check and output or similar...

Hope that helps.

Regards

I almost have it. I am working on a small problem. How do I go about get the total votes on a poll. I can pull them out but they look like this:

3|||2|||3|||2|||4|||

Like that. How do I get them into a total?

You can use a foreach loop with an explode statement .

That should work though I didn't test it.


EDIT:
repaired code

Just tried it. It gives me 0 as the total votes and there are 10. ;)

Does $votesstring exist for you? If not did you substitute you var name that contains the ||| delimited string?

Here's my query:

$polldatetime = $DB_site->query_first("SELECT dateline,timeout,active,votes,voters from poll where pollid = $thread[pollid];");

Change $votesstring to $polldatetime['votes'] as below...

EDIT:
repaired code

I tried that just before you wrote this and now the count reads 1 vote. ;)

try

I don't have your code in place to test it for ya.

EDIT:
repaired code

Still only shows 1. ;)

Dammit man, it's my fault!!! I left the $ off of the var...
Here ya go.

I put the $ on the variable when I tried it. It gave me an error until I did. ;)

I left the $ off of 2 vars
$polldatetime['votes']
and
$totalvotes

Oh, ok. Now it works. You meant the $totalvotes variable. You also left it off of the polldatetime['votes'] the first time. LOL Great! Now it work fantastic. Do you want to look over everything now that I have it working to give me your honest opinion? I can pm it to you. ;)

If it's based on your existing code, from what I saw you should be fine.

I guess it's time to post an update to your hack.

I'd be glad to review it.