Well after alot of time leaving it in the beta hacks forums without any problems, I'm now moving it to the Full Releases, I'm satisfied that there isn't any bugs that need to be addressed. Thanks to Jawelin he pointed out most of the mistakes through alot of his testing.
I've attached it as an installer file here, as it needs to make changes to the database. Two new rows to settings and a new column in the attachment table.

Scott

Updated some more :)

Note the > is missing off the bottom of the file after the ?, add it before trying to install

Parse error: parse error in /www/nitrosim/forum/admin/attachment_install.php on line 345

did you upload in ascii mode?

Cause line 345 in the end tag ?>

:)

Yup......Will re-upload it and try it again.

Same error....

COMMAND:> STOR attachment_install.php
STATUS:> Connecting data socket...
150 Opening ASCII mode data connection for attachment_install.php.
STATUS:> Send successful
STATUS:> Time: 0:00:01, Efficiency: 20.51 KBytes/s (21005 bytes/s)
226 Transfer complete.

what is line 345 and I will look at it.

:D Thanks for quoting. ;)

Just an 'old user' question: is the attached installer the same than in Beta section (where it's vanished) ?
Thnx

To fix the problem above try removing any spaces and extra lines after ?>. haven't tried it yet, i'm not at my comp but that might work.

Question: In the file modifications part of the installation, we are told to search for a particular bit in the file editpost.php. In my editpost.php file, the bit to search for occurs two times. The second is about eight lines below the first. Should I add the new code above BOTH instances, or just the first, or just the second?

For the record, I put it above the FIRST instance only. I haven't tested that specific functionality yet, though.

Everything else worked fine. I didn't have any problems at all.

And I'm happy to report that in my database, the attachment table was reduced from 61.9MB to 88kB! Woohoo! :up: :)

I added (like the instruction told) the line twice ;)

Worked perfectly! Thanks PPN! :D

do it twice, its the addition of the function which removes the attachment file.

Ok the issue was of all things the ? didnt have the > after it. Question regarding the functions.php editing portion. The first step says to "REPLACE from that point to the end of the function with". When I do this step it crashes the functions.php any ideas?

define crashes?

you get a parse error?

if you want send me your functions.php to software@pp-network.com and I'll add that of the hack to your file and mail it back.

I tried to test this on my local site, on a Windows PC and I get this error...
I get the same error on my live site too! Any ideas?

I also want to ask something else.
If everything goes well and I install this hack, will it be possible to upgrade to a new version of vBulletin in the future?
I mean, this hack edits the database! What will happen when vBulletin v3.x comes out??

move the file into the admin folder, it needs to check authorisation to make sure your an admin.

It will make upgrading to vB3 a problem as your attachments will be files but they will expect it to be in database, but I'll be rewriting the hack for v3 so there won't be a problem about upgrading. You upgrade as normal then apply the new version of the hack to make it work with 3.0

The instructions do NOT say to add that line twice. I have "Attachments as Files v1.0". In the section for "Changes to
editpost.php (1)", it says,
And that's it.

OK, so I edited my file to put the new bit in twice, once in each spot.

Now some people have told me that they cannot see some of the attachments. I am not having that problem, even after clearing my browser cache, I can still see all attachments fine. I tried posting a new attachment, and I could also see that fine, too. So far, one other person has said he can also see it, while several people have told me they cannot see it. I don't understand this problem at all. How come some people can see attachments (whether post-hack or pre-hack), while some people cannot see any attachments?

have you tried to view the same attachment?

It could be a problem with the type of attachment that it was, though I doubt this as the only part that has been changed is where the content is taken from for the attachment. If the place it takes it from is empty then they would experience a problem. If not does their usergroup have permissions to view attachments?

I posted my problem about not being able to download attachments..(only the admin could). Did you ever get that problem. Or was it fixed? I may just restore a backup, and re-install anyway..

There is no code which is changed which would stop people from downloading attachments, did you make sure the usergroup had permission to view attachments?

Prior to installing this hack, all usergroups were able to download/view attachments. There wasn't a problem before this hack, only after it.

As I mentioned, there is so far only one other person, besides me, that can view attachments. There is another person in the same usergroup as that guy that has said he cannot. I don't think it's a usergroup-based problem.

I can view all the attachments that other people are not able to.

Same thing here.

I have checked and rechecked the user groups. tried numerous things. I am going to revert to an old attachments database, and reload all changed databases and re-install. I'll let you know what happens.

Update: As an unlogged-in visitor, I cannot view attachments.

You can see my attachment test thread, and the replies from all the people that can't see it and the two people (now two instead of one, besides me) that can see it: http://forums.jjr512.com/showthread....threadid=29545

FYI: Doesn't work for me either.. :D Really weird if ya ask me.. hmmm

Thanx PPN :)

We would like to know if it would be possible to make something like an... attachments backup hack.

With this hack, you could save all your attachments as binaries without removing them from the database. It would be really usefull for us ^^

Thanx again ^^

I'm re-installing now. Last time (and this time), I found this:


VISABLE was not included in the string you wanted us to find.
Instead of:

Do I replace what I found? Because when I look for the above line, it is not found..

Sean, this is for vB 2.2.2, the visible part was added as it was missing in 2.2.1

I'll do some testing then, I'll do some testin on my own boards where I implemented this hack.
I know for a fact that the attachments are there as I can view them via shell and ftp. So there must be an error in the top 30 lines or so.

Is everyone running 2.2.2?

Ok, I've worked out the problem now :)

sorry about all the problems.

Look for

Please ensure that visible is there in that list, this is super super important as if it isn't then only moderators and admins will be able to view it as they have permission to moderate attachments.

Im running 2.2.2 but have not tried it since you sent me the functions.php

Well, we have found the problem. Thanks PPN! This hack rocks! :D

i'll just apologise some more, it was an oversight as I done this hack on 2.2.1 but the visible thing was a bug and was fixed in 2.2.2 and when i upgraded from 2.2.1 to 2.2.2 i just added visible on the end of the list and added that code so thats how I never noticed it.

Anyway i'll look into making an attachment backer upper. The simpliest way I guess would be to simply zip them all and I have some code to do that but you would need to have zlib installed so I can use the gzip functions.

Yep, it seems to be working fine now. :up:

goood :D

it is a stable release then lol

Attachment backer upper was scary though, the zip was quite hefty. I've added an option to either save it or download it.

Prior to installing this hack, using phpMyAdmin, I had it do a dump of just the attachments table, doing structure and data. It's past the point where it matters now, but that was good enough for a backup, right? Or does your backup addition do something else...

Yeah thats a backup, all the data and the structure.
You'll need to do it with this along with the files, though the attachment table should only be a couple of kb instead of mb.

I dumped only the attachment table just before applying the hack, using mysqldump for instance.
After the export to files, as you'll see, that table will remain the same as before.
After having successfully applied and verified all the hack, you can empty the filedata column of that table with a simple UPDATE by phpMyAdmin, then reOPTIMIZE the table and freeup a lot lot of space... :up:
Bye

I'm glad this is workin now and thanks for all your help Jawelin :)

Do you thank me ? :)
Great work, simply!

P.S.: now you have to modify your sig.... ;)