vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   New Posting Features - Chrome Browser Notice (For Quick Reply Editor) - How to fix non-working space bar (https://vborg.vbsupport.ru/showthread.php?t=323807)

BirdOPrey5 11-04-2016 10:00 PM

Chrome Browser Notice (For Quick Reply Editor) - How to fix non-working space bar
 
1 Attachment(s)
If you are not already aware the latest version of Chrome browser (Version 54.0.2840.71, possibly others) has introduced a bug or incompatibility with the version of CKEditor used in VB 4.x.

If a user attempts to use the "Reply With Quote" feature on an existing post and begins to type their reply under the existing quote without hitting the Enter key first, the space bar will not work.

The issue is talked about on vBulletin.com here: http://www.vbulletin.com/forum/forum...rking-on-reply

While this is not a true fix, it does display a notice above the quick reply editor advising Chrome users that they can fix the problem simply by hitting the Enter key. (See Screenshot.)

https://vborg.vbsupport.ru/external/2016/11/1.png?1

The actual text displayed is held in a Global phrase called chrome_editor_message_bop5 so it is easily edited or translated as needed using Phrase Manager in the Admin CP.

There are no options, just install it and it will become active. Disable or remove the product to stop using it.

Notice will only be displayed in Chrome browser and when the enhanced WYSIWYG editor is enabled in the user's options. The Standard Editor and Basic Editor do not have this bug.

The function that attempts to determine the browser version was publicly available, location it can be found is a comment in the Functions plugin.

This mod will only install on VB 4.x versions and is only useful with VB 4.x versions 4.1.12 and above. May not work on heavily customized styles.

------------------------------------------------------

Please "Mark as Installed" if you use this. :)
Donations always appreciated. :up:
Nominate MOTM if you LOVE it! ;)

BirdOPrey5 11-05-2016 10:19 AM

Reserved.

BirdOPrey5 11-06-2016 12:11 PM

<span style="text-decoration: line-through">Well, I guess this was a waste of my time.

Google has already pushed out an update with Chrome that fixes the issue. The new version on Win 10 64 bit is 54.0.2840.87.

If you have already installed it maybe give it a week or so for everyone to update and then remove it. No need for it.</span>

Edit - Not true.

andryus 11-06-2016 03:14 PM

I am getting the same issue with the latest chrome update ( 54.0.2840.87 m )

Kane@airrifle 11-06-2016 06:09 PM

Quote:

Originally Posted by andryus (Post 2577881)
I am getting the same issue with the latest chrome update ( 54.0.2840.87 m )

As am I and my users.

BadgerDog 11-06-2016 06:24 PM

Quote:

Originally Posted by BirdOPrey5 (Post 2577874)
Well, I guess this was a waste of my time.

Google has already pushed out an update with Chrome that fixes the issue. The new version on Win 10 64 bit is 54.0.2840.87.

If you have already installed it maybe give it a week or so for everyone to update and then remove it. No need for it.

I've found your code and contributions are never a waste of time .. :up:

Thanks for doing this .. :)

Regards,
Doug

BirdOPrey5 11-06-2016 11:57 PM

Quote:

Originally Posted by andryus (Post 2577881)
I am getting the same issue with the latest chrome update ( 54.0.2840.87 m )

Quote:

Originally Posted by Kane@airrifle (Post 2577886)
As am I and my users.

Have you restarted your browsers and perhaps cleared your cache? I know I cleared my cache for a different reason but it definitely works for be after restarting the browser.

andryus 11-07-2016 12:56 AM

Quote:

Originally Posted by BirdOPrey5 (Post 2577894)
Have you restarted your browsers and perhaps cleared your cache? I know I cleared my cache for a different reason but it definitely works for be after restarting the browser.

Sure, already tested, still with the same issue with the latest chrome update, tested on different computers with clean chrome.

BirdOPrey5 11-07-2016 08:55 AM

So weird... seems like it is still broke for me. I thought changing styles would have reloaded the CSS but I had to clear my cache and once I did the problem was back.

There is no working fix yet from Chrome, sorry for the confusion.

DeMonViTo 11-09-2016 11:29 AM

Hello thanks for the mod!
I have the same problem even when I reply to private messages, you could place the warning them also?

BirdOPrey5 11-09-2016 04:54 PM

I'll need to take a closer look. A quick glace suggests it possible but more difficult. Will get back to you here.

Please "Mark as Installed" if you're using it.

Kane@airrifle 11-10-2016 05:26 AM

This mod is still relevant.

The issue remains in Chrome 54.0.2840.99 m

sticky 11-15-2016 01:46 PM

Such a joke Vbulletin can't fix this.

In Omnibus 11-15-2016 01:52 PM

Quote:

Originally Posted by sticky (Post 2578199)
Such a joke Vbulletin can't fix this.

Why are you blaming vBulletin for a problem with the Google Chrome web browser and the CKEditor, neither of which are developed by vBulletin?

Paul M 11-16-2016 05:47 PM

Quote:

Originally Posted by sticky (Post 2578199)
Such a joke Vbulletin can't fix this.

The only "joke" is people who make clueless comments about things they dont seem to understand. This is a bug/issue in Chrome, so I suggest you go and moan at them.

Paul M 11-16-2016 08:50 PM

Oh, and since none of this is relevant to support of the mod, any further arguments will be removed.

Stratis 11-17-2016 01:14 PM

I have many issues with IE 11, so its a good advice to start fixing these problems to.
Wow!!! that's very cool.


Any way just joking, I am not writing here to say what must be done or not?


But please Admins you must remove all these post and mine to another new thread. At least we must respect Joe for his help until something changes.


Thanks and sorry for interfering :)

TerryMason 11-18-2016 12:00 AM

Thank you for this mod!

Hopefully chrome will fix this issue before too long.

gatsman 11-25-2016 06:06 AM

Thanks for your work mate.

This is only for Quick Reply Editor.
Is there a way to have this mod in the full editor too?

sticky 11-29-2016 01:24 AM

I installed this and it's working.

Edit: Actually, had to uninstall. Not sure why but certain pages won't load for me when it's enabled.

MarkFL 11-29-2016 01:54 AM

Quote:

Originally Posted by sticky (Post 2578869)
...Edit: Actually, had to uninstall. Not sure why but certain pages won't load for me when it's enabled.

If you let the developer (Joe) know which pages won't load, he would have a better chance of addressing the issue if he knows what to look for. ;)

bazookajoe 12-04-2016 02:09 PM

Is anything being done with this mod?

I.G.O.T.A. 12-05-2016 05:26 PM

Subscribed.

Mark.B 12-05-2016 07:55 PM

Quote:

Originally Posted by bazookajoe (Post 2579135)
Is anything being done with this mod?

Such as?

It's just a notice above the editor. Not sure what else you think should be done with it.

Psalmist 12-07-2016 02:47 PM

Installed it and the notice does indeed show above the quick reply for posts, but what about the quick reply for private messages? Actually that's where our users are having the space bar issue so that is where we need the notice. How can we make it appear there also?

BirdOPrey5 12-08-2016 09:03 AM

1 Attachment(s)
Hey all,

I looked at putting it by PMs and while it is possible it is a lot of extra work. While I started looking at the code I had a thought.

As much as I like mods the reality of the situation is this- I think this is much more gracefully handled by the vBulletin Notices System.

My suggestion:

Go to Admin CP -> Notices -> Add New Notice

Title: Editor Notice
Notice HTML:
HTML Code:

<strong>Possible bug when replying to posts or Private Messages, please read.</strong>
<br />
A bug in newer versions of Chrome and Opera browsers (and possibly others) may cause your space bar not to work when replying to posts, private messages or other content on the forum. If you find your space bar isn't working simply press your <strong>&lt;Enter&gt;</strong> key a couple times inside the post and the space bar will work again. We hope this will get fixed in a future update of the browser.<br / >

To close this message click the "X" on the top right corner.

Active, Persistent, and Dismissible all set to yes.

No reason to show it to guests they can't reply anyway so check the box for "User does not belong to usergroup" and select Unregistered / Not Logged In as the usergroup not to display it to and save changes.

I implemented this on my own site. I kept the mod installed as an extra reminder but the notice is good info for everyone. They can dismiss it and never see it again but they (may) remember to just hit enter and be done with it should they get the problem.

BirdOPrey5 12-08-2016 09:11 AM

Quote:

Originally Posted by MarkFL (Post 2578870)
If you let the developer (Joe) know which pages won't load, he would have a better chance of addressing the issue if he knows what to look for. ;)

I'd be most curious if I can duplicate the issue.

bazookajoe 12-08-2016 03:18 PM

Quote:

Originally Posted by Mark.B (Post 2579173)
Such as?

It's just a notice above the editor. Not sure what else you think should be done with it.

Yep...Sorry, I meant to ask if any fix was forthcoming for this bug. My bad.

Kane@airrifle 12-08-2016 05:24 PM

Adding this to to the bottom of editor_contents.css seems to get the space bar working with the WYSIWYG editor on my board.

Code:

@supports (-webkit-appearance:none) {
body.forum {white-space: pre-wrap;}
}

The added blank lines that appear in the quoted post disappear on posting.

YMMV

sticky 12-09-2016 11:54 PM

Quote:

Originally Posted by Kane@airrifle (Post 2579251)
Adding this to to the bottom of editor_contents.css seems to get the space bar working with the WYSIWYG editor on my board.

Code:

@supports (-webkit-appearance:none) {
body.forum {white-space: pre-wrap;}
}

The added blank lines that appear in the quoted post disappear on posting.

YMMV

Hey! This works.

The only problem is the issue still persists in PM's. Forum posting is fixed though when quoting.

Kane@airrifle 12-10-2016 08:07 AM

Quote:

Originally Posted by sticky (Post 2579281)
Hey! This works. LOL, you're better than Vbulletin support.

The only problem is the issue still persists in PM's. Forum posting is fixed though when quoting.

I take no credit, this kludge was posted elsewhere by man1c.

To get it to work in PMs and Quick reply add this to the bottom of editor_contents.css.

Code:

/*-- Temporary Chrome Spacebar Fix --*/
@supports (-webkit-appearance:none) {
body.forum {white-space: pre-wrap;}
body.content {white-space: pre-wrap;}
}


BirdOPrey5 12-10-2016 11:00 AM

Quote:

Originally Posted by Kane@airrifle (Post 2579251)
Adding this to to the bottom of editor_contents.css seems to get the space bar working with the WYSIWYG editor on my board.

Code:

@supports (-webkit-appearance:none) {
body.forum {white-space: pre-wrap;}
}

The added blank lines that appear in the quoted post disappear on posting.

YMMV

If you like it, then that's great. For me I feel like if I have to explain to my users to not worry about the extra blank lines I might as well just tell them to hit the enter key to get the space bar working again.

z3r0 12-10-2016 05:46 PM

Quote:

Originally Posted by Kane@airrifle (Post 2579296)
I take no credit, this kludge was posted elsewhere by man1c.

To get it to work in PMs and Quick reply add this to the bottom of editor_contents.css.

Code:

/*-- Temporary Chrome Spacebar Fix --*/
@supports (-webkit-appearance:none) {
body.forum {white-space: pre-wrap;}
body.content {white-space: pre-wrap;}
}


That wasn't what I (man1c) posted, this was:-

Code:

@supports (-webkit-appearance:none) {
body.forum {white-space: pre-wrap;}
}

You also need to turn off quick edit for it to work properly without any extra whitespace issues for anybody.

Kane@airrifle 12-10-2016 06:19 PM

Quick edit, on or off, the white space is there while replying on my board. On posting the whitespace goes away in any event.

Code:

body.content {white-space: pre-wrap;}
The added line above is to get rid of the issue in the PM system.

Quote:

If you like it, then that's great. For me I feel like if I have to explain to my users to not worry about the extra blank lines I might as well just tell them to hit the enter key to get the space bar working again.
Sadly, it's been my experience that the average user takes zero notice of stickies, notices or announcements. This is the case on my board where this mod is implemented but nevertheless got threads and PMs asking about the spacebar.

It is what it is....

z3r0 12-10-2016 06:54 PM

Strange, all my sites absolutely fine after the edits & QE off - could be a combination of other stuff that's been installed/modded though.

sticky 12-11-2016 01:52 AM

Quote:

Originally Posted by z3r0 (Post 2579304)
That wasn't what I (man1c) posted, this was:-

Code:

@supports (-webkit-appearance:none) {
body.forum {white-space: pre-wrap;}
}

You also need to turn off quick edit for it to work properly without any extra whitespace issues for anybody.

If you remove quick edit then the extra spaces disappear?

sticky 12-11-2016 01:54 AM

Quote:

Originally Posted by Kane@airrifle (Post 2579306)

Sadly, it's been my experience that the average user takes zero notice of stickies, notices or announcements. This is the case on my board where this mod is implemented but nevertheless got threads and PMs asking about the spacebar.

It is what it is....

Exactly the same way on my board. Even if the issue is sticky'd and in my sig people still kept complaining and asking what was wrong.

Thank you so much! Seriously, thank you. You're a lifesaver.

Paul M 12-12-2016 12:10 AM

Off topic posts removed.
Last warning, any more digs, or other posts not related to support or use of this mod will get you a suspension.

andryus 12-30-2016 01:49 PM

How i can use it only for PM? because i have issues only with PM ( space bar not working when you send a PM )

Thanks!

andryus 12-30-2016 01:55 PM

Quote:

Originally Posted by Kane@airrifle (Post 2579296)
I take no credit, this kludge was posted elsewhere by man1c.

To get it to work in PMs and Quick reply add this to the bottom of editor_contents.css.

Code:

/*-- Temporary Chrome Spacebar Fix --*/
@supports (-webkit-appearance:none) {
body.forum {white-space: pre-wrap;}
body.content {white-space: pre-wrap;}
}


This worked also for me, PM works great now

Thanks!!! :D:D:):)


All times are GMT. The time now is 06:24 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01531 seconds
  • Memory Usage 1,840KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (9)bbcode_code_printable
  • (1)bbcode_html_printable
  • (19)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete