vb.org Archive - Navbar Links Problems

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB4 Design and Graphics Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=253)

- - Navbar Links Problems (https://vborg.vbsupport.ru/showthread.php?t=320821)

InSite

11-18-2015 11:47 PM

Navbar Links Problems

1 Attachment(s)

Hello all, and thanks for any help you can provide with this problem I'm having.

I (still) use vBulletin Advanced as my website portal, which unfortunately is not supported anymore. On pages generated by vBA I'm having a strange problem with the navbar submenu links. On all except the last page listed, the submenu links appear to be overwriting themselves several times, stacked, giving the appearance of bold text. On the last page however, no matter which page I choose to display last, the submenus display correctly (as they do on the main Forums page).

Here are some screenshots to help describe the problem:

https://vborg.vbsupport.ru/attachmen...1&d=1447897260

Here the second menu appears to be bold. However if I copy and paste the text from this area, I get the following:

Code:

Home

About Forum Actions Forum Settings Join

Forum

Chat

Live Streams

Videos

About Forum Actions Forum Settings Join

Articles

About Forum Actions Forum Settings Join

Links

About Forum Actions Forum Settings Join

And this is what the last page will look like. If I change the order of the pages in vBA, whichever is last displays correctly:

https://vborg.vbsupport.ru/attachmen...1&d=1447897260

Also, as a more general question, is there an easy way to display the default forum submenu links on external pages other than reentering them in Navigation Manager for every single page? It's very frustrating! I'd prefer to have the navbar and subnav menus disabled in vBA and use Navigation Manager, but this doesn't seem to work even when I declare the THIS_SCRIPT value.

Thanks again, much appreciated! :)

InSite

11-23-2015 01:08 AM

Noone else has come across this? It happens on a default style too.

Does anyone know where vBA may loop the menu from? Any indication where to look?

Also does anyone know how to add these links across other scripts and pages on my website? Some mods create whole new pages using the header and footer, but the sub menu links aren't included for some reason.

Thanks :)

Dragonsys

11-23-2015 02:02 AM

Quote:

Originally Posted by InSite (Post 2559175)

it does not happen on any of my sites running CMPS.
As for other pages, those links are specific to the page. You can copy them to other pages via the Nav Manager in the ACP.

InSite

11-23-2015 02:07 AM

Thanks for the reply :)

Quote:

Originally Posted by Dragonsys (Post 2559178)

it does not happen on any of my sites running CMPS.
As for other pages, those links are specific to the page. You can copy them to other pages via the Nav Manager in the ACP.

[S]Is CMPS the official vBulletin release? If so, I don't have access to that as I bought my vBulletin 4 license before it was released. I'm therefore using vBulletin Advanced, which is no longer supported by the developer.[/S]

Strange, I get this on a default installation and style with the latest vBulletin / vBA releases. Something must be causing a loop for the nav sub links menu for each additional page I have on my portal.

For the other pages, is there a quicker way to copy all the nav links from the forums to other pages, or do I have to recreate them all one at a time for each new page?

Dragonsys

11-23-2015 01:18 PM

There is a Nav Manager Enhancement mod around here somewhere, it might be able to copy those links, or you can do it from within the Database itself.

Have you made any changes to CMPS to make it display the subnav menu on all pages? (such as mentioned in this thread - http://www.vbadvanced.com/forum/show...138#post201138)

InSite

11-23-2015 05:36 PM

No template modifications to vBA - all the templates are default.

Dragonsys

11-23-2015 07:11 PM

hmmm, not sure then, as I have never seen this issue. You can see examples of my sites using CMPS here: Site 1 & Site 2

Let me know if you see the same thing on these sites.

InSite

11-23-2015 07:22 PM

Quote:

Originally Posted by Dragonsys (Post 2559224)

hmmm, not sure then, as I have never seen this issue. You can see examples of my sites using CMPS here: Site 1 & Site 2

Let me know if you see the same thing on these sites.

Thanks so much for your help with this :)

It wouldn't show up on either of these sites. For site 1 you are not using the default forum links, and on site 2 you only have 1 portal page. It doesn't show up on the *last* portal page, which for you would be your first.

What seems to be happening is that the entire sub menu links is loading for every link, but only being displayed for the selected tab. But it is still there as selectable text. Even on your site 2 for example, if you select the top text you get this:

=============
HOME
New PostsFAQCalendarCommunity Forum Actions Quick Links
WHAT'S NEW?
FORUMS
FACEBOOK
MMO Crossroads Forums - Powered by vBulletinLOG IN REGISTER
=============

So I assume if you had a second vBA page called Links, you'd see something like this:

=============
HOME
New PostsFAQCalendarCommunity Forum Actions Quick Links
WHAT'S NEW?
FORUMS
FACEBOOK
MMO Crossroads Forums - Powered by vBulletinLOG IN REGISTER
LINKS
New PostsFAQCalendarCommunity Forum Actions Quick Links
=============

And the HOME and LINKS sub menus would write on top of each other (maybe because they share the same THIS_SCRIPT). So I wonder if this is a CSS issue?

Do you have a site that uses the default forum links and has more than one vBA page?

Dragonsys

11-23-2015 07:38 PM

true, I did customize the NavBar a lot on the first site. Let me install CMPS on my dev site tonight, and see if I can duplicate this.

InSite

11-23-2015 07:40 PM

Thanks so much - I really appreciate the help :)

Dragonsys

11-23-2015 11:46 PM

Ok, I added it here - http://dragonsys.noip.me/vb4/portal.php
I still don't see the double text like in your images.

I can give you an account on that site if you want to add pages and see if you can repeat the issue.

InSite

11-23-2015 11:51 PM

It's there, on Test 1:

===========
TEST1
New PostsFAQCalendarCommunity Forum Actions Quick Links
TEST2
New PostsFAQCalendarCommunity Forum Actions Quick Links
===========

If you add more test pages, they will start to stack up until you can see them. Add 2 more pages, and then check Test 1 again :)

Saw your edit - sure, I'd be happy to try and replicate it there. Feel free to PM me. BTW, did I say thanks again? You are awesome :)

Dragonsys

11-23-2015 11:54 PM

Ok, I'm not seeing the bold text, like in your images, but I see what you are getting at now.
It looks like a "fix" was added in the latest version to try and get all the people complaining about the submenu not showing to settle down, but it was implemented badly.

it is using a float to try and hide the send submenu

I will play around and see if I can get a patch

InSite

11-23-2015 11:57 PM

Yeah, I don't see it in yours yet, but the more pages that are added, the more times it overwrites the menu and you start to see them.

I'm glad I'm not going crazy! I've been updating my site a lot lately, and this has been driving me crazy, even though I'm sure no-one else would notice it! :D

You are a a credit to this community - it's nice to see people like you still around and supporting vBulletin. It's what made this community and software so great, and it's very much appreciated :)

Dragonsys

11-24-2015 12:00 AM

if you add a submenu item to your pages, that should clear up as it will show that item instead.

InSite

11-24-2015 12:03 AM

Quote:

Originally Posted by Dragonsys (Post 2559274)

if you add a submenu item to your pages, that should clear up as it will show that item instead.

I was hoping to have the same submenu throughout the entire website, which is currently using the forums submenu. I tried to disable the menu in vBA altogether and use Navigation Manager, but this had its own problems with vBA and the selected tab.

Dragonsys

11-24-2015 01:20 AM

Quote:

Originally Posted by InSite (Post 2559275)

Ok. Give me a few days and I will try to get a fix, if someone doesn't sooner

--------------- Added [DATE]1448337506[/DATE] at [TIME]1448337506[/TIME] ---------------

Ok, it didn't take me as long as i thought it would, lol
Open the adv_portal_navtab template
Find:

Code:

<vb:if condition="$tab['children']">

Replace with:

Code:

<vb:if condition="$tab['children'] AND $tabselected">

You can see this in place on the test site I posted above

InSite

11-24-2015 02:33 AM

This fixes the problem for the home page and child pages (THANKYOU!), but for separate pages that do not have a vBA parent page it removes most of the top tabs, including the default Forum tab :)

(Setting Add Navbar Tab to None makes it work, setting it to Start or End causes the above problem.

Dragonsys

11-24-2015 02:34 AM

well dang it...
I don't see that happening on my site. Neither of the pages have a parent, and all the tabs are intact. Can you give me a screenshot?

InSite

11-24-2015 02:42 AM

1 Attachment(s)

https://vborg.vbsupport.ru/attachmen...1&d=1448340123

Here you go :)

So the subnav is working, but now on pages where there is a main tab displayed with no parent, the OTHER tab elements have disappeared. This was when I selected my Articles tab.

Dragonsys

11-24-2015 02:45 AM

I am not seeing that on my site. Try replacing the entire adv_portal_navtab with the below:

HTML Code:

<li<vb:if condition="$tabselected"> class="selected"</vb:if>><a href="{vb:raw vboptions.vba_portal_homeurl}<vb:if condition="$cmps_page['name'] == 'home'">{vb:raw session.sessionurl_q}<vb:else />?{vb:raw session.sessionurl}{vb:raw vboptions.vba_portal_pagevar}={vb:raw cmps_page.name}</vb:if>" class="navtab">{vb:raw cmps_page.title}</a></li>

<vb:if condition="$subpagelinks">

        <ul class="floatcontainer">

                {vb:raw subpagelinks}

        </ul>

</vb:if>



<vb:if condition="$tab['children'] AND $tabselected">

        <ul class="floatcontainer">

                <vb:each from="tab.children" value="link">

                        <vb:if condition="$link['children']">

                                <li class="popupmenu" id="{vb:raw link.name}">

                                        <a href="javascript://" class="popupctrl">{vb:raw link.title}</a>

                                        <ul class="popupbody popuphover">

                                                <vb:each from="link.children" value="sublink">

                                                        <li id="{vb:raw sublink.name}"><a {vb:raw sublink.target}href="{vb:raw sublink.url}">{vb:raw sublink.title}</a></li>

                                                </vb:each>

                                        </ul>

                                </li>

                        <vb:else />

                                <vb:if condition="$link['type'] == 'link'">

                                        <li id="{vb:raw link.name}"><a {vb:raw link.target}href="{vb:raw link.url}">{vb:raw link.title}</a></li>

                                </vb:if>

                        </vb:if>

                </vb:each>

        </ul>

</vb:if>

InSite

11-24-2015 02:48 AM

This has fixed it - it all seems to be working perfectly now! I will go through your code and my previous code and update this later to say what the difference was incase you are curious. But thank you SO much for your time! :)

Dragonsys

11-24-2015 02:50 AM

Quote:

Originally Posted by InSite (Post 2559288)

Awesome, glad it is working now :)

InSite

11-24-2015 02:53 AM

There was no difference in the code at all, other than I had commented out the original line you asked me to change. Maybe the above error was a temporary browser issue or a gremlin.

Anyway, nicely done sir! My OCD is already feeling better! :D

All times are GMT. The time now is 03:53 AM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01309 seconds Memory Usage 1,807KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_code_printable (1)bbcode_html_printable (6)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (24)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: