vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB5 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=262)
-   -   Disable HTML Code - Security? (https://vborg.vbsupport.ru/showthread.php?t=317710)

shimei 03-09-2015 11:30 PM

Disable HTML Code - Security?
 
Hello,

I was wondering whether others were experiencing the same issues as I am. I keep notes by tracking the forum changes I make. I tried to post the following code into my VB 5.1.5 under an admin account:

Code:

<!--added table -->
<table class="forum-list-container stretch catspace">

It breaks the site's layout. I went to usergroup permissions and disabled Allow HTML Code, I also checked Channel Permissions.

I feel like my site is a sitting duck awaiting for someone to wreck havoc on it.

Lynne 03-10-2015 07:10 PM

You tried to post that code where? You are posting it in a thread? If so, post it in [ code ] tags.

shimei 03-11-2015 05:18 PM

Quote:

Originally Posted by Lynne (Post 2540058)
You tried to post that code where? You are posting it in a thread? If so, post it in [ code ] tags.

Hi Lynne,

That's exactly what I had done. I make notes in the forum of the changes I make to the website. I put that in the code tags of a thread. Regardless, it breaks the layout.

Lynne 03-12-2015 05:58 PM

Are you putting the html in HTML tags or CODE tags? Now that I think about it, CODE tags will 'parse' what is in there; HTML tags should not.

shimei 03-12-2015 07:39 PM

Hello Lynne,

I am a little unclear about what you mean. I pasted in plain text in code tags.

In or out of the [ code ] tags the code disappears and wrecks the site. Luckily I was able to delete the post because I was still looking on it and did not navigate away from it on one browser. If I even post the following:

<!-- Categories -->

The above code cannot be seen in my page in or outside the code tags. Is this a security issue? I can't see how it isn't because all one needs do is post some code in the browser and my site is wrecked on 5.1.5. I have set no to allow html code wherever it is an option in the admincp, and that's the only thing I could come close to assuming that would prevent it.

I have filled out a support ticket with Vbulletin but it has been days and no solution. If someone post a code into the browser and my site goes down how can I find the post when no posts are visible. Would I have to go to the database and find the culprit post and delete it?

Thanks William

ForceHSS 03-12-2015 08:39 PM

If you allow the admin group to post html code and allow html in the section you need it should work if you only want yourself to post html code make a new admin group and move yourself to it then give that group only html permissions.
Warning: html coding can break your site and cause security problems if you don't know what you are doing

shimei 03-12-2015 08:46 PM

Quote:

Originally Posted by ForceHSS (Post 2540291)
If you allow the admin group to post html code and allow html in the section you need it should work if you only want yourself to post html code make a new admin group and move yourself to it then give that group only html permissions.
Warning: html coding can break your site and cause security problems if you don't know what you are doing

Right, I had disabled html coding in all groups and channel permissions. The result is the same and which led me to posting this.

Thanks for your time though,
Shim

ForceHSS 03-12-2015 08:51 PM

Can you post some screenshots with the code breaking and without and a link to your site so someone can give you the correct code if they can

Replicant 03-12-2015 09:02 PM

If you are posting just the code in the original post, it probably will break the page since there is no closing tag for the table. If you want to view the raw html in the post, have you tried the noparse bbcode?
Code:

[noparse]<!--added table -->
<table class="forum-list-container stretch catspace">[/noparse]


Lynne 03-12-2015 09:35 PM

Quote:

Originally Posted by shimei (Post 2540288)
Hello Lynne,

I am a little unclear about what you mean. I pasted in plain text in code tags.

I mean you should use [ HTML ] tags instead of [ CODE ] tags.

HTML Code:

<!--added table -->
<table class="forum-list-container stretch catspace">

not
Code:

<!--added table -->
<table class="forum-list-container stretch catspace">


shimei 03-12-2015 10:07 PM

Quote:

Originally Posted by ForceHSS (Post 2540293)
Can you post some screenshots with the code breaking and without and a link to your site so someone can give you the correct code if they can


Here's the result of having posted between either [ code ] or [ html ] tags as Lynne suggested. As you can see the entire site is wrecked (blank).

https://vborg.vbsupport.ru/external/2015/03/15.jpg

--------------- Added [DATE]1426201908[/DATE] at [TIME]1426201908[/TIME] ---------------

and here it is before I enter the code:

https://vborg.vbsupport.ru/external/2015/03/16.jpg

--------------- Added [DATE]1426202159[/DATE] at [TIME]1426202159[/TIME] ---------------

Quote:

Originally Posted by Replicant (Post 2540296)
If you are posting just the code in the original post, it probably will break the page since there is no closing tag for the table. If you want to view the raw html in the post, have you tried the noparse bbcode?
Code:

[noparse]<!--added table -->
<table class="forum-list-container stretch catspace">[/noparse]


Hello Replicant,

Thank you for your support. I have not, my concern at this point is that anyone can enter code into the browser by creating a thread or replying to a post and wrecking the site.

At this point, I'm hoping someone will tell me how to find the post in the database once the site has been wrecked?

Of course, I think this needs be looked at, and I was wondering if others are having this issue or is it my site alone? I am using VB 5.1.5. I am nervous about posting a link to my site here, all I need is for someone to to do this or keep doing it. My site would be down until this is fixed.

Thanks,
Shim

Replicant 03-12-2015 10:18 PM

Post the source from your post that is breaking the page here so we can see what you are doing.

shimei 03-12-2015 10:21 PM

I was copying this page to my forum section where I track the mods I have done to the site. I performed this mod successfully then created a thread and posted this page as a record of my changes. That's when I discovered I could wreck the site through entering any of this code into the browser/thread/post.

https://vborg.vbsupport.ru/showthread.php?t=309785

Wayne Luke 03-12-2015 10:31 PM

I tried to recreate this issue on a fresh installation of vBulletin 5.1.5 with no modifications. Using the [html] tags I get this result:

https://vborg.vbsupport.ru/external/2015/03/25.png

Using no BBCODE, I do get issues so that will need to be checked and tested more but it doesn't break the entire site. Here is what is does if no BBCode is used:

https://vborg.vbsupport.ru/external/2015/03/26.png

In both occurrences, the Can Use HTML permission is off globally for Administrators.

Though if you've made other changes to the templates and the above code is compounded on errors that browsers could work around, then this could cause more issues.

ForceHSS 03-12-2015 10:41 PM

As HTML seems to work for Wayne then it must be something you installed like a custom plugin or an edit to a template revert any templates and disable all plugins then test

shimei 03-12-2015 11:05 PM

Quote:

Originally Posted by ForceHSS (Post 2540311)
As HTML seems to work for Wayne then it must be something you installed like a custom plugin or an edit to a template revert any templates and disable all plugins then test

Hello ForceHSS,

Thank you for taking the time to respond. I noticed Wayne said:

Quote:

Using no BBCODE, I do get issues so that will need to be checked and tested more but it doesn't break the entire site. Here is what is does if no BBCode is used:
Later tonight I'll delete that mod and see if the issue is less than breaking the website. Perhaps they are related, that is having done the mod and then posting similar coding in a thread?

Thank you and I'll post the results.

Shim

ForceHSS 03-12-2015 11:23 PM

If you are going to remove the xml of a custom plugin also remove the files as well

Lynne 03-13-2015 01:18 AM

As Wayne said, I had no issues posting using the html code tag. If you are, then something else is amiss.


All times are GMT. The time now is 04:02 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01701 seconds
  • Memory Usage 1,764KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_code_printable
  • (1)bbcode_html_printable
  • (7)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (18)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete