vb.org Archive - Another 4.2.2 upgrade test

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB4 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=251)

- - Another 4.2.2 upgrade test (https://vborg.vbsupport.ru/showthread.php?t=303169)

Disco_Dave

10-09-2013 01:10 PM

Another 4.2.2 upgrade test

Hi Guys

Getting this error after the upgrade:

PHP Code:


		
			
Warning: Assigning the return value of new by reference is deprecated in ..../christeris/classifieds/includes/functions.php on line 1166

All plugins are disabled via config.

Dave

ozzy47

10-09-2013 01:19 PM

That is a issue with Christos classifieds mod.

Disco_Dave

10-09-2013 01:22 PM

Yeah I know I've asked on his site also. Would it just be best to delete his files, to see if I can get in?

I've removed all parts of his mod.....but still getting this error:

PHP Code:


		
			
Warning: require_once(./christeris/classifieds/includes/functions.php) [function.require-once]: failed to open stream: No such file or directory in ..../includes/block/html.php(95) : eval()'d code on line 3

Fatal error: require_once() [function.require]: Failed opening required './christeris/classifieds/includes/functions.php' (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home3/nirc/public_html/disco/includes/block/html.php(95) : eval()'d code on line 3

ozzy47

10-09-2013 02:20 PM

That means it can't find that file since you removed it.

Disco_Dave

10-09-2013 02:27 PM

I've got in, but it's still throwing up this error, know and again. For the most part everything seems to be working. I don't think I'll be in a rush to move to this version.

Thanks Ozzy!

da_judge

10-09-2013 09:35 PM

4.2.2 has broken all over the world, great if you have 0 plugins... advice.. dont use it

here is example

http://www.dragonbyte-tech.com/produ...st-thanks-like

pityocamptes

10-09-2013 09:45 PM

I'm thinking the same thing. Not going to upgrade...

CarlitoBrigante

10-09-2013 09:49 PM

These warnings were likely there also before the vBulletin upgrade, but there is a 4.2.2 change in the error handler which will force php to display errors even if you have set them to off in your php.ini.

--------------- Added [DATE]1381359117[/DATE] at [TIME]1381359117[/TIME] ---------------

The fix is listed at vbulletin.com: http://www.vbulletin.com/forum/forum...-been-released

da_judge

10-09-2013 10:39 PM

So instead of fixiing errors... just hide them lool...

in settings lol

This option should only be used if you are running php 5.3.0 or greater and your plugin code is generating deprecated or strict errors. Where possible, you should fix the plugin code rather than rely on this option.

thats really bad... you should fix the plugin code rather than rely on this option.

Thats what head developer suggested hahahha mental

php.ini btw some run Nginx ;) stays broken... lucky i found a fix for nginx

Paul M

10-09-2013 11:04 PM

Quote:

Originally Posted by da_judge (Post 2451477)

thats really bad... you should fix the plugin code rather than rely on this option.

Thats what head developer suggested hahahha mental

Would you like to explain (a) why "its really bad", and (b) what is "mental" ?

da_judge

10-09-2013 11:10 PM

You suggested hide errors... how is that good.. just asking

http://www.vbulletin.com/forum/forum...-been-released

its bad to hide errors... not saying your fault... and as im from London... its what we say.. its mental... nothing personal.. but Nginx craps out big time with update ;)

No offence intended Paul

Paul M

10-09-2013 11:13 PM

I suggested "Where possible, you should fix the plugin code". ;)

Thats not always practical or possible, so hiding them is the only alternative.

vBulletin has been hiding them for a long while due to the fact the old error handler (which dates from php 4 days) didnt do anything with them. All 4.2.2 does is expose them.

da_judge

10-09-2013 11:17 PM

question is then m8... why hide errors.. it be better to show rather than hide

and your fixes fails on nginx.. plugins which i know are not yor fault.....

Paul M

10-09-2013 11:28 PM

Quote:

Originally Posted by da_judge (Post 2451504)

question is then m8... why hide errors.. it be better to show rather than hide

You are free to show them on your forum if you wish, most admins however would prefer not to display them.

On a production site, display_errors should be turned off at source (php.ini).

As noted in the standard php.ini file

Code:

;;;;;;;;;;;;;;;;;;;

; Quick Reference ;

;;;;;;;;;;;;;;;;;;;

; The following are all the settings which are different in either the production

; or development versions of the INIs with respect to PHP's default behavior.

; Please see the actual settings later in the document for more details as to why

; we recommend these changes in PHP's behavior.



; allow_call_time_pass_reference

;   Default Value: On

;   Development Value: Off

;   Production Value: Off



; display_errors

;   Default Value: On

;   Development Value: On

;   Production Value: Off

CarlitoBrigante

10-10-2013 12:01 AM

Paul, there is no reason to be so dismissive. I have a problem on many servers with display_errors set to off and errors still being shown by vBulletin 4.2.2 through its new error handler. Why this is happening, I did not have time to look into, as I have so many forums to upgrade I do not have time to submit a bug report. I am not paid to look into vBulletin's core code, but I might take some time to do so.

For the others: those warnings, as I said in my previous post, should not be ignored. The reality is that many plugins you could have downloaded also from vBulletin.org will cause those warnings in many vBulletin installations - just, up to this moment, you might have not noticed them. This is because many plugins are using old code or are coded following old PHP standards.

When you set display_errors to off, you should always have log_errors set to on and check routinely for errors popping up there, including warnings, and fix plugins when possible.

On production websites, you should basically NEVER show this kind of error information to the public, as it might expose vulnerabilities or other information about your server you do not want to disclose (like path structure).

Sorry for the fast post, I did not have time to re-read it for spelling errors as I have still 4 forums piled up for an upgrade today.

meaters

10-10-2013 12:23 AM

Thanks for the info Carlito.

Broken templates are also a big problem after this upgrade.

da_judge

10-10-2013 06:28 PM

Yer i understand that m8.. but im running Nginx.. php.ini doesn't work the same with nginx :)

i managed to fix anyway

cheers

--------------- Added [DATE]1381433711[/DATE] at [TIME]1381433711[/TIME] ---------------

Quote:

Originally Posted by meaters (Post 2451538)

Thanks for the info Carlito.

Broken templates are also a big problem after this upgrade.

you tried rebuilding templates in maintenance

Admincp > Maintenance > Rebuild Styles

:)

All times are GMT. The time now is 05:02 AM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01329 seconds Memory Usage 1,764KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_code_printable (2)bbcode_php_printable (3)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (17)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: