vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Private Messages Enhancements - Private Message Attachments (https://vborg.vbsupport.ru/showthread.php?t=284138)

Andreas 06-07-2012 10:00 PM

Private Message Attachments
 
1 Attachment(s)
This Add-on allows you to use attachments in private messages.

Changelog
1.0.0 Beta 2
  • Added missing table prefix
  • Removed hardcoded contenttypeid
  • Improved performance

ibrahimkoky 06-08-2012 06:35 AM

thanks :)
tagged for later

Schoelle 06-08-2012 07:19 AM

Please all vote for this JIRA entry:

Cant use attachements in private messages
http://tracker.vbulletin.com/browse/VBIV-5750

As i appreciate your efforts Andreas, this should be a core function and not an addon!

Hornstar 06-08-2012 08:44 AM

So many people have requested this. Andreas you are awesome!

-.- You must 'Like' someone else's post before liking any more by Andreas.

Robru 06-08-2012 08:59 AM

Finally! Andreas, you're a hero! :)

Taurus1 06-08-2012 12:17 PM

OH MAN! This is the best news ever! Thank you so much!!

Andreas 06-08-2012 01:33 PM

Quote:

Originally Posted by Schoelle (Post 2337665)
Please all vote for this JIRA entry:

Cant use attachements in private messages
http://tracker.vbulletin.com/browse/VBIV-5750

It should indeed be a core feature and in fact I coded this already over one year ago but didn't release it as PM attachments were planned to be available "in a future version".

But as this hasn't happend so far I just released it those those who tnat to have that feature don't have to wait further.

puertoblack2003 06-08-2012 02:11 PM

Quote:

Originally Posted by Andreas (Post 2337733)
It should indeed be a core feature and in fact I coded this already over one year ago but didn't release it as PM attachments were planned to be available "in a future version".

But as this hasn't happend so far I just released it those those who tnat to have that feature don't have to wait further.

thank you sir this is needed in deed... :up:

qpurser 06-08-2012 02:15 PM

Installed and works great.
THX so much

Mark.B 06-08-2012 02:18 PM

Andreas what a total star you are, as always. Will test and install later.

Lionel 06-08-2012 03:03 PM

hi,

When I try to open a pm I get this

PHP Code:

Warningunserialize() expects parameter 1 to be string, array given in [path]/packages/pmattachments/postbit/pm.php on line 39 

Warning: unserialize() expects parameter 1 to be string, array given in [path]/packages/pmattachments/postbit/pm.php on line 39

Gemma 06-08-2012 04:03 PM

As others have said, this should be part of the core product. Thanks for releasing :)

KatieG 06-08-2012 05:01 PM

Code:

Warning: unserialize() expects parameter 1 to be string, array given in [path]/packages/pmattachments/postbit/pm.php on line 39

Shadow 06-08-2012 08:20 PM

Very nice mod.
Tagged for later use!

hiker 06-09-2012 05:14 AM

Bummer, I was hoping this would work with 4.1.12

blue6995 06-09-2012 05:51 AM

Ummm, when I try and send PM with an attachment I get the following error message:

Database error in vBulletin 4.2.0:

Invalid SQL:

UPDATE vb3_pm
SET attach = (SELECT COUNT(*) FROM vb3_attachment WHERE contentid = pm.pmid AND attachment.contenttypeid = 24);

MySQL Error : Unknown column 'pm.pmid' in 'where clause'
Error Number : 1054
Request Date : Saturday, June 9th 2012 @ 01:48:56 AM
Error Date : Saturday, June 9th 2012 @ 01:48:56 AM
Script : http://rwf-forum.co.uk/vBulletin/pri...tpm&pmid=70117
Referrer : http://rwf-forum.co.uk/vBulletin/pri...tpm&pmid=70117
IP Address : xx.xx.xx.xx
Username :
Classname : vB_Database
MySQL Version : 5.1.63-cll

ceho 06-09-2012 02:12 PM

When I try to send inline attachments I get this error message:

Code:

Database error in vBulletin 4.2.0:

Invalid SQL:

            UPDATE vb_pm
            SET attach = (SELECT COUNT(*) FROM vb_attachment WHERE contentid = pm.pmid AND attachment.contenttypeid = 24);

MySQL Error  : Unknown column 'pm.pmid' in 'where clause'
Error Number  : 1054
Request Date  : Saturday, June 9th 2012 @ 05:05:26 PM
Error Date    : Saturday, June 9th 2012 @ 05:05:26 PM
Script        : http://www.cureconnections.com/testforum2/private.php?do=insertpm&pmid=
Referrer      : http://www.cureconnections.com/testforum2/private.php?do=newpm
IP Address    : XXX.XXX.XX.XXX
Username      : ceho
Classname    : vB_Database_MySQLi
MySQL Version : 5.0.77

Received pm's can be opened without issues, however there is no attachment preview and if you click on the attachment an error message appears saying an invalid file has been specified.

Just thought you should know :).

Andreas 06-09-2012 02:19 PM

Just a friendly note:
As stated in the Add-on Information, this work is unsupported - all support requets will therefore be ignored.

Thank you very much for your unterstanding.

ceho 06-09-2012 02:23 PM

That's why I don't ask for help but let you know what happens. In case you might need it :).

Taurus1 06-10-2012 02:22 AM

Getting this when trying to upgrade to beta 2:

Fatal error: Using $this when not in object context in /home/thebull/public_html/forums/includes/adminfunctions_plugin.php(1174) : eval()'d code on line 3

Taurus1 06-10-2012 02:34 AM

I uninstalled it completely, and then when trying to install beta 1 again, I get this:

Database error in vBulletin 4.2.0:

Invalid SQL:

INSERT INTO vbpackage
(productid, class)
VALUES
('pmattachments', 'PMAttachments');

MySQL Error : Duplicate entry 'PMAttachments' for key 'class'
Error Number : 1062
Request Date : Sunday, June 10th 2012 @ 05:31:57 AM
Error Date : Sunday, June 10th 2012 @ 05:31:58 AM
Script :
Referrer :
IP Address : ++++++++++
Username : ++++++++
Classname : vB_Database
MySQL Version : 5.1.63-cll

I know you said that there will be no support, but I am really stuck now. Thanks.

Robru 06-10-2012 03:03 AM

Thanks for your update ;)

kevius 06-10-2012 05:30 AM

i'm waiting about the final version because i NEED this hack !! thanks a lot !

junaid 06-10-2012 06:06 AM

I get same issue

Database error in vBulletin 4.2.0:

Invalid SQL:

INSERT INTO vbpackage
(productid, class)
VALUES
('pmattachments', 'PMAttachments');

MySQL Error : Duplicate entry 'PMAttachments' for key 'class'
Error Number : 1062
Request Date : Sunday, June 10th 2012 @ 05:31:57 AM
Error Date : Sunday, June 10th 2012 @ 05:31:58 AM
Script :
Referrer :
IP Address : ++++++++++
Username : ++++++++
Classname : vB_Database
MySQL Version : 5.5.24-cll

Andreas 06-10-2012 08:25 AM

Quote:

Originally Posted by Taurus1 (Post 2338295)
I uninstalled it completely, and then when trying to install beta 1 again, I get this:

That was a bad idea, your database is now in an inconsistent state.
-> Reload the backup you made before uninstalling Beta 1.

Taurus1 06-10-2012 09:09 AM

Sorry. You mean I must completely take my entire forum to the backup?

I don't understand though. I followed your instructions on how to uninstall. Why must I now go back to a backup?

Andreas 06-10-2012 10:31 AM

Quote:

Originally Posted by Taurus1 (Post 2338354)
Sorry. You mean I must completely take my entire forum to the backup?

That would be the easiest way to get the DB to a consistent state again, yes.
Another option would be to manually fix the DB (by removing the package, contenttype and all PM attachments before installing Beta 2).

Quote:

I don't understand though. I followed your instructions on how to uninstall. Why must I now go back to a backup?
As stated in the Add-on information this is unsupported Beta Software, it does contain bugs - like the one in the installation code you discovered :)
Bugs that are being discovered will be fixed, but I do expect beta testers to deal with issues caused by bugs themselves.

junaid 06-10-2012 11:22 AM

to fix which database table have delete ?

Taurus1 06-10-2012 12:38 PM

Yeah well, making a product available to the public which can completely ruin their complete forum is not very professional. And not even having the decency to offer help when begged for help! (I even offered to pay!)

Shadow 06-10-2012 01:38 PM

Quote:

Originally Posted by Taurus1 (Post 2338423)
Yeah well, making a product available to the public which can completely ruin their complete forum is not very professional. And not even having the decency to offer help when begged for help! (I even offered to pay!)

He has a point and so do you. Beta software shouldn't be installed on a live site unless you think it's definitely flawless. And even so, backups are essential. It was most likely put out here for others to help find bugs and such, thus improving the product as a whole.

I recommend next time, when you try beta software, run it on a test site first.

And also, the developer has stated quite a few times that this product isn't supported and he will ignore support requests.

Taurus1 06-10-2012 01:44 PM

I ran it on my test site first. No problems. How was I to know that following his instructions on uninstalling would cause this?

Andreas 06-10-2012 03:11 PM

Quote:

I ran it on my test site first. No problems.
Did you test that uninstalling Beta 1 (and afterwards installing Beta 2) on a test installation works without problems?

Anyway, manually fixing the DB is quite a bit complicated - you can look at the installation/uninstallation code (which has been updated to fix the bugs you came across) to get an idea what needs to be done.

kevius 06-12-2012 07:50 AM

Any idear about the final version date ?

Altari 06-12-2012 09:45 AM

Not working for me, errors during the installation :
Database error in vBulletin 4.2.0:

Code:

Invalid SQL:

      UPDATE vb_pm AS pm
      SET attach = (SELECT COUNT(*) FROM vb_attachment WHERE contentid = pm.pmid AND attachment.contenttypeid = );

MySQL Error  : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 2
Error Number  : 1064

Moroever, after a lot of try, i can see
Code:

[Tue Jun 12 12:29:32 2012] [warn] [client XXX] mod_fcgid: stderr: PHP Warning:  Invalid argument supplied for foreach() in /var/www/packages/navmanenhancements/admin.php on line 43, referer: http://website/admincp/plugin.php?do=productadd
in my apache error log. Don't know what your other addon is doing here...


Thank you Andreas for this mod, would be great.

Andreas 06-14-2012 04:34 AM

Quote:

Originally Posted by kevius (Post 2338904)
Any idear about the final version date ?

It's ready when it's ready, eg. when there are no more bugs being reported.

@Altari
Thanks for this bug report, it will be fixed in Beta 3.

betterthanyours 06-16-2012 02:11 PM

Another one

Code:

Database error in vBulletin 4.1.12:

Invalid SQL:

        INSERT INTO package
        (productid, class)
        VALUES
        ('pmattachments', 'PMAttachments');

MySQL Error  : Duplicate entry 'PMAttachments' for key 'class'
Error Number  : 1062
Request Date  : Saturday, June 16th 2012 @ 11:10:43 AM
Error Date    : Saturday, June 16th 2012 @ 11:10:43 AM
Script        : http://www.unrealkillers.com/admincp/plugin.php?do=productimport
Referrer      : http://www.unrealkillers.com/admincp/plugin.php?do=productadd
IP Address    : 86.19.247.18
Username      : $carface
Classname    : vB_Database
MySQL Version : 5.5.24-cll


Syxguns 06-25-2012 06:18 AM

I am awaiting this mod! I've got it tagged. Thanks for this Andreas :D

qpurser 06-25-2012 10:50 AM

Andreas,
just wanted to give you some feedback regarding your once again excellent mod.

Running vb 4.2.0 on a test server
Upgraded from your Beta1 to Beta2. (for those reading this I did NOT uninstall Beta1 and then installed Beta2 but did a regular update)

I didn't get any error messages at all
Sending and receiving the attachments worked just fine

On a side note I am using also DBTech "vb optimize" which moves the attachments from the database to a folder as files.
Your plugin works fine with or without this add-on.

horusbird 06-30-2012 06:19 PM

error in installation:

Code:

Database error in vBulletin 4.2.0:

Invalid SQL:

        INSERT INTO package
        (productid, class)
        VALUES
        ('pmattachments', 'PMAttachments');

MySQL Error  : Duplicate entry 'PMAttachments' for key 'class'
Error Number  : 1062
Request Date  : Saturday, June 30th 2012 @ 09:18:19 PM
Error Date    : Saturday, June 30th 2012 @ 09:18:19 PM
Script        : http://www.vesparesources.com/adminc...=productimport
Referrer      : http://www.vesparesources.com/adminc...?do=productadd
IP Address    : 79.13.184.169
Username      : horusbird
Classname    : vB_Database
MySQL Version : 5.1.33-community


betterthanyours 07-03-2012 07:07 PM

Quote:

Originally Posted by betterthanyours (Post 2340063)
Another one

Code:

Database error in vBulletin 4.1.12:

Invalid SQL:

        INSERT INTO package
        (productid, class)
        VALUES
        ('pmattachments', 'PMAttachments');

MySQL Error  : Duplicate entry 'PMAttachments' for key 'class'
Error Number  : 1062
Request Date  : Saturday, June 16th 2012 @ 11:10:43 AM
Error Date    : Saturday, June 16th 2012 @ 11:10:43 AM
Script        : http://www.unrealkillers.com/admincp/plugin.php?do=productimport
Referrer      : http://www.unrealkillers.com/admincp/plugin.php?do=productadd
IP Address    : 86.19.247.18
Username      : $carface
Classname    : vB_Database
MySQL Version : 5.5.24-cll


Quote:

Originally Posted by horusbird (Post 2344109)
error in installation:

Code:

Database error in vBulletin 4.2.0:

Invalid SQL:

        INSERT INTO package
        (productid, class)
        VALUES
        ('pmattachments', 'PMAttachments');

MySQL Error  : Duplicate entry 'PMAttachments' for key 'class'
Error Number  : 1062
Request Date  : Saturday, June 30th 2012 @ 09:18:19 PM
Error Date    : Saturday, June 30th 2012 @ 09:18:19 PM
Script        : http://www.vesparesources.com/adminc...=productimport
Referrer      : http://www.vesparesources.com/adminc...?do=productadd
IP Address    : 79.13.184.169
Username      : horusbird
Classname    : vB_Database
MySQL Version : 5.1.33-community


Any news on this error?


All times are GMT. The time now is 02:07 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01347 seconds
  • Memory Usage 1,840KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (8)bbcode_code_printable
  • (1)bbcode_php_printable
  • (10)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (2)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete