Thread Passwords (Updated to VB4 by BOP5)
 

Updated by BirdOPrey5

This is a quick update of the vBulletin 3.6 mod by netwind: Thread Passwords (VB 3.6)

It is marked Re-Usable Code.

NOTE: Confirmed bug affecting all attachments. See post #20.

By request I have updated this to work on the latest vBulletin, VB 4.1.12. It should work on all 4.x versions.

There are NO new features, it is a simple update so it works with 4.x

I will not be providing official support for this mod- truth be told I'm not sure how it works, only that it does in my quick tests.

This is the original description:

Please "Mark as Installed" if you use it. :)

Reserved.

Okay, Is there an On and Off Switch? I am having trouble finding it. LOL

Settings? as far as settings I am guessing no...


Edit: Tagged. :)

No settings, just install the mod and it's enabled. Once you make the template edits it will be ready to go.

@BirdOPrey5:
Thank you very much, I will install this mod as soon as possible

When someone enters a password (right or wrong) I'm getting a Security Token error. Any ideas?

Are cookies enabled? Cookies must be enabled on the browser for the mod to work.

If they are can you give me a link to a password tread? I will see if I can see anything obvious. (Assuming it is guest accessible).

Cookies are enabled, and I've had several users attempt it.

In setting up a post for you I did narrow down the problem. Unregistered users can access the thread after entering the password, however if a registered user tries that's when the security token error pops up.

I do confirm the bug with non-logged-in users. Unfortunately still trying to get a new laptop setup so I don't have access to any of my mod source files right now. Will look into it in a few days when I'm back online.

EDIT-

You could try editing the threadpassword.php file.

Change this line near the top:

From:
to:

Whew! Okay. Thanks! I'm happy its not just me. I appreciate your helping to try and resolve the issue.

You're welcome. I made an edit to the post above with something you can try if you feel like manually editing a file- otherwise wait until I get a chance and I will try it myself.

That fixed it! Is it safe to have the CSRF Protection off though?

For a mod like this I don't see a problem. When I get my system back I'll go through the code thoroughly and see why it isn't working to begin with. It's not like anyone can post to the forum via this script- there would be no benefit sending a thread password from an outside domain- nothing to be gained.

Updated to 0.91- fixes the security token error and keeps cross-site scripting protection enabled.

You must re-upload all files and re-import the product xml file.

Installed
But they only thing is it shows a preview of what is in the Thread on the CMS page and the sidblock on New Forum Posts

Also on the mouse hover over the Thread title.

Yeah, I can imagine that would probably happen. Keep sensitive info out of the preview area. ;)

Great module! One question: is there a way to add the password and Thread Master fields on thread creation, instead of having to post the thread, then go back and edit it?

Probably and I encourage people to try adding this feature. It is "Re-usable code" so anyone can make additions or changes to it.

Thanks, I'll give it a try in a bit. Unfortunately, I've run into a more significant problem. With the module enabled, all attachments on my entire forum break. They appear to upload properly, but they do not display at all. No thumbnail shows, all that is visible is the mouseover text with a link. Clicking the link opens the window where the attachment image is usually shown, but it never loads and eventually returns an error. I have tested the module with and without the template edit, and the error is there even without the template edit, so it appears to be something within the module files themselves. Do you have any idea which section could be causing the conflict?

Confirmed.

Immediate work-around is to disable the "thread password" plugin on the attachment_display hook.

Disabling this will allow users who do not have the password to the thread to see attachments in that thread if someone gave them the URL of the attachment- this may or may not be a problem for you.

I don't see an immediate long-term solution, I will try to work on it when I get a chance.

Excellent, that did indeed fix the problem. I feel a bit silly for not checking the plugin list, that one was rather obvious once I saw it. :P

That feature really isn't much of an issue for how I plan on using the system, so I'm perfectly happy to run it without it. If it can be fixed later, that's great, but if not it's still a great module without it.

I had to take this out.
Reason being, that with this installed it made all posts with images, even Threads without having a password, showing as 'broken' images (you know the images which show a little broken icon instead of the picture).

As soon as I took this modification out the images within posts were showing fine again.

Update to my post
I just read the above 3 posts so I see you know about it.
I will leave it not installed for the time being though.

I have installed it but i can't find where i can set the password for thread? What do i need rot do?
I cand find the code in template show thread.
What to do.

if you can't find this code in your SHOWTHREAD template:

You probably have a custom style- you will need to look for code like it...

earch for "show_printable_version"

Question, what usergroups can access the password threads without having to give the password... Admins of course, but, what about mods and supermods?... Is there a way to edit this?...

Thank you...

By the way, the mod has been very useful =P...

Admins, super-mods, and mods of the forum the thread is posted in should have access.

I don't use this mod and have uninstalled it so I don't have any more info.

I just install it on my test forum (4.2.1).
I uploaded the file, imported the xml and change the template but when I click on
Setup thread password appear this message:
Any idea? Thanks in advance!

Mark as Installed. Finally someone did this!

Thanks for this MOD.

Great mod, thanks!

Is it possible that every user, including super-mods etc., has to enter the password? This would be great!

Thank you.

i like the idea of this....one other basic thing you would sort of think would already be there but isnt....didnt work for us on 4.2.5 tho....installed ok, template edit no problem...but when clicking to setup the pw its this mess


that make sense to anyone? that attachment workaround worked too, thought it was home free till that last bit..

thanks

It looks like you uploaded a PHP file to your site in binary mode which didn't preserve the line endings. PHP (as well as HTML, TXT and other text based files) need to be uploaded in ASCII mode by your FTP client. By default Filezilla will usually do this for you but if for some reason something went wrong or you're using a different app you may need to set it manually,

Images would need to upload in binary or they break, so you can't always stay in ASCII mode.

hmm i havent had any issues with that before...i have it set to auto in filezilla...

you think something in this product is making it transfer the incorrect way?

i guess i will compare the php files just sounds like an odd issue i never saw before, got me curious some..

thank you

i tried again just now, with a default vb4.2.5 install...the domain was setup with php 7.1 but the first part of the result was similar..

that call to undefined function at the end help at all?

the rest of the errors follow..

i dont know really how to even try troubleshooting farther....i know its marked unsupported but could be a good thing to see working...

thanks joe

pity i could really do with this right now