vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   Miscellaneous Hacks - Who Quoted Me (https://vborg.vbsupport.ru/showthread.php?t=258001)

renlok 01-28-2011 10:00 PM

Who Quoted Me
 
1 Attachment(s)
In the user control panel, users can now see a list of the last few people who have quoted them.
This is a great way to encourage users to interact with each other as they can easily keep track of conversations within threads.


If you use this i would really appreciate any small donation

EDIT:
Looks like there a few bugs in this I dont have a computer at the moment but Freshfoot has made an updated release with some new features: https://vborg.vbsupport.ru/showpost....1&postcount=30

dartho 01-29-2011 11:21 AM

Found a small bug. You need to edit the "Load Quotes" plugin on the usercp_start hook and change $vbulletin->options['wqmmax'] to $vbulletin->options['wqm_max'] otherwise you get MySQL errors when trying to enter usercp.

Good work :up:

[Edit]You should probably also use the $stylevar[imgdir_button] when loading the collapse button rather than a hard coded path - I think there is more to it than just that, but that's what I needed to change to use my custom buttons.

sulasno 01-29-2011 11:44 AM

tagged and thanks

@dartho; please explain $stylevar[imgdir_button] ; thanks

Wonksta 01-29-2011 01:43 PM

Quote:

Originally Posted by dartho (Post 2156028)
Found a small bug. You need to edit the "Load Quotes" plugin on the usercp_start hook and change $vbulletin->options['wqmmax'] to $vbulletin->options['wqm_max'] otherwise you get MySQL errors when trying to enter usercp.

Good work :up:

[Edit]You should probably also use the $stylevar[imgdir_button] when loading the collapse button rather than a hard coded path - I think there is more to it than just that, but that's what I needed to change to use my custom buttons.

Will download and Install once this coders recommendations are implemented. Can't wait!

Alfa1 01-29-2011 03:39 PM

Please add quote notifications to the notification drop down:
Quote:

4 of your posts have been quoted

dartho 01-29-2011 09:24 PM

Quote:

Originally Posted by sulasno (Post 2156032)
tagged and thanks

@dartho; please explain $stylevar[imgdir_button] ; thanks

This would only be an issue if you have custom styles (buttons in particular) in a custom path. If so, edit the template usercp_who_quoted_me and change src="images/buttons/collapse_tcat.gif" to src="$stylevar[imgdir_button]/collapse_tcat.gif"

Alpha - that is already implemented, although it current only has "Quotes n" - you'd have to edit the wqm_quotes phrase and change to something like "Number of posts quoted" if you wished to be more verbose ...

Wonksta 01-29-2011 10:23 PM

What kind of stress does this put on the server fetching quotes?

Alfa1 01-29-2011 11:40 PM

Im getting a DB error:
Code:

Database error in vBulletin 3.8.6:

Invalid SQL:
SELECT user.username, quote.*, post.threadid, thread.title
    FROM vb6_quotedatanew As quote
    LEFT JOIN vb6_post AS post ON(quote.postid = post.postid)
    LEFT JOIN vb6_thread AS thread ON(post.threadid = thread.threadid)
    LEFT JOIN vb6_user AS user ON(user.userid = quote.quoter)
    WHERE quote.quoted = '1' ORDER BY quote.dateline DESC LIMIT;

MySQL Error  : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 6
Error Number  : 1064
Request Date  : Sunday, January 30th 2011 @ 02:36:38 AM
Error Date    : Sunday, January 30th 2011 @ 02:36:38 AM
Script        : http://www.my-forum.com/forum/usercp.php
Referrer      : https://www.my-forum.com/forum/index.php
Username      : Alfa1
Classname    : vB_Database
MySQL Version : 5.0.90-log

Are table prefixes considered in this modification?

dartho 01-29-2011 11:49 PM

Check my post above:

Quote:

Found a small bug. You need to edit the "Load Quotes" plugin on the usercp_start hook and change $vbulletin->options['wqmmax'] to $vbulletin->options['wqm_max'] otherwise you get MySQL errors

Alfa1 01-30-2011 12:12 AM

Duh. Sorry bout that. That solves the DB error.

Im not getting any notifications of new quotes. Nor is anything listed under 'Who Quoted Me' in usercp

Please mind I have this installed: Display Reputation Comments Given

My site is rather busy, so I imagine that loading the quote data might be extensive for 85.000 members. 7.500 active members.

Wonksta 01-30-2011 12:35 AM

How hard would it be to implement this for only certain usergroups eg, paid members?

FreshFroot 01-30-2011 01:17 AM

Was waiting for this.. but seems like it has a lot of bugs right now.

FreshFroot 01-30-2011 01:19 AM

Quote:

Originally Posted by Wonksta (Post 2156263)
How hard would it be to implement this for only certain usergroups eg, paid members?

Not too hard, I might work on it myself. Set it so VIP groups can use it etc.. or X group(s)

Wonksta 01-30-2011 02:24 AM

Quote:

Originally Posted by FreshFroot (Post 2156280)
Not too hard, I might work on it myself. Set it so VIP groups can use it etc.. or X group(s)

Mate if you would be kind enough to forward me the code you placed to restrict groups I would greatly appreciate it.

The Mod appears to be working very well, notifications work nicely. However very important people follow darthos posts about amending the code slightly.

FreshFroot 01-30-2011 03:58 AM

Well I haven't tried it out fully. But, I will play with it this weekend and see how it goes and let you know.

Wonksta 01-30-2011 04:49 AM

Hmm would

PHP Code:

<if condition="is_member_of($bbuserinfo, array(5,6,7))"

Work efficiently if so where should that go in the XML?

FreshFroot 01-30-2011 05:02 AM

Well what I am thinking of doing is adding a section in acp, so you can select which usergroups can use this hack.

Wonksta 01-30-2011 05:10 AM

Quote:

Originally Posted by FreshFroot (Post 2156319)
Well what I am thinking of doing is adding a section in acp, so you can select which usergroups can use this hack.

Ahhh if only I was that good with coding!

I'll wait for you then :)

FreshFroot 01-30-2011 05:17 AM

Quote:

Originally Posted by Wonksta (Post 2156218)
What kind of stress does this put on the server fetching quotes?

From what I can tell it will put just a little bit more stress on the server compared to posting a new reply. Just because it's going to check if the post is quoted and then create a notification.

Wonksta 01-30-2011 05:38 AM

Quote:

Originally Posted by FreshFroot (Post 2156321)
From what I can tell it will put just a little bit more stress on the server compared to posting a new reply. Just because it's going to check if the post is quoted and then create a notification.

OK Should be OK then for only Premium Members I guess! Lookin forward to your usergroup mod now even more ;)

FreshFroot 01-30-2011 05:41 AM

Quote:

Originally Posted by Wonksta (Post 2156324)
OK Should be OK then for only Premium Members I guess! Lookin forward to your usergroup mod now even more ;)

working on it as we speak.. might be done in 30 mins.

I did find a bug, I guess the OP missed a vB4 tag and so when you click on a thread in the usercp.. it leads you to...

showthread.php?t=13#post{vb:raw whoquote.postid}

Going to fix this too ;)

So far I added in the 3 fixes till now.

Wonksta 01-30-2011 05:44 AM

Quote:

Originally Posted by FreshFroot (Post 2156325)
working on it as we speak.. might be done in 30 mins.

I did find a bug, I guess the OP missed a vB4 tag and so when you click on a thread in the usercp.. it leads you to...

showthread.php?t=13#post{vb:raw whoquote.postid}

Going to fix this too ;)

So far I added in the 3 fixes till now.

You are a good man! :D

FreshFroot 01-30-2011 05:54 AM

almost done.. just going to do a few fast tests to see if it works and then i'll let u give it a test run for me too.

The one thing that I do hate is the fact that once you click on the notifications.

I kinda think it might be better if it worked the same way the PM system does? Where if you go into your PM box and if you have 2 PM's, but only read one of them.

the notification will STILL say you have 1 PM and will go away when you read all unread PM's.

So hopefully the same can be done for this mod. Where it highlights which quotes are NEW and the notification goes away when you view all quoted posts?

Anyways thought I'd throw it out there in case people like the idea or not.

Wonksta 01-30-2011 05:56 AM

Quote:

Originally Posted by FreshFroot (Post 2156331)
almost done.. just going to do a few fast tests to see if it works and then i'll let u give it a test run for me too.

The one thing that I do hate is the fact that once you click on the notifications.

I kinda think it might be better if it worked the same way the PM system does? Where if you go into your PM box and if you have 2 PM's, but only read one of them.

the notification will STILL say you have 1 PM and will go away when you read all unread PM's.

So hopefully the same can be done for this mod. Where it highlights which quotes are NEW and the notification goes away when you view all quoted posts?

Anyways thought I'd throw it out there in case people like the idea or not.

That's pretty solid idea mate I also noticed that it doesn't actually take you to the post in which you were quoted in (unless it's just me???) can be difficult if the thread is 6,000 + posts (I have a few of these)

FreshFroot 01-30-2011 06:00 AM

Quote:

Originally Posted by Wonksta (Post 2156333)
That's pretty solid idea mate I also noticed that it doesn't actually take you to the post in which you were quoted in (unless it's just me???) can be difficult if the thread is 6,000 + posts (I have a few of these)

it doesn't take you to the quotes post, because as I decribed above. The coder when porting the mod from vB4 to vB3 left a vB4 code tag, which vB3 doesn't understand. I fixed that so it will lead to the post now.

I think I am done for the most part with the update.

I kinda want to find a way to get the idea I posted going.. or at least getting the unread quote notifications marked with something, so you know which ones you read and check and which ones you haven't.

Wonksta 01-30-2011 06:05 AM

Quote:

Originally Posted by FreshFroot (Post 2156334)
it doesn't take you to the quotes post, because as I decribed above. The coder when porting the mod from vB4 to vB3 left a vB4 code tag, which vB3 doesn't understand. I fixed that so it will lead to the post now.

I think I am done for the most part with the update.

I kinda want to find a way to get the idea I posted going.. or at least getting the unread quote notifications marked with something, so you know which ones you read and check and which ones you haven't.

Quote:

I fixed that so it will lead to the post now.
Sorry my bad! Good work!

Quote:

I kinda want to find a way to get the idea I posted going.. or at least getting the unread quote notifications marked with something, so you know which ones you read and check and which ones you haven't.
Again, that idea is sweet!

Another idea i was thinking was under the Title of the thread an XX amount of character preview of the post that can be admin set in acp

just an idea :P

Wonksta 01-30-2011 06:14 AM

Also just thought of a little scenario where a member may get pissed off, if he she posts something really controversial then goes to bed wakes up and has 50 notifications there needs to be a way to mark the all 'viewed/red' in a single click. :D

FreshFroot 01-30-2011 06:22 AM

Quote:

Originally Posted by Wonksta (Post 2156337)
Also just thought of a little scenario where a member may get pissed off, if he she posts something really controversial then goes to bed wakes up and has 50 notifications there needs to be a way to mark the all 'viewed/red' in a single click. :D

good idea.. I didn't think about that... hmmm

okay well I will work with that part later sometime unless the OP does it.

For now I got it working with usergroups and also made a way to turn the system on and off.

Wonksta 01-30-2011 06:28 AM

Quote:

Originally Posted by FreshFroot (Post 2156339)
good idea.. I didn't think about that... hmmm

okay well I will work with that part later sometime unless the OP does it.

For now I got it working with usergroups and also made a way to turn the system on and off.

Awesome! Great ideas are never rushed!

Let me know when ya ready for me to test it you can PM if you like

FreshFroot 01-30-2011 06:31 AM

1 Attachment(s)
Alright guys here is an updated version for those that don't want to wait.

Thanks to the OP for making a vB3 version.

Quote:

Added a way to turn the quote notifications on or off globally
Able to add usergroup permissions as to who can use the quote notification system.
Fixed the usercp quotes thread tags, which now will point to the quoted post reply

Fixed the image tag to use default code for vB stylevars
Fixed the plugin issue loading quotes

Thanks to dartho for the above two fixes.
EDIT: forgot to add, just upload like you do usually and overwrite.

Also updated it to v1.2.1

If you have problems let me know.

In the mean time I am looking at the ideas I discussed earlier above in other posts.

Wonksta 01-30-2011 06:42 AM

Quote:

Originally Posted by FreshFroot (Post 2156341)
Alright guys here is an updated version for those that don't want to wait.

Thanks to the OP for making a vB3 version.



EDIT: forgot to add, just upload like you do usually and overwrite.

Also updated it to v1.2.1

If you have problems let me know.

In the mean time I am looking at the ideas I discussed earlier above in other posts.

Thanks but doesn't appear to be notifying or showing anything in UserCP like the original op released...

FreshFroot 01-30-2011 06:43 AM

Also another update.

For those that want to have the quick reply button automatically quote without having to click the "quote message in reply" check box.

PHP Code:

In The SHOWTHREAD template

FIND

<label for="qr_quickreply"><input type="checkbox" name="quickreply" value="1" id="qr_quickreply" accesskey="w" tabindex="4" />$vbphrase[quote_message_in_reply]</label>

REPLACE it with

<label for="qr_quickreply"><input type="checkbox" checked="checked" name="quickreply" value="1" id="qr_quickreply" accesskey="w" tabindex="4" />$vbphrase[quote_message_in_reply]</label


FreshFroot 01-30-2011 06:44 AM

Quote:

Originally Posted by Wonksta (Post 2156343)
Thanks but doesn't appear to be notifying or showing anything in UserCP like the original op released...

hmm i tested it now on a live site and it seems to work fine.

Did you go into the settings and enable the mod? vBulletin -> Options -> Who Quoted Me

Make sure it says Yes to enabled.

Wonksta 01-30-2011 06:45 AM

Update: When I set 0 in Usergroup bit it works

So far I have included

Admin
and all my Premium Groups

Wonksta 01-30-2011 06:47 AM

Update 2:

It appears it doesn't work with more then one usergroup

If I set usergroup 6 it works nicely

if i have 6, 10, 11 or 6,10,11

It does not work

Wonksta 01-30-2011 06:50 AM

Update 3:

Issue with it going to the post quoted:

The post I quoted myself in is on page 3 but the URL rendered:

http://www.xxxxx.com/forum/showthrea...230#post195348

Which just loads the first page of the thread :( and does not go to the post

FreshFroot 01-30-2011 06:54 AM

I figured out the usergroup problem.. small mistake..

as for the 2nd part.. I will check that, I didn't recall having issues but ill check.

Wonksta 01-30-2011 06:55 AM

Quote:

Originally Posted by FreshFroot (Post 2156349)
I figured out the usergroup problem.. small mistake..

as for the 2nd part.. I will check that, I didn't recall having issues but ill check.

You the MAN!!!!!!!!!!!!

FreshFroot 01-30-2011 07:45 AM

Okay try again here: https://vborg.vbsupport.ru/showpost....1&postcount=30

I fixed the usergroup problem.

As for the 2nd one I couldn't replicate it.

Wonksta 01-30-2011 07:54 AM

Mate Usergroups are fixed however the other problem still happens. I did figure out what works though:

Instead of:

/forum/showthread.php?t=11230#post195382

Like this:
/forum/showthread.php?p=195382#post195382

OR EVEN:
/forum/showthread.php?p=195382

But I don't have the knowledge I to fix it, the other mod that uses the above method of taking the user to the exact post is the Dragon Byte Advanced User Tagging system that uses the p= thing instead of t= and works nicely


All times are GMT. The time now is 06:28 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02475 seconds
  • Memory Usage 1,849KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (2)bbcode_php_printable
  • (22)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (2)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete