vb.org Archive - BB Code Enhancements - Validate matching quote BBCode tags.

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)

- - BB Code Enhancements - Validate matching quote BBCode tags. (https://vborg.vbsupport.ru/showthread.php?t=213719)

Validate matching quote BBCode tags.

Quotes Validation

I created this modification to help alleviate the need to edit posts that have invalid/mismatched QUOTE tags. For a busy forum, correcting bad QUOTE tags can become a big problem for your moderators.

Messages (new or edited) rejected by this mod will return the member to the post submission form with the phrase: "One or more of [quote] tags are missing or mismatched. All posts are required to have proper matching quotes."

I have been running it on my board for a month or so without problems. It may run on versions older then 3.8, but I have not tested that.

I have created a number of mods for my board, this is the first one I have released!

--RayJ

NOTE: Plugin works on vBulletin version 4

Description
Check new and edited posts for valid/matching open and close [quote] BBCode tags.
*Should* work with any number of nested or included quote tags.

Details
1 Product XML with 3 Plugins, 2 Phrases, 5 Settings, and 0 Queries
1 File/Class
No template modifications.

Files
class_verifyquotes.php
install.txt
license.txt
license-vqbc_rayj2009.txt
v1.3 = product-vqbc_rayj2009_1-3.xml
v1.2 = product-vqbc_rayj2009_1-2.xml
v1.1 = product-vqbc_rayj2009_1-1.xml
v1.0 = product-vqbc_rayj2009.xml

Upgrading
v1.0-v1.1 :
Upload class_verifyquotes.php file to the /includes/ directory
import product-vqbc_rayj2009_v1-1.xml (Allow Overwrite)
v1.(0/1)-v1.2 :
Upload class_verifyquotes.php file to the /includes/ directory
import product-vqbc_rayj2009_v1-2.xml (Allow Overwrite)
v1.(0/1/2)-v1.3 :
Upload class_verifyquotes.php file to the /includes/ directory
import product-vqbc_rayj2009_v1-3.xml (Allow Overwrite)

History
1.0

Initial Version

1.1
Added plugin: newpost_preview
Added setting: Auto Preview Mode.

If active, the system will automatically put you in preview mode, and display the error message in the post area, when QUOTE mismatches are found.

Added phrase: To display CSS around "in post" error message.
Bug Fix: versions v1.0 and v1.1 (Note: fix already applied to all versions)

Memory leak causes download dialog for all browsers (for large posts). Download quotes_validation_bugfix.zip (contains: class_verifyquotes.php) and upload it. Fixes all previously installed versions.

1.2
Added Option: Style (CSS) for error message
Added Option: Bad Quotes Error Message

This will let you edit the Error Message and CSS that controls the output without having to edit the phrase directly. I left the original phrase code in place so that it will not get wiped out when you upgrade. You will have to search for the phrase (vqbc_bad_quotes_error) and copy it to the new setting.

Changed the phrase that displays the "in post" error message to work with the new options.
1.3
Bug Fix: Removed recursion and complex regular expressions. These were causing issues with large posts.
Added Option: Ignored Tags (allows you to add tags to be ignored during validation, note: noparse is always ignored)

Notes
PHP 5.0+ required.

If you are still using PHP 4 (you should upgrade). Or you can edit the class_verifyquotes.php file and remove all public and private keywords (before each function). Then edit the product-vqbc_rayj2009_v1-1.xml file and remove the PHP 5.0 dependency line.

My first mod release.

Enjoy!

--RayJ

Yeah ! Not bad.

I will test it later. Thank you for this mod. ;)

Great idea! I'm always fixing mismatched quotes. Thanks!

Good idea, I'm tagging this to test it in a few days.

Thanks.

A great idea, many thanks, RayJ!

Great, great, GREAT idea!!!

Thank you so very much.

I get:

Parse error: syntax error, unexpected T_STRING, expecting T_OLD_FUNCTION or T_FUNCTION or T_VAR or '}' in /path/to/forums/includes/class_verifyquotes.php on line 35

When it's active. Any ideas?

Quote:

Originally Posted by Supramania (Post 1811952)

Yes! Are you running PHP version 4?

If so, open the file /includes/class_verifyquotes.php and remove the "public" and "private" before both function keywords.

--RayJ

Yes PHP 4.4.6 (cli)

That fixed it - works great now! :D

Great mod, going to install this one, thank you!

Works great...

I do find on Quick reply it just takes you to a preview of the post if there's a mismatch, I think it could do with an error message here like on the full reply so people know what's wrong.

Quote:

Originally Posted by Mark.B (Post 1812371)

I tried to do this. But after several attempts, I could not get an acceptable system in place. The Quick reply is AJAX based and I need to take the time to learn how it works in vB. I may try to get the done at some point.

--RayJ

sounds handy. Thanks :D

Greetings All!

You are most welcome!

A number of users on my forum requested that this modification automatically put you in the Preview mode when it finds mismatched quotes. After a bit of effort, I found a way to make it work.

I decided that some might like the original functionality, so I made this change an option in the AdminCP.

Enjoy!

--RayJ

I had this installed on vBulletin 3.8 and it was great. Does anyone know if it will work with vBulletin 4?

It may. I am not sure. I will do some testing and let you know. If it does not work, I will update it so that it will.

--RayJ

Alrighty then!

I installed it on vB v4.0.8 and it worked as expected.

:D

--RayJ

Looks cool... has the bug-fix been put into version 1.1 yet or we still need to download both?

Thanks :up:

The bug fix has already been applied to both versions. So you only have to download the latest!

And... there is a new version (1.2) that added the ability to change the error message, and the CSS that controls its display, via the options.

--RayJ

Nice update, thanks. :)

If anyone is interested I'm using this CSS to make a rounded border with a slight shadow, light yellow background and dark red text... Easily edited to your needs.

There are 3 properties needed for each rounded border (radius) and shadow... -moz is for firefox browser, -webkit is for chrome browser, and the other is for IE9 and standard web browsers.

Code:

color: darkred; background: lightyellow; border: 2px  inset red; padding: 4px; margin: 2px; -moz-border-radius: 5px;  -webkit-border-radius: 5px; border-radius: 5px;  moz-box-shadow:0 0 2px darkred; -webkit-box-shadow:0 0 2px darkred; box-shadow:0 0 2px darkred;

This is a great modification, but people occasionally will have a problem with it on our site due to the length (number of characters) of the quoted text. The limit within one set of quote tags appears to be 8281. I can add another set of quote tags around a 8281 character quote and add some more text in the outer set.

Are you using the latest version? There was an issue with large posts in the original version.

--RayJ

it is version 1.2 that I have installed.

will be good if mod would have setting for exclude validate quotes inside tags

example: [code] [html] [php] e.t.c

Quote:

Originally Posted by ravenscape (Post 2274492)

it is version 1.2 that I have installed.

I will check that out and see what is causing the problem!

Quote:

Originally Posted by xorex (Post 2274515)

will be good if mod would have setting for exclude validate quotes inside tags

example: [code] [html] [php] e.t.c

I will try to implement that.

--RayJ

Quote:

Originally Posted by ravenscape (Post 2274358)

I have looked over the code and tested various amounts of data. I posted over 16000 characters in QUOTED text, with and without proper QUOTE tags. Everything worked as expected.

Could you do me a favor? Check your forums "Maximum Characters Per Post" setting. That may be what is causing this issue. The setting is in Message Posting and Editing Options.

--RayJ

Quote:

Originally Posted by raywjohnson (Post 2274737)

The max characters setting is at 50,000.

This is the maximum amount that I can post in a single quote.

Quote:

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam tristique posuere elit, vitae iaculis ipsum suscipit adipiscing. Aliquam ultricies tortor at nulla vehicula mollis. Aliquam euismod tristique est, laoreet feugiat nisi ornare ut. Vestibulum sodales magna non erat dictum eget vehicula sapien viverra. Proin eget sem eget mi sodales aliquam a eu nisi. Ut imperdiet pulvinar gravida. Praesent eu placerat ipsum. Nunc cursus, lorem sed tempor sollicitudin, erat odio consequat mauris, sed ornare magna risus nec ante. Vestibulum eget lectus vel felis dignissim volutpat vitae a arcu. Proin orci ante, ultricies at convallis in, fermentum sed justo. Nullam dignissim risus vitae lorem luctus pellentesque. Suspendisse eu nibh id orci rutrum porttitor. Quisque pellentesque purus quis felis dignissim aliquet. Cras dictum pellentesque ipsum eget sollicitudin. Duis scelerisque justo id sapien sollicitudin eu facilisis lectus dapibus. Nunc turpis lorem, hendrerit et auctor nec, fringilla vel mi.

Duis arcu risus, interdum et venenatis vehicula, vehicula nec nibh. In sagittis, nibh non mattis adipiscing, mauris enim mollis elit, eu euismod justo dui sit amet erat. Ut at tellus massa, vitae accumsan orci. Vivamus leo ligula, blandit malesuada cursus nec, aliquam in lectus. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia Curae; Integer ante ligula, lacinia a elementum nec, ultrices eu purus. Phasellus sed velit metus, ac ultrices felis. Nam vehicula sapien in magna porta vulputate quis vel justo. Mauris dignissim imperdiet enim, in placerat felis scelerisque eget. Nullam placerat dignissim fringilla. Nullam massa leo, luctus non adipiscing nec, iaculis vitae eros. Maecenas vitae magna vitae velit tincidunt gravida sit amet sed sem. Fusce pulvinar libero ac lorem congue quis porta sapien gravida. Cras volutpat elementum risus, a imperdiet tellus ullamcorper fringilla. Sed ultrices libero ut sapien tincidunt fringilla.

Aliquam imperdiet augue aliquam lacus lacinia id porttitor nibh dapibus. Vivamus at justo lorem, ac mattis magna. Donec tempor accumsan quam, eget volutpat ante commodo at. Donec lacinia dictum odio. Fusce suscipit gravida lorem, eget feugiat lacus posuere eget. Integer eget felis nisi. Phasellus urna purus, egestas at porttitor nec, ullamcorper pharetra magna. Aenean quis porta turpis. Nulla eget augue et ante placerat viverra. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Donec vel metus sit amet mi vehicula egestas. Mauris dignissim consectetur ultricies. Integer condimentum elementum nisi, nec congue sem bibendum ut. Nunc ac sem non sapien porttitor ultricies.

Vivamus varius facilisis magna id interdum. Morbi facilisis risus in odio ullamcorper sodales. Mauris suscipit ipsum vitae dolor ullamcorper sed tempus risus rhoncus. Cras elementum placerat porta. Donec molestie vehicula egestas. Sed luctus justo quis magna porta non semper nibh dictum. Duis nec nunc magna, ut porta neque. Ut felis nunc, porttitor ut fringilla non, viverra sit amet nunc. Fusce at quam nec nisi semper tristique id ac est. Sed blandit tellus quis lectus feugiat egestas. Suspendisse vitae est vitae tortor volutpat luctus. Nunc bibendum consequat nibh, non adipiscing turpis ultricies ac. Integer elementum arcu nec mauris imperdiet consequat. Pellentesque a quam dolor. Morbi sit amet augue quis mi adipiscing scelerisque.

Maecenas elementum vestibulum vehicula. Nunc nulla eros, gravida vel cursus cursus, porta non magna. Etiam vehicula erat congue eros mollis quis tristique mi tempus. Maecenas at purus hendrerit lorem porttitor ornare id at nisl. Donec placerat justo sed ipsum faucibus iaculis. Proin id diam nec purus suscipit placerat. Pellentesque vitae justo odio, id ullamcorper mi. Donec sed dui sapien, quis gravida velit. Nullam vestibulum semper dolor, ac tincidunt elit consequat eu. Proin pharetra volutpat enim non condimentum. Etiam et fermentum lorem. Proin ornare ligula a ante lacinia tempus.

Morbi bibendum, risus id mattis suscipit, augue libero rutrum mauris, eu pretium dolor lacus non mauris. Vestibulum lobortis erat id diam commodo interdum. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Donec posuere ultricies nisl, eget adipiscing lectus sodales id. Mauris pharetra, quam eu facilisis iaculis, odio magna laoreet magna, non malesuada massa nisi vitae nisl. In hac habitasse platea dictumst. In in purus nulla. Morbi ligula risus, hendrerit sed pretium quis, viverra et nulla. Donec ultrices, arcu eget feugiat rutrum, arcu urna egestas justo, non sollicitudin orci felis at nulla. Suspendisse aliquam est eu turpis ultricies pharetra. Curabitur facilisis convallis orci, nec sodales turpis condimentum vel. Phasellus augue elit, volutpat tincidunt sollicitudin vel, faucibus nec massa.

Nam a nibh viverra nisi venenatis vehicula non eu arcu. Nunc neque neque, blandit tincidunt eleifend sed, luctus nec metus. Aliquam non urna sem. Nulla facilisi. In dui nulla, malesuada at condimentum et, consectetur in urna. Phasellus bibendum, tellus gravida vestibulum volutpat, lorem arcu consectetur lorem, eget accumsan nunc massa in arcu. Quisque eu lacus et sapien malesuada vulputate. Nunc nunc quam, volutpat quis tempor a, eleifend vel erat. Morbi sit amet magna a felis ultricies accumsan. Duis ullamcorper ipsum eget dui rutrum aliquet. In in massa purus. Nunc molestie tempor risus. Aenean venenatis fringilla adipiscing.

Sed felis arcu, fermentum et gravida sit amet, blandit pretium metus. Praesent at eros ac augue tincidunt interdum. Donec a mattis eros. Aliquam lobortis, turpis eget mattis dapibus, nulla purus venenatis erat, sed congue tortor nisl ut enim. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Cras vulputate felis et mauris scelerisque auctor. Sed sed imperdiet eros. Vivamus pulvinar consectetur ipsum sit amet pellentesque. Curabitur vitae massa massa, vel porta velit. Etiam consequat quam vitae augue blandit tempus. Vestibulum laoreet suscipit tortor sit amet ultrices.

Donec a lorem ut sapien vulputate ultrices et ac odio. In ut elit sed est ullamcorper sodales eu ultrices enim. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque dui ipsum, placerat sit amet hendrerit at, ullamcorper ac elit. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Curabitur a nisl nisl, sit amet convallis erat. Nunc ultricies ante sed nulla egestas scelerisque. Duis sed mauris eros. Donec tincidunt condimentum nisl, non aliquam augue sodales vitae. Pellentesque sit amet lorem vel lacus condimentum bibendum.

Praesent placerat tincidunt pharetra. Nam egestas, est rhoncus pharetra sodales, erat nisl euismod enim, non tempus velit elit at lacus. Aliquam erat volutpat. Fusce auctor varius ullamcorper. Suspendisse potenti. In a arcu id orci viverra rhoncus. In sit amet tellus id lacus porta bibendum nec quis ante. Aliquam ultrices quam eu eros consequat ut fermentum felis laoreet. Curabitur ullamcorper libero orci. Sed dignissim nunc a lectus posuere lobortis. Aliquam auctor enim ac neque pellentesque vulputate. Aliquam erat volutpat. Praesent pulvinar nunc volutpat urna dictum tincidunt. Nunc lectus erat, laoreet vitae vehicula a, facilisis eu sapien. Phasellus elementum aliquet sapien.

Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Aliquam euismod sem ac lorem sollicitudin tincidunt. Quisque vehicula neque vitae nisl cursus vitae iaculis nulla malesuada. Nulla urna augue, sodales vel viverra in, sagittis nec nulla. Maecenas lorem elit, pretium sed aliquet nec, pharetra a dolor. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Nunc vel cursus nisi. Curabitur aliquet, libero ut tempus malesuada, eros nisi cursus tellus, scelerisque semper quam turpis a turpis. Quisque ut metus augue. Maecenas fringilla, nulla quis fringilla commodo, quam justo ornare eros, quis ultrices tellus tortor sed tellus. Pellentesque in mattis tellus. Sed at sagittis odio. Nam et nisl lacus. Fusce imperdiet lacus dui, id s

I can post that in a nested quote with more text in the outer quote, so I don't think it's the max characters per post that's gonked. If I turn off the mod, then the posts we're having trouble with go through fine.

Quote:

Originally Posted by ravenscape (Post 2274743)

The max characters setting is at 50,000.

This is the maximum amount that I can post in a single quote.

I can post that in a nested quote with more text in the outer quote, so I don't think it's the max characters per post that's gonked. If I turn off the mod, then the posts we're having trouble with go through fine.

Excellent. The next thing to check is the /includes/class_verifyquotes.php file. Specifically the Parse function. It should look like this:

PHP Code:


		
			
public function Parse($text) { 



    $text = preg_replace('#\[quote.*?\]#i','[quote]',$text);

    $text = preg_replace('#\[quote\]\[\/quote\]#i','',$text);

    $text = preg_replace('#\[noparse\].*?\[\/noparse\]#si','',$text);



    $text = $this->do_parse($text);

    return preg_match('/\[quote.*?\]|\[\/quote\]/si',$text);

  }

if not, then you are still using the original buggy version.

--RayJ

Quote:

Originally Posted by xorex (Post 2274515)

will be good if mod would have setting for exclude validate quotes inside tags

example: [code] [html] [php] e.t.c

I tested some code changes that would allow for this. It will work, but you will introduce a huge problem that this product was designed to defeat. Wild looking posts. Here is an example:

--------START

THIS:

[QUOTE ]Test[QUOTE ]Nest #1[QUOTE ]Nest #2[QUOTE ]Nest #3[/QUOTE ]
[QUOTE ]in No Parse[/QUOTE ]
[code ][QUOTE]in Code [/code ]
[php ][QUOTE]in PHP[/php ]
[/QUOTE ][/QUOTE ][/QUOTE ]

RENDERS AS THIS:

[QUOTE]Test[QUOTE]Nest #1

Quote:

Nest #2

Quote:

Nest #3

[QUOTE]in No Parse[/QUOTE]

Code:

PHP Code:


		
			
[QUOTE]in PHP<div style="margin:20px; margin-top:5px; ">

    <div class="smallfont" style="margin-bottom:2px">Quote:</div>

    <table cellpadding="6" cellspacing="0" border="0" width="100%">

    <tr>

        <td class="alt2">

            <hr />

            

                

            

            <hr />

        </td>

    </tr>

    </table>

</div>

Quote:

[/QUOTE]

--------END

What is going wrong here? This product would tell you that the issue was mismatched quote tags. If you set it up to NOT detect this within PHP and CODE tags, then you might as well not use it at all.

--RayJ

Installed, tested, works like a charm. Great Mod, thanks!

It looked the same, except for a comment. I replaced the code and saved the file anyway in case I missed something.

On testing, it still doesn't work.

Quote:

No data received
Unable to load the webpage because the server sent no data.
Here are some suggestions:
Reload this webpage later.
Error 324 (net::ERR_EMPTY_RESPONSE): The server closed the connection without sending any data.

Quote:

Originally Posted by ravenscape (Post 2274759)

It looked the same, except for a comment. I replaced the code and saved the file anyway in case I missed something.

On testing, it still doesn't work.

Oops! I just gave you the Parse function, here is the entire code (with remarks):

PHP Code:


		
			
/**

* Quotes Validation Class

*

* @product    vqbc_rayj2009

*

*/

class vqbc_VerifyQuotes {



  /**

  * Parses the post message.

  *

  * @param  string  text to be validated for matching quote tags

  */

  public function Parse($text) { //returns TRUE if bad quote found



    $text = preg_replace('#\[quote.*?\]#i','[quote]',$text);

    $text = preg_replace('#\[quote\]\[\/quote\]#i','',$text);

    $text = preg_replace('#\[noparse\].*?\[\/noparse\]#si','',$text);



    $text = $this->do_parse($text);

    return preg_match('/\[quote.*?\]|\[\/quote\]/si',$text);

  }



  /**

  * sub-parsing function

  *

  * @param  string  (internal call only)

  */

  private function do_parse($text) {

    if(is_array($text)) { $text = $text[1]; }

    $regex = '#\[quote\]((?:[^[]|\[(?!/?quote\])|(?R))+)\[/quote\]#i';

    return preg_replace_callback($regex,array($this,'do_parse'),$text);

  }

}

--RayJ

still doesn't work.

I'll reinstall from scratch tomorrow and see if it clears up.

Quote:

Originally Posted by ravenscape (Post 2274775)

still doesn't work.

I'll reinstall from scratch tomorrow and see if it clears up.

Ok.

Also, what exactly does the system tell you when you have a quote with more than 8281 characters?

--RayJ

I have had to disable this plugin for 4.x.x as it has been causing problems for those trying to post long posts in quote tags. My host narrowed it down to this plugin and sure enough, as soon as it was disabled all the posting issues went away.

A shame, as it is a useful plugin. Just doesn't seem to work.

Quote:

Originally Posted by Joe Blow (Post 2446018)

It's a plugin for v3.8.x which might need some tweaking to be truly compatible with version 4.

Quote:

Originally Posted by Joe Blow (Post 2446018)

If you could tell me what exactly it is doing, I could work on a fix. Did you get any errors in the php error log? Any errors or other output in the browser?

Quote:

Originally Posted by Max Taxable (Post 2446035)

It's a plugin for v3.8.x which might need some tweaking to be truly compatible with version 4.

True. Thanks. I will to some testing on version 4 to see what I can find out.

--RayJ

Quote:

Originally Posted by raywjohnson (Post 2446070)

If you could tell me what exactly it is doing, I could work on a fix. Did you get any errors in the php error log? Any errors or other output in the browser?

True. Thanks. I will to some testing on version 4 to see what I can find out.

--RayJ

I am waiting on my host to respond to my request for additional info. In the meantime, you can take a look at this thread I started on vbulletin.com. The issue that I started the thread about was being caused by this plugin.

http://www.vbulletin.com/forum/forum...ong-post-error

This is what the host said in an email to me when this plugin was finally identified as the issue:

Quote:

Hey Joe, the class_verifyquotes.php plugin appears to be the culprit.
Are you able to disable that and confirm if it fixes it? I tried to
just rename the file but it's still getting called and giving a blank
page. While slightly better than a crash, i think disabling it or
updating that plugin ought to fix the problem.

Hope that helps.

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01396 seconds Memory Usage 1,910KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (3)bbcode_php_printable (22)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (40)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: