vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.7 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=228)
-   -   Private Messages Enhancements - Private Conversations (Threaded PMs) (https://vborg.vbsupport.ru/showthread.php?t=193064)

dinnerbone 10-07-2008 10:00 PM

Private Conversations (Threaded PMs)
 
Private Conversations is a small mod that adjusts the way your PMs are displayed; Instead of the old method which shows one at a time quoting the last message, this threads them and makes them work much like the Conversation feature that visitor messages use. A conversation is defined as two users PMing eachother using the same PM title (With or without the "Re:" prefix), so as to not mix up different conversations that aren't related.

Known Bugs
  • The conversation page looks ugly. I know, I'm sorry. I plan to redesign it straight away.
  • Sending a PM to yourself will show all messages that other people have sent you that have the same title. But to be honest, how often do you PM yourself? ;)
  • It currently ignores user-set avatar rules ("Hide all avatars", for example).
  • ???
  • Find a bug? Please let me know :)

To-Do List
  • Figure out a way to make folders work with conversations.
  • Redesign the conversation page!
  • Add a paging method to conversations, currently all of the messages are on the same page.
  • ???
  • Got an idea? Please tell me :)

Installation
Simply open up your ACP, click "Plugins & Products" on the left, "Manage Products", then import the attached file. No uploading or modifications required :D

Usage
Private Conversations is entirely automatic, no configuration or installation required (Other than the above). Upon visiting the "Private Messages" page, this mod will automatically list conversations. To see normal PMs instead of conversations, simply select a folder at the top menu (Such as "Inbox") and Private Conversations will let the default view take over; It will always allow vBulletins PM system priority over itself whenever it detects that the user has selected a folder.
A reply box will show at the top of each message, allowing for easy replies. You can also select 'View Full' on each message to see it in the old format, which you can also reply to using the old method. All messages apart from the three latest are automatically collapsed inside conversations, to save page space.

Note to mod developers
This uses and calls the following inbuilt hooks: private_showpm_start, private_messagelist_start, private_messagelist_messagebit, and private_messagelist_period. Because I am not too sure on how well this will cope with other mods, I have added a variable $pricon that will set to true if the user is viewing conversations not normal PMs, which you may check for in plugins and use to halt your code should it be incompatible for some reason.

Magnumutz 10-08-2008 02:20 PM

Awesome mod !!
First install :D

I guess that i could now disable the "visitor messages".

SuperDave71 10-08-2008 02:33 PM

This looks great! Thanks for this.

-Dave

bashy 10-08-2008 03:22 PM

Hi

Thanks for this

What is this section at the top, Is it supposed to be a quick reply area? See image please

If i click one of those 2 buttons i get

The following errors occurred with your submission:
  1. Please complete both the subject and message fields.

dinnerbone 10-08-2008 03:26 PM

Quote:

Originally Posted by bashy (Post 1640349)
Hi

Thanks for this

What is this section at the top, Is it supposed to be a quick reply area? See image please

If i click one of those 2 buttons i get

The following errors occurred with your submission:
  1. Please complete both the subject and message fields.

Hm, it is indeed meant to be a quick reply box. It's odd that it isn't showing up on your forums... I'll look into it.

bashy 10-08-2008 03:36 PM

Thank you, its more than likely because i am using the mns7 style, Although i used to
have the quick reply before your mod was installed :)

SuperDave71 10-08-2008 03:37 PM

I had a quick question. Is there a way we can put a small amount of space between the avatar and the PM text. It seems a BIT crowded to me. I love the mod and this is not a complaint, merely a suggestion.

Thank you so much in advance!

-Dave

soundbarrierpro 10-08-2008 07:19 PM

@ Dinnerbone.....You come up with some cool stuff! I'm going to watch this. Looks awesome. Thanks

FreshFroot 10-08-2008 09:34 PM

This is great honestly!!! Love the addon, this should be a default add in vB... That's how good it is ;)

logicuk 10-08-2008 09:50 PM

wow this is a sweeet mod thanks so much for taking your time to code this :D:D

BucWiLd 10-09-2008 12:10 AM

very kewl, installed

john102774 10-09-2008 04:44 AM

Awesome mod, installed. :)

M-Tuning 10-09-2008 07:50 AM

Very nice mod, I wait with installing till the redesign of the conversations.

Rideharder 10-09-2008 08:21 AM

Nice I will try it out on http://kaplanuniversitystudentforums.com ...Thanks so much!

Barakat 10-09-2008 08:57 AM

so much better than usual ,,

installed

nerofix 10-09-2008 09:40 AM

I love you! =)

MissKalunji 10-09-2008 10:38 AM

Nice mod but is it's triggering 21 queries? you've got uncache template as well :)

dinnerbone 10-09-2008 10:48 AM

Quote:

Originally Posted by SuperDave71 (Post 1640370)
I had a quick question. Is there a way we can put a small amount of space between the avatar and the PM text. It seems a BIT crowded to me. I love the mod and this is not a complaint, merely a suggestion.

Well, I said I was going to redesign the page ;) But if I don't get around to redesigning it next version, I'll put the avatar margin on :)

Quote:

Originally Posted by MissKalunji (Post 1640976)
Nice mod but is it's triggering 21 queries? you've got uncache template as well :)

Yeah sorry about that, they'll be cached next version and I'm looking into reducing the queries, although caching the templates alone will reduce the number greatly.

nerofix 10-09-2008 10:55 AM

Please use vbphrases for this:

View Full
Collapse
Expand

MissKalunji 10-09-2008 10:58 AM

Quote:

Originally Posted by dinnerbone (Post 1640983)
Well, I said I was going to redesign the page ;) But if I don't get around to redesigning it next version, I'll put the avatar margin on :)


Yeah sorry about that, they'll be cached next version and I'm looking into reducing the queries, although caching the templates alone will reduce the number greatly.

great Thank you :)

dinnerbone 10-09-2008 11:02 AM

Quote:

Originally Posted by nerofix (Post 1640990)
Please use vbphrases for this:

View Full
Collapse
Expand

Whoops, I didn't realise 'View Full' wasn't attached to a phrase. I'll fix that next version. As for Collapse and Expand, they are already phrases.

nerofix 10-09-2008 11:20 AM

I think there are already original vb phrases for those words, if you would use them (not your custom phrases), then we wouldn't need to translate them anymore.

Alfa1 10-09-2008 11:23 AM

I wonder if this works on vb 3.8. Has anyone tried?

dinnerbone 10-09-2008 11:26 AM

Quote:

Originally Posted by nerofix (Post 1641007)
I think there are already original vb phrases for those words, if you would use them (not your custom phrases), then we wouldn't need to translate them anymore.

I check for existing phrases before making new ones. There already is a 'view full' one which I'll use, but the closest to 'Collapse' that I found was 'collapse_x', which was a Style phrase and as such would require style phrases to be included in the PM system. There was a 'expand' phrase, but again it was a Style phrase.

Alfa1, I'm installing 3.8 as we speak so I'll be making a version for that if this is not directly compatible.

nerofix 10-09-2008 11:38 AM

Oh yeah, you were right with the phrases.

Good work by the way, looks good.

Well, something is a bit strange and I am not sure why:

Not all conversation messages are displayed of some members. Could it be that they have deleted their messages from their "sent items" folder?

dinnerbone 10-09-2008 11:43 AM

It will only show their side of the conversation if they have the messages in their Sent Items folder, as doing otherwise would defeat the purpose of that folder and might also open up possible exploits in reading other peoples mail, as well as causing other complications.
Please check to make sure they have the messages inside their sent folder box, if they are there then can you please tell me if there is any relation to the messages that aren't shown - such as they are all the nth message, or are all sent by the same user, etc.


Edit: Alfa1, I just tested in vBulletin 3.8 and it appears to work fine. But it looks like "Save a copy of this message in your Sent Items folder" is unchecked by default in that version, which is required for this mod to show users sent messages in conversations. This only applies to messages sent using the normal form, the quick reply I included with the mod automatically saves them.

Roxie 10-09-2008 01:35 PM

Would be nice if the conversation showed how many messages were in it.

Roxie 10-09-2008 01:41 PM

I have a lot of conversations. But it only shows one page of them. When I go to page 2, it goes back to the default view. Is this normal?

dinnerbone 10-09-2008 02:18 PM

Quote:

Originally Posted by Roxie (Post 1641077)
Would be nice if the conversation showed how many messages were in it.

Next version :)

Quote:

Originally Posted by Roxie (Post 1641083)
I have a lot of conversations. But it only shows one page of them. When I go to page 2, it goes back to the default view. Is this normal?

I think I know what's wrong; Whenever a folder is selected, it reverts to the default view because this doesn't use folders - vBulletin selects the inbox (by default) when viewing a different page. A fix is on it's way in the next version, it should be ready by tonight :)

logicuk 10-09-2008 03:38 PM

Thanks for the great work keep it up dinnerbone this is a sweet addon :)

The Coon 10-09-2008 05:10 PM

Thx from Germany, it`s really nice and it?s worth to go on with the work for this MOD.
Installed ... and waiting for Updates ... :cool:

WreckRman2 10-12-2008 12:22 AM

Is there a way to show the thread in reverse order? Oldest first and replies under?

Kurgan 10-16-2008 07:38 PM

Quote:

Originally Posted by SuperDave71 (Post 1640370)
I had a quick question. Is there a way we can put a small amount of space between the avatar and the PM text. It seems a BIT crowded to me. I love the mod and this is not a complaint, merely a suggestion.

Thank you so much in advance!


-Dave

Quick fix I did:

Find this in template pm_showconvo:
Code:

#pm_list div.fixed_width_avatar {
        float:left;
}


Add a padding: 6px; line under float:left; like so:
Code:

#pm_list div.fixed_width_avatar {
        float:left;
        padding:6px;
}


Gives a pretty nice look with minimal change to the code.

Kurgan 10-16-2008 08:34 PM

Just a few suggestions/requests for this mod, if I don't find a way to do them myself :D :

-Find a way to reverse the view order (or give the user an option to reverse the order) so it appears from oldest at the top, to newest at the bottom, with the quick reply box at the bottom of the list so it appears more like a thread
(I know this has already been requested)

-Add a check box to allow the user to select all messages in the conversation for deletion

-Give a drop down box with more options when a message is selected (just like when you're in the standard "View Inbox" view, there is a drop-down box with delete, move, mark read, mark unread, and export options with a Go! button)

-Currently, after you delete a message or choose to look in your Sent Items or Inbox (or any custom folder), you are returned to the standard Private Messages view, not Private Conversations. Improve the usability of this function to return back to Private Conversations for the end user so that they don't have to click on the "Private Messages" button in the welcome block or "List Messages" in the User CP just to get back to the Private Conversations view.

-Put more user information about the sender than their avatar and username with a link to their profile. Can easily reproduce the format here based on what's in the postbit template for the threads in the forums to show the user's name, their title, a drop-down box for the user information, as well as instant messaging icons and other information.

I definitely like it so far, though! :D I was getting tired of multiple levels of nested quotes in my PMs!

Mazoo 10-17-2008 08:03 AM

Quote:

Originally Posted by bashy (Post 1640349)
Hi

Thanks for this

What is this section at the top, Is it supposed to be a quick reply area? See image please

If i click one of those 2 buttons i get

The following errors occurred with your submission:
  1. Please complete both the subject and message fields.

Great product :up: !

but i face the same problem:(

dinnerbone 10-17-2008 09:13 AM

Quote:

Originally Posted by Kurgan (Post 1646632)
Just a few suggestions/requests for this mod, if I don't find a way to do them myself :D :

-Find a way to reverse the view order (or give the user an option to reverse the order) so it appears from oldest at the top, to newest at the bottom, with the quick reply box at the bottom of the list so it appears more like a thread
(I know this has already been requested)

-Add a check box to allow the user to select all messages in the conversation for deletion

-Give a drop down box with more options when a message is selected (just like when you're in the standard "View Inbox" view, there is a drop-down box with delete, move, mark read, mark unread, and export options with a Go! button)

-Currently, after you delete a message or choose to look in your Sent Items or Inbox (or any custom folder), you are returned to the standard Private Messages view, not Private Conversations. Improve the usability of this function to return back to Private Conversations for the end user so that they don't have to click on the "Private Messages" button in the welcome block or "List Messages" in the User CP just to get back to the Private Conversations view.

-Put more user information about the sender than their avatar and username with a link to their profile. Can easily reproduce the format here based on what's in the postbit template for the threads in the forums to show the user's name, their title, a drop-down box for the user information, as well as instant messaging icons and other information.

I definitely like it so far, though! :D I was getting tired of multiple levels of nested quotes in my PMs!

- I'm working on custom sorts and such, they're already (partially) working on my test forums. The layout of the page is subject to peoples own tastes, some want it to appear as a thread with full postbits and such, but others (such as myself) want it to appear more like the current "Conversation" system that is in place for visitor messages. I'm looking at options to cater both, but for now I'm afraid it's easier for me to use the second view.

- I've got that working on my test forums, it will be in for the next version.

- I was going to, but I realised that there aren't really much options I can put in. You can't move messages to certain folders, because the way the conversation system works. Mark read and unread again aren't the most useful options to add because it only checks if the latest message was read/unread not other ones inside the conversation, which leaves us with the Delete option. I'll be looking to support the other options at a later date when I rewrite the way Conversations are stored and identified.

- vBulletin likes to stick the folderid on the end of the URL wherever possible, and naturally this product lets any URL with a folderid take priority over itself because the user might have opted to view in the old way. I have created a fix on my test forums to not include the folderid when deleting messages and it will be in for the next release.

- See the first point :)

Thank you for your feedback :)


I hit a little logical problem in the next version and it might not be released as soon as I'd liked. I'm going to look at an alternate method of storing and identifying conversations that will hopefully resolve lots of logical issues that prevent me from making major adjustments, as well as including better features and hopefully all less database strain. There's no ETA to the next version I'm afraid, it'll be done when it's done :)

chris1979 10-25-2008 04:03 PM

This is a really great idea. I will use this once the new version is out with the extra bits. Really looking forward to it! My members will love it. :)

lille L 10-26-2008 10:04 AM

Installed. Very nice ! Works fine here ! Thanks !!

lille L 10-29-2008 06:08 PM

I was a bit to early. This is very unstable at my forum. It changes between old pm system and this one. And it removes old messages from the converstation

Tyran1 11-12-2008 10:19 PM

A good Addon nevertheless is missing nen bissl which.
Adjustment to the Addon pn appendix.
Adjustment file & Exit should look alike.
Überschirft receiving in the post office entrance is missing.

How would it be to be integrated message pursuit in the post office exit?

Auf deutsch:

Ein gutes Addon doch fehlt nen bissl was.
Anpassung zum Addon PN Anhang.
Anpassung Ordner Ein & Ausgang sollten gleich aussehen.
Überschirft Empfangen im Posteingang fehlt.
Wie wäre es die Nachrichtenverfolgung im Postausgang zu integrieren?


All times are GMT. The time now is 04:12 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01250 seconds
  • Memory Usage 1,843KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (11)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete