vb.org Archive - Speech-mark turns to " in result of a query

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)

- - Speech-mark turns to " in result of a query (https://vborg.vbsupport.ru/showthread.php?t=189716)

sparklywater

09-01-2008 10:01 AM

Speech-mark turns to " in result of a query

I have this function which trims the thread-title of the latest posts after a query fetches the latest posts. Everything works well except I've noticed that if this query trims the thread-title at a speech-mark ( " ) , instead of displaying the speech-mark in the result it shows &quo... instead. But if I increase the cut-off by a few more characters then the speech mark is displayed correctly. How can I make the query display the speech-mark without it displaying '&quot...' at certain lengths of cutoff?

Here is the query to trim the thread-title:

PHP Code:


		
			
if (strlen($row['thread_title']) > $vbulletin->options['latest_trimplusthree'])
       {
        // adds the cutoff ... with substr
        $row['thread_title'] = substr($row['thread_title'], 0, $vbulletin->options['latest_trim']) . '...';
       }

--------------- Added [DATE]1220329262[/DATE] at [TIME]1220329262[/TIME] ---------------

someone help please...

sparklywater

09-03-2008 12:27 AM

has this been posted in the right section?

Marco van Herwaarden

09-03-2008 09:40 AM

Try using multibyte functions instead. So mb_substr() instead of substr(), and mb_strlen() instead of strlen().

sparklywater

09-03-2008 10:17 AM

Thanks for your reply, I've just tried that but it still shows &quo... in the results.

--------------- Added [DATE]1220440916[/DATE] at [TIME]1220440916[/TIME] ---------------

This is the query which fetches the latest posts:

PHP Code:


		
			
// query to get the last posts

    $query = $vbulletin->db->query_read_slave("

        SELECT

            post.postid, post.pagetext as pagetext, post.userid, post.username, post.dateline AS date,

            thread.forumid, thread.title as thread_title, thread.threadid,

            forum.forumid, forum.title as forum_title, thread.replycount as replies, thread.views as views

        FROM " . TABLE_PREFIX . "thread AS thread

        INNER JOIN " . TABLE_PREFIX . "post AS post on (post.postid = thread.lastpostid)

        INNER JOIN " . TABLE_PREFIX . "forum AS forum on (thread.forumid = forum.forumid)

        WHERE post.visible = '1' AND thread.visible = '1' AND open = '1' AND $platest_and AND $platest_and_1

        ORDER BY postid DESC

        LIMIT $plimit"

    );

Opserty

09-03-2008 10:50 AM

Try the fetch_trimmed_title vBulletin function instead.

sparklywater

09-03-2008 01:03 PM

Quote:

Originally Posted by Opserty (Post 1613494)

Try the fetch_trimmed_title vBulletin function instead.

Thanks but I have no idea how to use that function.

Opserty

09-03-2008 01:27 PM

Did you click the link and read the function description? ;)

sparklywater

09-03-2008 04:56 PM

Quote:

Originally Posted by Opserty (Post 1613576)

Did you click the link and read the function description? ;)

How can I make that function work with this query:

PHP Code:


		
			
// query to get the last posts

    $query = $vbulletin->db->query_read_slave("

        SELECT

            post.postid, post.pagetext as pagetext, post.userid, post.username, post.dateline AS date,

            thread.forumid, thread.title as thread_title, thread.threadid,

            forum.forumid, forum.title as forum_title, thread.replycount as replies, thread.views as views

        FROM " . TABLE_PREFIX . "thread AS thread

        INNER JOIN " . TABLE_PREFIX . "post AS post on (post.postid = thread.lastpostid)

        INNER JOIN " . TABLE_PREFIX . "forum AS forum on (thread.forumid = forum.forumid)

        WHERE post.visible = '1' AND thread.visible = '1' AND open = '1' AND $platest_and AND $platest_and_1

        ORDER BY postid DESC

        LIMIT $plimit"

    );

Opserty

09-03-2008 06:27 PM

You don't use it in the query... you do it to the title you've fetched.

sparklywater

09-03-2008 06:57 PM

The query has the following line which fetches the thread title, doesn't it?

PHP Code:


		
			
 SELECT
          thread.title as thread_title

I have to use that query to get the latest posts on the forum, but the part I'm stuck on is using a function to correctly trim the thread-title of these latest posts.

If I use the function you linked to, I would have to make it work with this query which fetches the actual posts, is that not correct? The title itself isn't enough because I need the thread-titles to link to the latest posts.

Dismounted

09-04-2008 07:25 AM

You run the function when you're looping through the results - not in the query itself.

sparklywater

09-04-2008 07:45 AM

Quote:

Originally Posted by Dismounted (Post 1614202)

You run the function when you're looping through the results - not in the query itself.

I looked in /includes/functions.php and found the following lines of code:

PHP Code:


		
			
// #############################################################################
/**
* Trims a string to the specified length while keeping whole words
*
* @param    string    String to be trimmed
* @param    integer    Number of characters to aim for in the trimmed string
* @param  boolean Append "..." to shortened text
*
* @return    string
*/
function fetch_trimmed_title($title, $chars = -1, $append = true)
{
    global $vbulletin;

    if ($chars == -1)
    {
        $chars = $vbulletin->options['lastthreadchars'];
    }

    if ($chars)
    {
        // limit to 10 lines (\n{240}1234567890 does weird things to the thread preview)
        $titlearr = preg_split('#(\r\n|\n|\r)#', $title);
        $title = '';
        $i = 0;
        foreach ($titlearr AS $key)
        {
            $title .= "$key \n";
            $i++;
            if ($i >= 10)
            {
                break;
            }
        }
        $title = trim($title);
        unset($titlearr);

        if (vbstrlen($title) > $chars)
        {
            $title = vbchop($title, $chars);
            if (($pos = strrpos($title, ' ')) !== false)
            {
                $title = substr($title, 0, $pos);
            }
            if ($append)
            {
                $title .= '...';
            }
        }

        //$title = fetch_soft_break_string($title);
    }

    return $title;
}

//

Now if I use the above code as it is in my page it doesn't work, ie. no trimming of the thread-titles. I've tried changing the value of $chars from -1 to other values like 45 but that doesn't work either. Do I need to change anything else for this code to correctly trim the thread-titles?

Can you please give an example of the code I need to use?

Opserty

09-04-2008 09:15 AM

fetch_trimmed_title() is a function, you use it like any other function such as substr() or rand() or mysql_query() or something. It is just a user defined function, nothing special.

Quote:

fetch_trimmed_title (line 641)
Trims a string to the specified length while keeping whole words
fetch_trimmed_title (string $title, [integer $chars = -1], [boolean $append = true])

string $title: String to be trimmed
integer $chars: Number of characters to aim for in the trimmed string
boolean $append: Append "..." to shortened text

That tells you what variables you put into the function. (It is the same as when http://php.net/substr lists what parameters are for the substr() function)

sparklywater

09-05-2008 07:32 PM

what does the -1 in ' integer $chars = -1 ' mean?

Can someone refer me to a website / tutorial which would answer these kind of questions?

Dismounted

09-06-2008 05:04 AM

Look in the function's code - you even posted it. It's one of the first lines of the actual function.

sparklywater

09-06-2008 07:20 AM

Quote:

Originally Posted by Dismounted (Post 1615643)

Look in the function's code - you even posted it. It's one of the first lines of the actual function.

I know it's the number of characters to aim for in the trimmed string, but I was asking specifically about the negative value, ie. why the number of characters is a negative value ( -1 ).

Opserty

09-06-2008 07:31 AM

Dismounted meant you should read the PHP code, for the function, you yourself have already posted...

https://vborg.vbsupport.ru/showpost....8&postcount=12

(Read it line by line if you need to :p)

sparklywater

09-06-2008 08:00 AM

that doesn't answer my question, and you're not helping.

Opserty

09-06-2008 08:20 AM

Go to the 15th line of the PHP code you posted... I don't need to help you. The answer is staring you in the face. ;)

If, after you've read the 15th line (and the few lines after it) and I mean after! (No cheating :p) You still don't understand, post the 15th line and 3 lines underneath it.

All times are GMT. The time now is 02:24 PM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01110 seconds Memory Usage 1,794KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (5)bbcode_php_printable (5)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (19)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: