vb.org Archive - Submit score "bug"

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- ibProArcade Archive (https://vborg.vbsupport.ru/forumdisplay.php?f=174)

- - Submit score "bug" (https://vborg.vbsupport.ru/showthread.php?t=168888)

Stifmeister2

01-27-2008 06:38 PM

Submit score "bug"

When you have "only save user's best score" enabled and you score the exact same score as your high score, but the time is faster, it should change the time to the faster one... But now it doesn't!

Few members have complained about that, they both shared the high score in one game but they were 2nd and 3rd in the high score list sinmce they had worse time than the 1st one. Now they scored the same high score but they were faster than the 1st guy but their time didn't change. :(

MrZeropage

01-27-2008 08:34 PM

in v2.6.6+ this should work fine ... you mean highscore or "best result ever" ?

Stifmeister2

01-28-2008 01:14 PM

Quote:

Originally Posted by MrZeropage (Post 1430333)

in v2.6.6+ this should work fine ... you mean highscore or "best result ever" ?

High score. And we have 2.6.6.+...

MrZeropage

01-28-2008 04:28 PM

if another player has same score but better time, does it update the name ?

I am somehow clueless, as this should work fine:

Code:

             $DB->query("SELECT champ_score AS score, champ_time AS time, champ_name AS name, champ_mid AS mid, champ_gtitle FROM ibf_games_champs WHERE champ_gid=".$gid);

             if( $DB->get_num_rows() )

             {

                     $champ = $DB->fetch_row();

                  if( ($player_score<>0) && (($player_score > $champ['score'] && $ginfo['highscore_type'] == "high") || ($player_score < $champ['score'] && $ginfo['highscore_type'] == "low") || ($player_score == $champ['score'] && (($timespent < $champ['time']) || ($champ['time']==0)))) )

Stifmeister2

01-29-2008 03:44 PM

Quote:

Originally Posted by MrZeropage (Post 1430943)

if another player has same score but better time, does it update the name ?

I am somehow clueless, as this should work fine:

Code:

             $DB->query("SELECT champ_score AS score, champ_time AS time, champ_name AS name, champ_mid AS mid, champ_gtitle FROM ibf_games_champs WHERE champ_gid=".$gid);

             if( $DB->get_num_rows() )

             {

                     $champ = $DB->fetch_row();

                  if( ($player_score<>0) && (($player_score > $champ['score'] && $ginfo['highscore_type'] == "high") || ($player_score < $champ['score'] && $ginfo['highscore_type'] == "low") || ($player_score == $champ['score'] && (($timespent < $champ['time']) || ($champ['time']==0)))) )

Yes if the "another player" doesn't have that score yet.

Basically every time you get the same score as your own high score (but you have better time), the score won't be saved, as it only says: "Your score won't be stored in Database because the Arcade only saves users top score per Game."

MrZeropage

01-29-2008 06:32 PM

Ok, I admit I now found the problem - I fixed this all for "save all users scores" but not for that "save only best result".

This now is fixed for v2.6.7+ :)

Please contact me via PM for testing this fix... thx

Stifmeister2

01-30-2008 01:16 PM

Quote:

Originally Posted by MrZeropage (Post 1431934)

Thanks man. :)

haytham

02-03-2008 04:13 PM

So there is a v2.6.7+?

MrZeropage

02-03-2008 04:21 PM

...coming in the future, yes :)

Fix done in the code for the upcoming version

Stifmeister2

02-03-2008 06:24 PM

I have run the test 2.6.7+ that you gave me Zero for 3 days now and this problem is now fixed. :) Thanks! :)

MrZeropage

02-04-2008 05:01 PM

fix will be included in upcoming v2.6.7+

All times are GMT. The time now is 05:50 PM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01045 seconds Memory Usage 1,734KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (3)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (11)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: