vb.org Archive - Foreach Loop

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=111)

- - Foreach Loop (https://vborg.vbsupport.ru/showthread.php?t=166881)

Mythotical

01-03-2008 10:56 PM

Foreach Loop

I'm trying loop categories so I get main category then the sub cats listed below them for a download section mod I'm building.

Here's the code thus far:

PHP Code:


		
			
     $cats = $vbulletin->db->query("SELECT * FROM `" . TABLE_PREFIX . "xsdl_cats` WHERE sub_cat = '0' AND par_cat = '0'");



    while($category = $vbulletin->db->fetch_array($cats))

        {

                $cid = $category['cid'];

                $cname = $category['cat_name'];

                // $rating = round($entry['rating']);

                $description = $category['description'];

                $subcat = $category['sub_cat'];

                $file_loc = $category['file_loc'];

                $screen_loc = $category['screen_loc'];

 

                $query = $db->query_first("

                      SELECT COUNT(`dlid`) AS `total`

                    FROM `" . TABLE_PREFIX . "xs_downloads`

                    WHERE cat_id = " . $category['cid'] . "

                ");

 

                $subs = $vbulletin->db->query("SELECT * FROM `" . TABLE_PREFIX . "xsdl_cats` WHERE sub_cat = '1' AND par_cat = '$cid'");

                while($sub_cats = $vbulletin->db->fetch_array($subs))

                {

                    $scid = $sub_cats['cid'];

                    $scname = $sub_cats['cat_name'];

                    // $srating = round($sub_cats['rating']);

                    $sdescription = $sub_cats['description'];

                    $ssubcat = $sub_cats['sub_cat'];

                    $sfile_loc = $sub_cats['file_loc'];

                    $sscreen_loc = $sub_cats['screen_loc'];

                }

 

                $count = $query['total'];

                $key[0] = $cid;

                $key[1] = $cname;

                $key[2] = $description;



                foreach ($key as $value)

                {

                echo $value;

                    $sub[0] = $scid;

                    $sub[1] = $scname;

                    $sub[2] = $sdescription;

                    foreach ($sub as $value)

                        {

                        echo '<a href="downloads.php?do=cat&amp;id=' . $value . '">' . $value . '</a><br />' . $value . '';

                        }

                }

Any help much appreciated.
Steve

Marco van Herwaarden

01-04-2008 06:18 AM

And the problem is?

Mythotical

01-04-2008 05:56 PM

Oh sorry, the problem is that they will display but I'm not sure how to get them to display like so:

Main Cat 1
- SubCat2 | - SubCat3
- SubCat4
Main Cat 2
- SubCat5 | - SubCat6
- SubCat7 | - SubCat8

But all I get from that foreach is a list of all categories that just repeat. So maybe I'm missing something.

Thanks
Steve

Guest190829

01-04-2008 06:17 PM

Why not just select all the categories and order them in an array properly in a single loop? You will be generating quite a few queries with your current method....

Mythotical

01-04-2008 09:26 PM

Actually, what you suggested Danny is what I'm trying but failing horribly. Any code suggestions?

Marco van Herwaarden

01-05-2008 07:05 AM

Please provide the table structure and sample data.

Tefra

01-05-2008 08:20 AM

it's a simple structure with only one level of subcategories right ?

PHP Code:


		
			
$sql = $db->query_read("SELECT * FROM `" . TABLE_PREFIX . "xsdl_cats` WHERE 1");

while ($row = $db->fetch_array($sql))

{

    if($row['sub_cat'])

    {

        $cats[$row['par_cat']] = $row;

    }

    else

    {

        $cats['0']    =    $row;

    }

}





foreach($cats as $key => $value)

{

    if($key > 0) continue;

    

    echo $value['cat_name'].'<br />';

    

    foreach($cats as $k => $v)

    {

        if($k == 0 OR $k != $key) continue;

        echo '- '.$v['cat_name'].' | ';

    }

}

Guest190829

01-05-2008 11:22 AM

Something like:

PHP Code:


		
			
$ordered_cats = array();
while ($cat = $vbulletin->db->fetch_array($cats))
{
    if(!$cat['sub_cat'])
    {
         $ordered_cats[$cat['id']] = $cat;
    }
    else {
         $ordered_cats[$cat['parent_cat']]['subcats'] = $cat;
    }
}

That's not tested..but should point you in the right direction, hopefully. You can order by the sub_cat column and make sure that all parents are selected first.

Mythotical

01-15-2008 10:40 PM

Tefra: sub_cat is no longer used, all I use now is par_cat. Here is an updated piece of code.

PHP Code:


		
			
    $number_cats = 0; 
    $cats = $vbulletin->db->query("SELECT * FROM `" . TABLE_PREFIX . "xsdl_cats` WHERE par_cat = '$id' ORDER BY cid"); 
        while($category = $vbulletin->db->fetch_array($cats)) 
        { 
            $cid = $category['cid']; 
            $cname = $category['cat_name']; 
            // $rating = round($entry['rating']); 
            $description = $category['cat_description']; 
            $parcat = $category['par_cat']; 
            $file_loc = $category['file_loc']; 
            $screen_loc = $category['screen_loc']; 
    
            $query = $db->query_first(" 
                SELECT COUNT(`dlid`) AS `total` 
                FROM `" . TABLE_PREFIX . "xs_downloads` 
                WHERE cat_id = " . $category['cid'] . "
            "); 
             
            $count = $query['total'];
            $show['open_row'] = $number_cats++ %2 == 0;
            eval('$downloads_bit .= "' . fetch_template('xs_downloads_bit') . '";'); 
        }

What I did is use an if condition in my template:

HTML Code:

<if condition="$number_cats == '0'">do nothing<else />begin displaying sub cats</if>

Now what I'm thinking to cut down on queries is setup an if statement in the file:

PHP Code:


		
			
if(THIS_SCRIPT == 'downloads' AND !empty($_GET['id']))
{
$mid = 0;
} else {
$mid = $id;
}

That would combine my 2 cat queries I'm having to run in the file.

Now the foreach confused me because I don't use sub_cat any longer, if you could redo the example using par_cat.

Danny.VBT, your more than welcome to answer my questions above. Now the example code you posted I didn't understand, can you explain each portion or what its doing example wise?

Thanks
Steve

Tefra

01-16-2008 07:36 AM

I suggest you one really helpful change to calculate the total entries of each category during the add,delete,move of the download entries. This way you will save the count query.

PHP Code:


		
			
// Part One This could be cached in datastore to save even more queries//

// The cache should be re-written each time you manage the categories and after the add/delete/move of a download entry //

$sql = $db->query_read("SELECT * FROM `" . TABLE_PREFIX . "xsdl_cats` WHERE 1");

while ($row = $db->fetch_array($sql))

{

    $catcache[$row['cid']] =  $row;

    $icatcache[$row['par_cat']][$row['cid']] = $row['cid'];

}



$vbulletin->input->clean_array_gpc('g', 'id', TYPE_INT);

$id = (empty($vbulletin->GPC['id'])) 0 : $vbulletin->GPC['id'];



// Part Two Build teh cat list //

foreach ($icatcache[$id] AS $cid)

{

    if (empty($icatcache[$id])) continue;

    

    $cname             = $catcache[$cid]['cat_name'];

    $description     = $catcache[$cid]['cat_description']; 

    $file_loc         = $catcache[$cid]['file_loc']; 

    $screen_loc     = $catcache[$cid]['screen_loc']; 

    $count            = xs_calc_total($cid);

    foreach($icatcache[$cid] AS $subcid) // Grab one level of subcats //

    {

    

        $sub_cname             = $catcache[$subcid]['cat_name'];

        $sub_description     = $catcache[$subcid]['cat_description']; 

        $sub_file_loc         = $catcache[$subcid]['file_loc']; 

        $sub_screen_loc     = $catcache[$subcid]['screen_loc'];

        eval('$downloads_subs_bit .= "' . fetch_template('xs_downloads_subs_bit') . '";'); 

    }    

    eval('$downloads_bit .= "' . fetch_template('xs_downloads_bit') . '";'); 

}



function xs_calc_total($id, $total = 0)

{

    global $icatcache, $catcache;

    

    $total += $catcache[$id]['total']; // Grab the total from the current category //

    

    foreach($icatcache[$id] AS $cid) // Recursive grab the total from all the subs //

    {

        $total += xs_calc_total($cid, $total);

    }

    return $total;

}

Mythotical

01-16-2008 05:24 PM

Thanks Tefra, will give it a go later.

EDIT: I just noticed something Tefra, in the code above you have it counting categories, why I had it that way I don't know, what I meant to count when viewing the main page you see a total number of files for that cat and all sub cats then a total for files under that main cat only. I'm still trying to figure that out, once I get the cats sorted, I'll post up my file count stuff.

--------------- Added [DATE]1200524647[/DATE] at [TIME]1200524647[/TIME] ---------------

Seems this line:

PHP Code:


		
			
$id = (empty($vbulletin->GPC['id'])) 0 : $vbulletin->GPC['id'];

is causing this error:

Code:

Parse error: syntax error, unexpected T_LNUMBER in /downloads.php on line 96

I changed it to '0' but got an error of encapsed this and that. So I'm not sure about that line.

Dismounted

01-17-2008 03:07 AM

PHP Code:


		
			
$id = (empty($vbulletin->GPC['id'])) ? 0 : $vbulletin->GPC['id'];

Missing ternary operator.

Mythotical

01-17-2008 03:21 AM

Duh, I was just looking at similar code in another file, didn't even think about that. Thanks Dismounted.

Tefra

01-17-2008 07:26 AM

sorry about the syntax error, the code above is based on my suggestion to calculate the entries of each category during the management of the categories and during the add, edit, delete and tje move of the entries.

If you decide to go with a multi-level structure the counting with queries during listing will be really ugly.

If you go with this structure for example

Downloads A
- Downloads ab | Downloads ac

You can't have it saying Downloads A total entries = 0 when the subs have entries inside.

Marco van Herwaarden

01-17-2008 07:36 AM

also shouldn't it be:

PHP Code:


		
			
$id = (empty($vbulletin->GPC['id']) ? 0 : $vbulletin->GPC['id']);

Also as you are already using the GPC functions to only allow a numeric value, this is probably useless as it will already default to 0.

Dismounted

01-17-2008 08:22 AM

Marco, both methods are correct.

Guest190829

01-17-2008 08:46 AM

Marco is correct, however, that it is a redundant check - what should be checked is if the id is negative or not, which can be done using TYPE_UINT.

All times are GMT. The time now is 03:07 PM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01204 seconds Memory Usage 1,853KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_code_printable (1)bbcode_html_printable (9)bbcode_php_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (17)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: