vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Private Messages Enhancements - User PM Search (https://vborg.vbsupport.ru/showthread.php?t=149609)

Thaliada 06-12-2007 10:00 PM

User PM Search
 
Description:
This modification allows your users to search thru their pms

Installation:
All the installation information is in the package.

Changes/Adds:
7 Plugins
19 Phrases
1 Template
1 Template change

Changelog
2.0
Rewrote some parts and included (hopefully) all feature requests
- Search is now on a single page
- Usergroup permission added
- (Little to) no template changes necessary
- Should hopefully work with other pm addons like pm preview etc without additional template changes (not tested)

1.0.2
Fixed a template bug, thx Makc666

Change
Code:

$vbphrase[search_results_in_folder]<span class="normal">: <span id="nav_pmfolders.messagelist">$foldername<script type="text/javascript"> vbmenu_register("nav_pmfolders.messagelist"); </script></span></span>
to
Code:

$vbphrase[search_results_in_folder]<span class="normal">: $foldername</span>
1.0.1
Fixed some minor problems

Hornstar 06-13-2007 12:46 PM

Actually this is something that I had thought of only last night ^^

and now here it is! awesome :)

Muellmann 06-13-2007 02:28 PM

:up: :up: :up: Absolutely awesome! I searched for such mod a long time. Some staffmembers have so many pm that it's very handy to be able to search through them.
Should be a vb default feature. Thanks very much. ;)

Lizard King 06-13-2007 02:39 PM

Perfect Modification

MThornback 06-13-2007 02:59 PM

Great work :D

CMGU 06-13-2007 03:02 PM

woww excellent! very nice

MThornback 06-13-2007 03:07 PM

Question...do you plan on adding usergroup settings?

AzzidReign 06-13-2007 03:10 PM

Wow! You are amazing! I LOVE YOU! lol I get TONS of PM's at my sites and some of them I just leave in my inbox knowing I have to go back and read them...but then it gets buried 8 pages back...and I have a hard time finding them again.

I've thought that this should be a vb default option for quite some time now! Good work!

wtrk 06-13-2007 05:16 PM

i just wanted this like 5 minutes ago :) thanks!

apdcanari 06-13-2007 05:30 PM

Good hack !

3.5 please ? :rolleyes:

hcmagix 06-13-2007 07:32 PM

fine hack, its working BUT I get warnings after results.
Quote:

Warnung: in_array() [function.in-array]: Wrong datatype for second argument in /private.php(206) : eval()'d code (Zeile 359)

Warnung: in_array() [function.in-array]: Wrong datatype for second argument in /private.php(206) : eval()'d code (Zeile 359)

Warnung: in_array() [function.in-array]: Wrong datatype for second argument in /private.php(206) : eval()'d code (Zeile 359)
search by keyword

an
Quote:

Warnung: Invalid argument supplied for foreach() in /private.php(206) : eval()'d code (Zeile 340)
search by username
can u fix it?

Thaliada 06-13-2007 07:42 PM

I've uploaded a fixed version, forgotten to turn warnings on

Quote:

Originally Posted by MThornback (Post 1267707)
Question...do you plan on adding usergroup settings?

Added it to my ToDo list

hcmagix 06-13-2007 07:48 PM

thx works fine

installed

cheat-master30 06-13-2007 08:04 PM

This is absolutely incredible as a modification. Seems to work extremely well, and best of all, it has the same helpful Javascript functions as other searches, such as suggesting names. Downloaded, using and rated 5/5.

Ramsesx 06-14-2007 01:28 AM

Great, now I can search my over 3000 pm's.

jderouen 06-14-2007 04:26 AM

Excellent!! Clicked installed, rated 5 stars!

SuperTaz 06-14-2007 04:31 AM

Everything is fine except for your readme file in the zip. It is bunched together and could hardly understand it till I sorted it all out...lol Other than that it is fine.

jderouen 06-14-2007 04:34 AM

One thing - it apparently doesn't like the word "wonder." I was just testing it, searching through PMs, and even though I had a PM that listed "wonder woman" both in the title and in the body, it wouldn't find it. Found "woman" when I searched for that, but when I searched for "wonder" it told me: Please specify some words or valid user names to search on. There were no matches for those that you specified.

Simms 06-14-2007 04:44 AM

Thank you!

I have been waiting/wishing for this for more than a year.

Simply awesome ... installed and working!

4x4 Mecca 06-14-2007 05:17 AM

in my search box on the page, this text is in there by default.
"SELECT id, link FROM #__menu WHERE menutype = 'mainmenu' AND published = 1 ORDER BY parent, ordering"

I deleted it, searched for the word "please" and when the results came back, I clicked on one, and the word please as not in the PM... I don't have any ideas why.

I'm on 3.6.4 of that matters.

testebr 06-14-2007 05:39 AM

I love you with all my power!

The amazing mod! I want this resource by default in vbulletin next build.

Please send suggestion to Jelsoft team.

sross 06-14-2007 05:53 AM

got an error in 3.6.4 so guess i need to upgradet to 3.6.7 to ue it

Quote:

Database error in vBulletin 3.6.4:

Invalid SQL:

SELECT pm.*, pmtext.*
, icon.title AS icontitle, icon.iconpath
FROM pm AS pm
LEFT JOIN pmtext AS pmtext ON(pmtext.pmtextid = pm.pmtextid)
LEFT JOIN icon AS icon ON(icon.iconid = pmtext.iconid)
WHERE pm.userid=8
AND pm.folderid= AND MATCH(pmtext.title, pmtext.message) AGAINST ('+joey' IN BOOLEAN MODE)
ORDER BY pmtext.dateline DESC;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND MATCH(pmtext.title, pmtext.message) AGAINST ('+joey' IN BOOLEAN MODE)
' at line 7
Error Number : 1064
Date : Thursday, June 14th 2007 @ 01:45:38 AM
Script : http://www.mysite.org/forums/private.php?folderid=0
Referrer : http://www.mysite.org/forums/private.php
IP Address : 121.72.6.223
Username : Me
Classname : vb_database

Thaliada 06-14-2007 06:19 AM

Quote:

Originally Posted by 4x4 Mecca (Post 1268198)
in my search box on the page, this text is in there by default.
"SELECT id, link FROM #__menu WHERE menutype = 'mainmenu' AND published = 1 ORDER BY parent, ordering"

I deleted it, searched for the word "please" and when the results came back, I clicked on one, and the word please as not in the PM... I don't have any ideas why.

I'm on 3.6.4 of that matters.

Seems like you have another plugin installed which uses a var named $query somewhere before the searchplugin is included. In the Template change <div><input type="text" class="bginput" name="query" size="35" value="$query" style="width:250px" /> to <div><input type="text" class="bginput" name="query" size="35" value="" style="width:250px" /> and you should be fine. I'll rename it a next version.

Quote:

Originally Posted by sross (Post 1268205)
got an error in 3.6.4 so guess i need to upgradet to 3.6.7 to ue it

Just installed 3.6.4 and can't replicate your error, worked fine, sry :/
You could copy and paste the query into phpmyadmin for a more detailed error msg, maybe that helps

Edit: Ah ok i see your problem. somehow the folderid isn't passed along. Do you have any other pm hacks installed? because on a fresh install it works.

Makc666 06-14-2007 08:02 AM

Good modification!
But here are some notes and bug.

1. After you made a search a bug appears.
There are two down arrows appeare https://vborg.vbsupport.ru/external/2010/06/3.gif after phrase:
Search Results In Folder: Inbox https://vborg.vbsupport.ru/external/2010/06/3.gifhttps://vborg.vbsupport.ru/external/2010/06/3.gif

And after phrase Private Messages in Folder: Inbox the down arrow disappear.

Better to see screenshots:
Attachment 65638
Attachment 65639

P.S. This is a clean install of 3.6.7 PL1

The Fix for this is to change this code from ReadMe.txt:
Code:

$vbphrase[search_results_in_folder]<span class="normal">: <span id="nav_pmfolders.messagelist">$foldername<script type="text/javascript"> vbmenu_register("nav_pmfolders.messagelist"); </script></span></span>
To this one:
Code:

$vbphrase[search_results_in_folder]<span class="normal">: $foldername</span>

2. A littile note.
Why you didn't include templates modification in MOD file, so we have no need to edit template. Just Install.
As I looked throw I think it can be done so.
For example you can take a look how it works in this mod:
https://vborg.vbsupport.ru/showthread.php?t=122592

And once again Thanks for you work!

jluerken 06-14-2007 08:18 AM

Very nice. Should become a default for one of the future vb versions

jderouen 06-14-2007 01:44 PM

Still curious why it ignores the word "wonder."

Subah 06-14-2007 02:17 PM

Cool Thanks :)

Thaliada 06-14-2007 02:21 PM

Quote:

Originally Posted by Makc666 (Post 1268271)
2. A littile note.
Why you didn't include templates modification in MOD file, so we have no need to edit template. Just Install.
As I looked throw I think it can be done so.
For example you can take a look how it works in this mod:
https://vborg.vbsupport.ru/showthread.php?t=122592

And once again Thanks for you work!

Didn't knew this is possible, i'll have a look at.

Quote:

Originally Posted by jderouen (Post 1268392)
Still curious why it ignores the word "wonder."

Dunno, maybe it's in your ignore list for the standard search?

NolF 06-14-2007 02:25 PM

Quote:

Originally Posted by sross
Database error in vBulletin 3.6.4:

Invalid SQL:

SELECT pm.*, pmtext.*
, icon.title AS icontitle, icon.iconpath
FROM pm AS pm
LEFT JOIN pmtext AS pmtext ON(pmtext.pmtextid = pm.pmtextid)
LEFT JOIN icon AS icon ON(icon.iconid = pmtext.iconid)
WHERE pm.userid=8
AND pm.folderid= AND MATCH(pmtext.title, pmtext.message) AGAINST ('+joey' IN BOOLEAN MODE)
ORDER BY pmtext.dateline DESC;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND MATCH(pmtext.title, pmtext.message) AGAINST ('+joey' IN BOOLEAN MODE)
' at line 7
Error Number : 1064
Date : Thursday, June 14th 2007 @ 01:45:38 AM
Script : http://www.mysite.org/forums/private.php?folderid=0
Referrer : http://www.mysite.org/forums/private.php
IP Address : 121.72.6.223
Username : Me
Classname : vb_database

I have the same error on 3.6.7 pl1.

PS this mod is designed to implement template changes easily ^^ should make it easier to learn how to use this function this way :P

Thaliada 06-14-2007 02:36 PM

AND pm.folderid=

is the problem, when does this error occure?
Do you have any other pm mods installed?

if(!isset($_GET['folderid'])) $_GET['folderid'] = 0;

at the beginning should deal with it. You can try replacing it with if(!isset($_GET['folderid']) || trim($_GET['folderid']) == '') $_GET['folderid'] = 0;

otherwise i don't have a clue what could cause this problem.
i've updated the archiv accordingly

harley_m 06-14-2007 04:17 PM

You are godly for doing this!

Awesome, thank you so much :)

Harley

jderouen 06-14-2007 05:57 PM

Quote:

Originally Posted by Thaliada (Post 1268413)
Dunno, maybe it's in your ignore list for the standard search?

No, it's not. I'm not so much concerned about that one word as I am confused, and concerned that there are other words it won't be able to find.

Thaliada 06-14-2007 06:20 PM

Are you sure you are searching in the right folder?
If so, could you send me a copy of the specific pm and your exact search query?

4x4 Mecca 06-14-2007 08:19 PM

Quote:

Originally Posted by jderouen (Post 1268540)
No, it's not. I'm not so much concerned about that one word as I am confused, and concerned that there are other words it won't be able to find.

I opened the xml, and the word wonder is not even in there, so it's not the product itself messing up, it's something on your server. I don't know if you already knew that, I'm just trying to help.

rjmjr69 06-15-2007 12:34 AM

Great Hack

harley_m 06-15-2007 05:23 PM

Having used this I have one suggestion / plea for help

Having it above the PM's is useful, but a bit 'in your face', and having it below means the results also appear down there.

What would be perfect is a new item in the left hand Control Panel menu under PM's for search - which would open up a new control panel page with the PM searching / results on it - rather than having the search right there in the inbox.

PM searching is dead useful, but having it as a self contained feature they choose from the menu would be much less in the way for everyday PM usage.

Would this be hard? I know one can create custom Vb pages with the header etc on them, but then you would lose the control panel interface / menu. Is there a way of creating a new 'control panel page' easily?

but great work on this, very much appreciated

Harley

Nathan2006 06-15-2007 05:42 PM

Thank you Thaliada

This is something I really need :D

Install

Fungsten 06-15-2007 08:34 PM

On test server.

StrifeX 06-16-2007 06:31 AM

I have to say, awesome work man! This is a truly great job of a vB-Addon. :D

Definitely should be vBulletin default, rated 5/5 and clicked install.

scottct1 06-16-2007 07:56 PM

Installed and nominated as MOTM!


All times are GMT. The time now is 09:53 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01760 seconds
  • Memory Usage 1,827KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_code_printable
  • (11)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (2)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete