vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   End-User Options - Mark All Forums Read Confirmation (https://vborg.vbsupport.ru/showthread.php?t=142376)

Dismounted 03-17-2007 10:00 PM

Mark All Forums Read Confirmation
 
Mark All Forums Read Confirmation

Description:
This mod asks for confirmation when marking forums read.

Request:
https://vborg.vbsupport.ru/showthread.php?t=142371

Installation:
All the installation information is in the package.

Changes:
4 Plugins
4 Phrases

Change Log:
19/09/2007 - Version 1.2
- Automatic Template Edits
- Added Confirm When Double-Clicking Forum Icon
- Updated ReadMe

20/03/2007 - Version 1.1
- Extended Functionality Globally

18/03/2007 - Version 1.0
- Initial Release

Dismounted 03-18-2007 10:08 AM

/me Reserves!

WhaLberg 03-18-2007 10:10 AM

/me will give a try later.

Thanks Dis.

Masiello 03-18-2007 10:26 AM

Usefull Hack, thx, I'll try it later

Masiello 03-18-2007 10:33 AM

Installed :)

bitdefuser 03-18-2007 11:29 AM

Installed. :D

EDIT: Search $vbphrase[mark_forums_read] in your styles and replace the whole <a href> tag with the one he gave.
Why? You might have multiple places that has the "Mark Forums Read" button, such as the Welcome Panel Rewrite mod or in your ForumHome template near the footer.
(I had three places.)

EDIT2: Dismounted, you might want to add that into your readme. :)

Tralala 03-18-2007 04:45 PM

Thanks for this, Dismounted! As mentioned elsewhere, I've been wanting something like this for awhile now.

Tralala 03-18-2007 04:57 PM

Quote:

Originally Posted by bitdefuser (Post 1206284)
Installed. :D

EDIT: Search $vbphrase[mark_forums_read] in your styles and replace the whole <a href> tag with the one he gave.
Why? You might have multiple places that has the "Mark Forums Read" button, such as the Welcome Panel Rewrite mod or in your ForumHome template near the footer.
(I had three places.)

EDIT2: Dismounted, you might want to add that into your readme. :)


Agreed; I had it in navbar (under QuickLinks) and also in footer, in another style.

Works great though... should be standard feature of vBulletin.

/clicks install

Smoothie 03-18-2007 05:23 PM

Darn, you guys keep releasing these cool mods and I keep installing them. I can't wait until the next major (templates need reverting) upgrade. :P

Tralala 03-18-2007 05:29 PM

Quote:

Originally Posted by Tralala (Post 1206575)
Agreed; I had it in navbar (under QuickLinks) and also in footer, in another style.

Works great though... should be standard feature of vBulletin.


Actually, this works for me everywhere, except the QuickLinks pulldown in the standard vBulletin skin. I select the "Mark Forums Read" menu option, confirm the dialog that pops up, then nothing happens; no page refresh like I am used to.

(Ironically enough it works fine in my custom skin, in the QuickLinks pulldown, and all the other spots.)

Any clues?

EDIT: Code removed, as I'm told by Ziki below that it won't work, don't want to confuse future readers

Ziki 03-18-2007 05:44 PM

I suggest to remove the link from there because it won't ever work

Quote:

Originally Posted by Tralala (Post 1206601)
Actually, this works for me everywhere, except the QuickLinks pulldown in the standard vBulletin skin. I select the "Mark Forums Read" menu option, confirm the dialog that pops up, then nothing happens; no page refresh like I am used to.

(Ironically enough it works fine in my custom skin, in the QuickLinks pulldown, and all the other spots.)

Any clues? Here's the code:

Before:
Code:

<tr><td class="vbmenu_option"><a href="forumdisplay.php?$session[sessionurl]do=markread">$vbphrase[mark_forums_read]</a></td></tr>
After:
Code:

<tr><td class="vbmenu_option"><a href="forumdisplay.php?$session[sessionurl]do=markread" rel="nofollow" onclick="return mark_all_read()">$vbphrase[mark_forums_read]</a></td></tr>


Tralala 03-18-2007 06:48 PM

Quote:

Originally Posted by Ziki (Post 1206618)
I suggest to remove the link from there because it won't ever work

Yeah, since I discovered the code mod wasn't working there I removed it and put it back to the "original" way. I also moved the "Mark Forums Read" to a different position of the QuickLinks menu, so it would be less likely to be selected by user mistake.


The confirmation mod DOES work properly in the QuickLinks pulldown of my other (customized) skin... at least, when I am in forumhome. (The confirmation dialog doesn't seem to pop up when I choose it from UserCP, or Threadview, or Search. But even with that, the menu command still works, just no confirmation dialog.) It didn't work in vBulletin at all.

Why is there no way to get it to work as desired in the the QuickLinks pulldown? Why can it work (somewhat, ie: in forumhome, but not elsewhere) in one skin... but not in vB skin at all? I tried making a seperate "Mark Forums Read" link in navbar template, and noticed the same weirdness. The confirmation dialog only appears when accessing it from forumhome.

Just wondering, trying to learn.



Would it make sense to introduce this confirmation dialog into the "do=markread" command instead? That way it'd be universal to it's invocation everywhere. Make a preference option in UserCP so visitors could choose whether or not they get the Confirmation dialog... and I'd nominate this for MOTM. :D

HMBeaty 03-18-2007 07:39 PM

Awesome, never thought to do this. Nice job

/me clicks Install

Doctor Death 03-18-2007 07:49 PM

Great idea. Installed.

Smoothie 03-18-2007 08:06 PM

So wait, this works, but it don't in the QL?

Smoothie 03-18-2007 08:16 PM

works fine here.

Tralala 03-18-2007 08:55 PM

Quote:

Originally Posted by Smoothie (Post 1206802)
works fine here.

Test it further, kemosabe. It works on your forumhome's QuickLink menu only... but NOT when you try it from anywhere else (ie: inside a forum, a thread, UserCP, etc.)

I just checked on your forum (macfora.com) and see it doesn't work. In fact, choosing the command from those other places does nothing on your forum... it breaks the menu item completely.

Smoothie 03-19-2007 12:36 AM

Quote:

Originally Posted by Tralala (Post 1206845)
Test it further, kemosabe. It works on your forumhome's QuickLink menu only... but NOT when you try it from anywhere else (ie: inside a forum, a thread, UserCP, etc.)

I just checked on your forum (macfora.com) and see it doesn't work. In fact, choosing the command from those other places does nothing on your forum... it breaks the menu item completely.

That's funny, because I never thought to check those. I only checked forumhome. And you're correct, it no worky on those other pages.

Smoothie 03-19-2007 12:39 AM

So, we have a half working mod here. Works only from forumhome and not anywhere else.

Smoothie 03-19-2007 12:42 AM

One other thang. When clicking forum icons to "mark this forum and contents as read", you should get a confirmation box for that too, no? I gotta uninstall until this gets fixed.

Dismounted 03-19-2007 04:44 AM

Quote:

Originally Posted by bitdefuser (Post 1206284)
Installed. :D

EDIT: Search $vbphrase[mark_forums_read] in your styles and replace the whole <a href> tag with the one he gave.
Why? You might have multiple places that has the "Mark Forums Read" button, such as the Welcome Panel Rewrite mod or in your ForumHome template near the footer.
(I had three places.)

EDIT2: Dismounted, you might want to add that into your readme. :)

Hmmm, I might. Depends
Quote:

Originally Posted by Tralala (Post 1206601)
Actually, this works for me everywhere, except the QuickLinks pulldown in the standard vBulletin skin. I select the "Mark Forums Read" menu option, confirm the dialog that pops up, then nothing happens; no page refresh like I am used to.

(Ironically enough it works fine in my custom skin, in the QuickLinks pulldown, and all the other spots.)

Any clues?

EDIT: Code removed, as I'm told by Ziki below that it won't work, don't want to confuse future readers

You have to change the plugin location to global_complete. I made it at forumhome_complete because it was originally design to be only used for the link on the index.

Doctor Death 03-19-2007 10:31 AM

Clicks Uninstall until it is debugged

Dismounted 03-19-2007 10:56 AM

What is there to debug? The hack is working as designed, it's just that people make modifications to the original usage which creates bugs.

TrIn@dOr 03-19-2007 11:13 AM

Working in the command of the footer, but not in the navbar!

Triky 03-19-2007 11:20 AM

Jelsoft should add this to the next releases, in my opinion. :)

Smoothie 03-19-2007 02:05 PM

Quote:

You have to change the plugin location to global_complete. I made it at forumhome_complete because it was originally design to be only used for the link on the index.
Has anyone done this and had success? Without thinking I tried global_start instead of global_complete and of course it did not work.

Smoothie 03-19-2007 02:06 PM

Hey Dismounted,

Any chance of getting this to work with forum markers too?

Tralala 03-19-2007 02:35 PM

Quote:

Originally Posted by Dismounted (Post 1207224)
What is there to debug? The hack is working as designed, it's just that people make modifications to the original usage which creates bugs.

While I agree with what you are saying here, if that's the stance you plan to take, you may want to explicitly state in the first post here that "this mod only provides a confirmation dialog when users click the 'Mark Forums Read' link on Forum Home, and nowhere else."

Because otherwise, one would assume the functionality is extended to every instance of "Mark Forums Read." Why would it not, from a UI standpoint? Why would one "Mark Forums Read" command differ from another?

Clearly there's a desire for consistency with this enhancement. It can be confusing if it works as expected in one place but not another -- especially when it comes to this sort of command where data (read/unread markers) is about to be effectively lost. That's the point of this mod, to give some security and warning back.

And so, as annoying as it may be that folks have begun to "run with" your mod and add stuff and then complain about bugs, I'd look at it as a compliment. Folks really like what you've started here! And so, may I respectfully request that you enhance this a tiny bit to work globally? Pretty please? :)

Quote:

Originally Posted by Dismounted (Post 1207115)
You have to change the plugin location to global_complete. I made it at forumhome_complete because it was originally design to be only used for the link on the index.

Quote:

Originally Posted by Smoothie (Post 1207333)
Has anyone done this and had success? Without thinking I tried global_start instead of global_complete and of course it did not work.

I tried changing it to global_complete and it did not work for me. I'd previously changed the other instances of the "Mark All Forums Read" command to call on the Javascript, but changing the plugin as suggested still didn't bring up the Confirmation dialog. :(

Still, regardless of what happens with this mod, I want to thank Dismounted for stepping up to the bat and offerring this up. vBulletin has needed this for a long while, and no one else cared to share. So, thanks, Dismounted!

Smoothie 03-20-2007 01:05 AM

That's a shame it does not work globally. It may confuse members in it's present state. As mentioned above, it's an awesome mod. Maybe Dismounted can help us out here and get this to work on all pages.

Dismounted 03-20-2007 06:51 AM

Hack Updated!

20/03/2007 - Version 1.1
- Extended Functionality Globally

Smoothie 03-20-2007 08:45 AM

Quote:

Originally Posted by Dismounted (Post 1207899)
Hack Updated!

20/03/2007 - Version 1.1
- Extended Functionality Globally

Thanks Dismounted. Will check it out later.

TrIn@dOr 03-20-2007 10:15 AM

Thanks.

Issue:
When clicking Mark all read in navbar menu, nothing happens.
The dropped menu stays there with no action.

Edit:

In FF you can see the warning but nothing happens after.

In IE here is the error

http://img120.imageshack.us/img120/2851/errorzk1.jpg

Smoothie 03-20-2007 12:55 PM

Guess I'll be waiting to install until I get confirmation it actually works.

TrIn@dOr 03-21-2007 10:24 AM

Hello?

Tralala 03-21-2007 03:34 PM

TrIn@dOr, do you get that error using the default vBulletin skin, or a custom skin?

TrIn@dOr 03-21-2007 04:31 PM

Quote:

Originally Posted by Tralala (Post 1208875)
TrIn@dOr, do you get that error using the default vBulletin skin, or a custom skin?

Special own skin, the original was deleted.

Smoothie 03-22-2007 12:49 AM

Has anyone got this installed and working completely on all pages?

Tralala 03-22-2007 02:30 AM

I think we're all afraid.

Dismounted 03-22-2007 04:52 AM

Sorry about that, I forgot to make a change in the readme. I have updated the zip. You can just do the following to get it to work.

In the template 'headinclude', find:
PHP Code:

function mark_all_read() 

Replace With:
PHP Code:

function mark_all_read(type


Tralala 03-22-2007 08:01 AM

Okay, I bit the bullet.

I just removed version 1.0 completely, then installed version 1.1. I went to my templates and removed the previous code, then replaced with new code.

The "Mark Forums Read" link on forumhome works properly with the new confirmation. But the QuickLinks menu option does not.

When I choose "Mark Forums Read" from the QuickLinks pulldown, the confirmation dialog pops up... but when I click OK, it goes away and nothing happens. No page refresh, no threads marked as "read..." nothing.

This is on the default vBulletin style.


All times are GMT. The time now is 05:52 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01835 seconds
  • Memory Usage 1,830KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (2)bbcode_php_printable
  • (14)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete