vBPrivate Threads
 

vBPrivate Threads

This hack has been ported to vBulletin 3.5.4 from the vBulletin 3.0.0 version with permission granted by:
in Kentaurus's post for its original release, found here

--------------------------------------------------------
This is my first major ported and released hack for vB.
--------------------------------------------------------

With this Code Modification you can add private threads to your forums. A private thread is:

• A thread that some users or usergroups can view. Others cannot.
• A thread that some users or usergroups cannot view. All others can.

Using this Modification, any user in a forum that has Private Threads turned on may create a private thread. It is useful for holding private moderator conversations, or for making a thread private when some users would like to see the discussion closed and others want it to continue.

Future Plans:

• Add Super Moderators and Moderators to override the standard permissions
• Admin Options for allowed private thread types
• Admin Options to define users with override-permissions privilages
• Admin Options for those who can make private threads
• Private Threads will NOT show in the lastpost column when user does not have access to thread
• Creator can view thread by default

Hack History:

Version 1.0.6

• Changed several file edits to plugins (Thank you waza)
• Some plugins were reverted back to file edits, no version change as it is going a bit backward

Version 1.0.5

• Updated queries for install
• Added queries for uninstall
• 1 Added Plugin
• Fixed copy/paste errors in file edits find/change
• Added missing printthread edit
• Fixed Search problem

Version 1.0.0

• Initial release

Hack Overview:

• Products: 1
  • 2 Queries
  • 1 Phrase
  • 13 Plugins
• File Edits: 5 files (7 edits)
• Template Edits: 3
• Estimated Install time: Under 10 minutes

If you liked this hack then please Install it! :D

Installed.
Thank you :D

First and foremost...THANK YOU!!!

*****************************

I'm getting an error when we try to call the search function (as in when we click New Posts)...

Fatal error: Call to undefined function: private_thread_not_allowed() in /.../search.php on line 1823

Same happens in the other instantiation of the function on line 2224. Commented those out for now

****************************

The product doesn't seem to create the 'allowprivate' field...added that manually to the DB and then manually adjusted it as needed for my interim solution

***************************

When I try to edit a thread, I get...

Parse error: parse error, unexpected $ in /.../postings.php on line 2327

In the second portion of code added to postings.php, it's missing the closing } for the if statement

******************************

When I edit a thread that's been private...if I had more than one name saved originally in the allowed/denied list, when it pulls them back in, it only brings back the first name in the list.

That's unexpected behavior, and I have it running just fine on my main board and test board. I'll install it on my test board again tonight and get back to you on the results of further testing.

It's still in beta and I have some improvements ready for it, too.

Does it has usergroup permissions?
And can't you do it with less file edits (by replacing them with plugins.)
However, It sure looks good!

Bleh, my first release and I mess up stuff as simple as copying and pasting. Sorry about that :nervous:

I've updated to v1.0.5 and fixed the problems (works flawlessly when installed on my test board), added to the product, and added a new plugin to it.

@waza: What do you mean by usergroup permissions? You can allow or restrict viewing by usergroup, if that's what you mean.

I've tried to limit file edits to the best of my ability. I've only been on vB3.5 for a week, and just learning the new data management was daunting enough. If I can find other ways, or if anyone else can find other ways, to avoid file edits and maximize plugin use, the hack will be updated for that.

No what I mean is if you can restrict usergroups who can post private threads.
However, I looked @ the zip, and as there aren't any bitfield xml's their wont be usergroup permissions.
Like here:
https://vborg.vbsupport.ru/showthread.php?t=82844

And I'm sure a lot of file edits can be done by plugins, If I find some time I try to make use of plugins and pm them.

Perfect!

You wouldn't believe the need I have for this. It's incredibly sensitive, and this is a life saver.

Thank you so much for making and publishing it.

Thanks.

Looks like you finished before this:
https://vborg.vbsupport.ru/showthread.php?t=80135

From the types of people I deal with in my forums this would be abused 10 thousand times over. If anything try to add an option for which usergroups or users are allowed/not allowed to use this option. Something like...

Can user select thread options: Yes / No

:) That version fixes everything!

And I figured out the multiple users thing...I was doing what was intuitive and putting a space after the semi-colon like a list...but no space can go there. So I'm altering the template to put a warning about that for my users (who aren't the most computer literate sometimes!).

The only problem that's keeping me from making this live now...when the thread shows in the Last Post column and you click on it, you can see it no matter if you're supposed to or not. It's like that call doesn't check the private_thread_not_allowed().

I'm hoping to have that changed soon. I still need to find out how to make it check for the next available "last thread" after that, and then repeat the permissions check, and loop until it finds one the person does have permission to.

I think you missed out something like:
in the showthread.php file, and then change $restrictedusers to $threadinfo[privateusers] in the showthread template.

And I've made it admin only, by doing things like the following in the newthread and the edit thread templates:
Where 6 is the id of the Admins usergroup

Yup... :)

I don't mind it showing in the Last Post column...that doesn't matter at all...it's just that it needs to check it when you load from that link (or any other direct link).

Ok...got that working...that was my error! :D

Happy happy joy joy!

Buro, the program by default checks if you are an admin or not. I am working on a more advanced usergroup selection for making and viewing threads, also, I am drawing closer to the cure for the message in the last thread posted in area, 'Tis a beta for a reason, It will have errors as it goes further, thanks for the feedback so far :D.

The update later should also include the permissions for the thread creator by default and make it so all admins, mods, and super mods can view threads, unless you choose to turn supermods and mods off.

Are you planning on making an option to enable only certain usergroups to set this option? How about making it only available in one forum?

Can't tell you how excited I am to get this! Thanks!

I will add making permissions for who CAN make private threads to the "future plans" list. Hi already can set the ability to have private threads per forum (this is Yes by default).

Clicked install, hopefully in the future this won't need any file edits... if possible.

When I make a thread and list the people allowed to see it,I go in with my test regular user name...If I click on new posts or the forum the private thread is in ,I get this error message:

Fatal error: Cannot break/continue 1 level in /home/*****/public_html/forums/forumdisplay.php(938) : eval()'d code on line 4

But, I don't get this error if I make a thread using the test account and then go look at it logged in as an admin. I hope that made sense. Any idea?:ermm:

When did you install the hack? Do you have any other plugins or file edits to forumdisplay.php? Could you show what that line (and surrounding lines) contains in your file?

The only change to forumdisplay.php (from my hack) should be a plugin, and I'm not experiencing any problems using it at all.

I installed it tonight. Yeah I have a lot of things in the forumdisplay. This is what is around line 938



I will go disable things one by one and see if it is another hack causing it :)

I think you're supposed to use CODE or PHP tags to hide the code from non-licensed users :)
If line 938 is the hook, and other plugins are using that hook, then the problem may be the order that the code is executed in. I know that the order can cause some problems. Perhaps try turning off the other plugins for that location?

I just took it out of my post.:nervous:


Thanks, that is what I am trying now. :)

Tell me how it turns out so I can look into why it might be eroring for you, need to fix bugs even if I cant reproduce it. :D

@ambie: If you disable the product of this hack, do you still get the error, if so it has nothing to do with this hack, otherwise:
post the content of the plugin from this hack in the hook: threadbit_display.

@Eikinskjaldi (or anyone else) -- before i go live with this, is the issue about the last post linking fixed, or can anyone see the thread/and or its contents?

do i have to do this?


I didn't follow the above..

Thanks

drex

crap new posts in the vbcmps doesn't work now. whole board is screwy.

uninstalling....

ok, now that i was able to stop a disaster. (and no, i don't have a test board -- too much work), the issues are:

1) if you are not an admin, or one of the 'allowed' users, and you click on the LAST POST link, you get the error listed above that ambie stated.

2) the search for 'New Posts' on the Vbadvanced CMPS front page doesn't work either

luckily, if you turn off the 'private threads allowed' forums, all goes back to normal.

this is a little too buggy to use live. needs more work, though great hack...

the vbcmps error:

Fatal error: Cannot break/continue 1 level in /home/-----/public_html/search.php(2207) : eval()'d code on line 4
__________________

Can you post or PM me the lines of code you are having issues with? I had no issues with my own board and this hack so it might be that something is interfering, if the line is a plugin then please specify the plugin and i'll check it to see if there is anything outstanding in it.

The other thing you mentioned is that it shows a link to a new private thread, but it gives you an error message, it should be a vBphrase error message as well. This is to alert the user they don't have permission. However until I figure out the exact code I need to use I cannot remove them from the 'New thread' area without making it do a much more ugly thing of 'Private thread' and no link.

that would be the 4th line of code in search.php.... ?? not sure which code you want me to give you!

I believe I've found the problem - It was where several file edits had been changed to be plugins, plugins that, looking at the code, come at inopportune times. I am editing the install file and the product to reflect the revert back to having, I believe, 2 more file edits and 2 less plugins.

*slaps forehead*

Well, I have found the cause of the search issue, It is quite a stupid one to be honest. If you have the current private thread hack installed, all you need to do is change the search and forumdisplay files. The instructions for each will be in the install directions.

Good luck!

[[Will shortly upload the new and improved install file with the correct code edit. Sorry about that!]]

Nothing I was doing was working, but I just got an update e-mail. I just uploaded the new file and did the file edits and now it works great. Thank you! :)

Where did the update email come from?

I sent an update that automatically e-mails any user who has clicked "install" for this hack.

Is the printthread.php hack not missing one of these:

i didn't see an email.... (i haven't uninstalled, just not activated a private forum)...

can you post the file edits here or pm me?

buro9: Quite apparently in the installer, although my installed version seems to already have it. The product's been updated, thank you for catching that :)

drex: The plugins at threadbit_display and search_results_threadbit have been removed. They've been replaced with the following file edits.

In search.php
Find:
Add BELOW:
In forumdisplay.php
Find:Add BELOW: