Coding Syntax
Due to the release of vB3 being around the corner (i like being vague :)) I just thought I'd post some coding standards that
have been introduced. Variables They must have appropriate names to the data they contain if you've just selected data from the user table don't call it $stuff or anything like that. When your reffering to any information passed in by the user use $_REQUEST['variablename'] or $_POST['variablename'] instead of $variablename, some nice register_globals off compliance. Basic Syntax Use tabs to indent the line, this should be done everytime you open a new set of parenthesis and will continue until the closing parenthesis. Parenthesis should be on a new line of there own like below PHP Code:
Use singlequotes from now on where possible, you will not be able to do this when you have a variable in the string as this will not be evaluated with the string. This includes keys in arrays, unless the key is another array you would use the second example in the following code. PHP Code:
When reffered to there should be no spaces between the name and the parameters being passed in. PHP Code:
Depreciated Functions It was common to see the following in vBulletin 2, the second version is what will be used in vBulletin 3. PHP Code:
With an if expression where you are comparing two or more items use OR and AND, not || and &&. This is simply due to the fact that its easier for the human to read. I know i've forgotten stuff and I will add more as I can think of it. Hopefully this will improve coding in general when your not using vBulletin and writing your own scripts. |
wow PPN ;) thanks alot :) now i can see some light as to why vb3 will be in fact diferent ;) thanks for sharing the very useful information... regards...
g-force2k2 |
Everything is more or less coded to a standard, anything thats not will get changed eventually.
|
i see around all the array stuff
ie :: PHP Code:
PHP Code:
Also should we not use the second example anymore? regards... g-force2k2 |
Yep vB3 uses the first and it is correct, if you dont have any quotes then its an undefined constant, using the quotes indicates a string.
Added a bit about using 'and' and 'or' instead of || and && |
question PPN?
whats the difference btw using? the positioning of if? ie :: PHP Code:
PHP Code:
And is this $_REQUEST and $_POST vars vb3 creations or are they standard with php? regards... g-force2k2 |
Em just cosmetic with the if, it looks nicer ;)
its the PHP Super Globals http://www.php.net/manual/en/languag...predefined.php for $_POST and $_REQUEST. Though $_REQUEST is used because its all input from the user. |
There are 7 super global arrays in PHP, as of 4.1.0:
$_GET - contains all information that passed in the address bar (or a form with get method)... used to be $HTTP_GET_VARS. $_POST - contains all information that is passed through a posted form (if the form was using the post method)... used to be $HTTP_POST_VARS. $_COOKIE - contains all cookie information... used to be $HTTP_COOKIE_VARS. $_REQUEST - simply a merge of all three arrays above... new. $_FILES - contains information about uploaded files... used to be $HTTP_POST_FILES. $_ENV - all environment variables... new AFAIK. $_SERVER - all server variables... used to be $HTTP_SERVER_VARS. Note that in vB3 these arrays are NOT super globals, or at least you must not assume they are. You'll see why when you actually see the code in init.php. |
This brings up a question... will vB3 still be compatible on servers running older versions of php?
Due to an operating system conflict (damned Sun Microsystems machines), I can't safely upgrade my version of php without the potential of breaking the control panel for the OS.... Is there a function to determine if the version of php supports the super globals, such as $_REQUEST and if not, to define it as a new global using $HTTP_GET_VARS['REQUEST'] (I think that was right... off the top of my head)? |
Yeah, it's one of my main concerns about vb3. What will be the minimun required PHP version to run vb3?
|
All times are GMT. The time now is 12:34 AM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
More Information | |
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|