vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - iTrader v2.8 - Powerful Rating System (https://vborg.vbsupport.ru/showthread.php?t=232044)

entertain 03-21-2012 08:49 PM

@TiKu:

please tell me where this is needed?!

TiKu 03-21-2012 09:26 PM

I've seen 2 or 3 lines in the source code where you compare VB's template version against '4.1.3'. Before the release of VB 4.1.10 you simply used templateversion > '4.1.3' which was okay. Starting with 4.1.10 you had to use something else. Now you're doing it like this:
templateversion > '4.1.3' || inarray(templateversion, '4.1.10', '4.1.11')
This forces you to update the code on each new VB release. Also as a software developer I have to say that this code isn't very pretty.

fwulfers 03-22-2012 01:57 AM

Thanks so much for fixing the security issue and make this available again. I installed this today and have a small issue. When someone leaves feedback, the system sends out 2 PMs right after each other. The first pm has a wrong link:

Quote:

Details about this transaction can be found *on your iTrader page* (http://2/itrader.php?u=2).
The second pm has the correct link:

Quote:

Details about this transaction can be found *on your iTrader page* (http://saabworld.net/itrader.php?u=2).
Why is it sending that first pm with the wrong link (number replaces the domain name) and how can it be eliminated?

meissenation 03-22-2012 11:20 AM

thanks for the patch!

wmturkey 03-22-2012 12:03 PM

I've just installed it on 4.1.10, followed all the instructions to the letter, and it's not showing up on the forum. Any hints?

Thanks!

Edit: Didn't enable it in Settings > Options. Working now. Thanks!

entertain 03-22-2012 01:23 PM

Thank you very much meissenation for this donation!!! :)

entertain 03-22-2012 01:24 PM

@fwulfers:
I will check it today, when I can reproduce it, I will post a fix here! :)

@wmturkey:
Glad to hear that it is working. I hope you can give me a feedback when you like it (or even don't). :)

entertain 03-22-2012 03:17 PM

Quote:

Originally Posted by fwulfers (Post 2311931)
Thanks so much for fixing the security issue and make this available again. I installed this today and have a small issue. When someone leaves feedback, the system sends out 2 PMs right after each other. The first pm has a wrong link:


The second pm has the correct link:



Why is it sending that first pm with the wrong link (number replaces the domain name) and how can it be eliminated?

Sorry, not reproducible for me with vBulletin 4.1.10. Anyone else has this issue?

Baja 03-22-2012 04:41 PM

Thank you for the patch!

Might I suggest an increase in the version number: 2.8.2 RC2 -> RC3?

Also I previously deleted itrader_main.php. Can you confirm that was the only file affected? You see, Lynne mentioned a 2nd issue in the post below. I was unclear if he meant two problems in itrader_main.php or somethig else entirely.

https://vborg.vbsupport.ru/showpost....0&postcount=31

BirdOPrey5 03-22-2012 05:36 PM

Both issues were the same file and fixed.


All times are GMT. The time now is 08:42 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02246 seconds
  • Memory Usage 1,736KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (3)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete