vb.org Archive - [AJAX] vBShout v2.0

i uploaded everything box show fine but it keeps saying loading whats that all about.
i can type but it loads or show nuthing. i use firefox 1.5 if that helps u help me..thanx in advance

ive found it doesnt work on firefox v1.5 but does on v1.7

Chris M

12-04-2005 02:58 AM

Quote:

Originally Posted by Raptor

ive found it doesnt work on firefox v1.5 but does on v1.7

There is no 1.7...

Chris

Raptor

12-04-2005 03:22 AM

sorry i was thinking of mozilla

Dollah

12-04-2005 03:35 AM

Quote:

Originally Posted by Raptor

there is a security flaw if you direct link to vbshout.php - you can execute java and html

this should fix

Code:

// ---------------------------------------------------

// Shout

// ---------------------------------------------------

if ($_POST['do'] == 'shout')

{

$vbulletin->input->clean_array_gpc('p', array(

'shout' => TYPE_STR,





if you change that to



// ---------------------------------------------------

// Shout

// ---------------------------------------------------

if ($_POST['do'] == 'shout')

{

$vbulletin->input->clean_array_gpc('p', array(

'shout' => TYPE_NOHTML,

which is;

http://www.vbulletin.com/docs/html/m...estandards_gpc

changes..
# TYPE_STR - Trimmed String (No leading or trailing whitespace)
to
# TYPE_NOHTML - Trimmed String sent through htmlspecialchars_uni()

im sorry i'm new at this where do i find this at please

divided_by_fear

12-04-2005 04:12 AM

well its seems its in the file like that 2 times do we replace both of the 'shout' => TYPE_STR,
with 'shout' => TYPE_NOHTML,

Raptor

12-04-2005 10:20 AM

Quote:

Originally Posted by Dollah

im sorry i'm new at this where do i find this at please

in the vbshout.php of course

Raptor

12-04-2005 10:22 AM

Quote:

Originally Posted by divided_by_fear

well its seems its in the file like that 2 times do we replace both of the 'shout' => TYPE_STR,
with 'shout' => TYPE_NOHTML,

the hole is in the first one - no need to change anything else

as a test i looked at a couple of forums with shoutbox installed - it was very very easy to run custom javascript on their forums - this hole is actually very dangerous - all the users need to fix

divided_by_fear

12-04-2005 10:23 AM

would it hurt to change the second one ? cause i had changed mine already everything still works... just want to make sure its ok

Snake

12-04-2005 11:40 AM

Quote:

Originally Posted by Raptor

And what would happen if we don't?

All times are GMT. The time now is 10:52 AM.

Page 91 of 334

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.05368 seconds Memory Usage 1,744KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_code_printable (6)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (5)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: