vb.org Archive - Major Additions - QuoteIt!

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)

- - Major Additions - QuoteIt! - Quote Database (https://vborg.vbsupport.ru/showthread.php?t=135297)

Quote:

Originally Posted by Cap'n Steve (Post 1226410)

It looks like a problem with the headinclude template. Try editing and then saving it without changing anything. If it doesn't give you an error when saving, post the template here.

I don't understand, do you mean try editing the plugin and resaving it?

I managed to get it to work somewhat. It's not the right way but I will wait till someone else has this problem and wait for their solution.

I put this in the
Global Random Quote-global start plugin
----------------------------------------------------------------------------

if ($quoteitoptions['showrandomquote']) {
require_once(DIR . '/includes/functions_quoteit.php');
$showrandomquote = get_random_quote();
}

---------------------------------------------------------------------------

and then put full paths or urls in the templates. It works somewhat except for the star ratings.

http://www.allstarchat.com/PhotoPost/index.php

The quotes don't as nice as they do on the quotes.php page.

I meant the headinclude template. It's at least part of the problem.

Quote:

Originally Posted by Cap'n Steve (Post 1225604)

I've uploaded a new version that fixes a few small things.

rburns - Something's definitely wrong then, try redoing the edits and testing it in several places, like the post preview, the actual post, and a private message. I'm not exactly sure what hook to use for your listbox idea, the listbox just has to be generated before the new post template is shown. The one to insert bbcode needs to run before bbcode is parsed. Other than that, I'm not sure.

Ok, I'll give that a go.

Random Quote in the forum home is working perfectly though, lol.

Quote:

Originally Posted by Cap'n Steve (Post 1225604)

I've uploaded a new version that fixes a few small things.

thepub - Try the new files, or enable Javascript to use the AJAX voting.

[

How many new files are there? When I reinstalled it, I thought I was installing the new files?:confused: Also, my quoter does not look near as good as skorzguys attachment. I want to know what the heck I am doing wrong, it's so frustrating.l

Dear all,

I have just upgraded to the latest release, and note that a number of issues are still outstanding. I'll try to go through them as thoroughly as possible. Those marked with an * are what I would consider critical bugs or faults.

(a) AJAX editing of quotes will not save: When double-clicking on a quote to edit it, the AJAX editor appears as it ought; however, the save button does nothing, and there is no way to save the edit apart from clicking the 'Go advanced' button and going to the full editor. The cancel button and advanced buttons do work; it is simply the save function that does not work with AJAX. (I note that other AJAX functions on the vB board do work properly, so this is unique to the mod.)

* (b) Quotes submitted after using preview function do not submit: This has been a problem with the last release also, and remains now. If a user adds a quote and directly clicks submit, without previewing the quote, the quote is successfully sent to the moderation queue as it ought to be. If, however, the user first previews the quote, and then clicks submit from the quote preview screen, the quote is lost, and nothing is sent to the queue. On forums where users are used to previewing before posting, they intuitively preview the quotes before submitting -- and this has resulted in tremendous numbers of quote submissions from my members never getting through (I learned about a few from e-mail complaints; I then issued a general notice and learned how wide-ranging the problem is).

(c) Incorrect layout on quote preview screen: On the quote submission preview screen, the basic layout is a table with two columns: tags on the left and fields for revision on the right. The quote being previewed is displayed above these, and the layout should have the quote spanning both columns. However, it instead is crammed into the left-hand column alone, thereby making the preview screen look quite odd.

* (d) View All Quotes screen displays improperly in IE7: The view all quotes screen works fine in FireFox, but when viewed in IE the table containing all the quotations runs substantially off the right-hand side of the page, causing rather horrifying layout consequences. Oddly, it does not do this with the random quote function, for which the table lines up nicely in IE -- it is an issue solely with the View All Quotes function.

All these can be seen in action on the forum with this mod enabled here.

thepub - I uploaded a new version after your original post. You can check if your version is up to date by going to Manage Products in your admincp and selecting Check Version.

monForum - Thanks for the feedback. You're right about the previewing, I'll investigate that. About the AJAX editing, what browser are you using and does it give you any kind of error? The IE7 problem is specific to your style, but I'll take a look at it when I get a chance.

alrighty...I installed the latest files and it still hasn't changed. I've taken a couple screen caps to show you what I am looking at. Also, I still cannot vote for a quote, I get a 404 error.

The first pic is what you see on my forum homepage and the second pic is how it looks on my forum index and if I change the hook to global start.

The CSS files aren't loading in those screenshots, what do you mean you changed it to global_start?

Could you go to vBulletin Options, then Site Name / URL / Contact Details and tell me what Forum URL is set to? Also, in includes/functions_quoteit.php find this and tell me what you have on the first non-blank line below it:

PHP Code:


		
			
    else {

        $ref = false;

    }

Quote:

Originally Posted by Cap'n Steve (Post 1228000)

PHP Code:


		
			
    else {
        $ref = false;
    }

Quote:

if ($ref AND !$relative AND !preg_match('#^(https?|ftp)://#i', $ref)) {
$ref = $vbulletin->options['bburl'] . '/' . $ref;

forum url is set as http://www.theneighborhoodpub.com

I changed the hook to global start instead of forum home.
I readded the css files again and it still looks the same. If you want you can pm me for a test account ID and pw so you can see for yourself. :(

You can't just change the hook location, there's a global quote plugin in the extras folder to use if you want it enabled on any page. I don't know why it's still redirecting wrong. I'll keep working on it, but until then you could just use the AJAX voting.

what's AJAX voting? I will change the hook back, why does it look different from the others though? I want it to look as good as it is supposed to and to be uniform on all pages not nice on one page then on another looking not nearly as professional or slick you know?

AJAX voting is where it votes without reloading the page. You might have Javascript disabled in your browser, or it might be turned off in the vBulletin Options. There should be instructions for adding a global quote in the README file, it's just a plugin import.

I looked in my cp and I have AJAX something or other enabled. Why does my quoter look different from the others?

The CSS and Javascript files aren't being included in the page. Are you sure you're back to a default installation?

what do you mean default? If you mean revert the templates back then I would lose a LOT of other things and have to reinstall nearly everything I've installed. This is killing me I dont feel like I am getting anywhere. Ive followed every single instruction and it still looks cruddy on my forum but looks great on others, I can't vote for a quote and apparently I can't install it correctly despite using the "read me" and information from here.

When did it stop looking good? You shouldn't ever have to edit any of the plugins manually. As a workaround, you could edit the headinclude template and add all the external files included in the <head> of the quote_listquote template.

edit them how??? It never looked like the demo or others posted. I've uninstalled and reinstalled MANY times.

The same way you edit any template. Go to your admincp, then go to Styles & Templates, then Style Manager, then copy the stuff from from the <head> element in quote_listquote and paste it into headinclude. And judging by your earlier posts in this thread, it must have worked at some point, so can you remember when it first stopped looking right?

It worked before as far as being able to edit and vote on quotes. It has always looked like it does though.

When I upgraded to the newest version it screwed all my quotes. I deleted the tables and reinstalled and now whenever I make a quote it is just blank.

Any errors? If you're talking about the site in your signature, it's not currently installed.

A new error for you to look at, cap'n Steve.

Quote:

Warning: Cannot modify header information - headers already sent by (output started at /my/path/to/forum/htdocs/forum/includes/adminfunctions.php:3319) in /includes/functions.php on l

I noticed my 'submit' button & post counts (in postbit) were suddenly missing for no apparent reason. I uninstalled quoteit (v3.16) and then reinstalled.
As it the plugin was uploaded, it gave the above error.

I'm at a complete loss as to what it even means LoL

Could you tell me what's on line 3319 in includes/adminfunctions.php? It looks like there was an error installing.

Quote:

Originally Posted by Cap'n Steve (Post 1235097)

Could you tell me what's on line 3319 in includes/adminfunctions.php? It looks like there was an error installing.

Code:

$output_handler = @ini_get('output_handler');

The surrounding code:-

Code:

// ############################## Start vbflush ####################################

/**

* Force the output buffers to the browser

*/

function vbflush()

{

    static $output_handler = null;

    if ($output_handler === null)

    {

        $output_handler = @ini_get('output_handler');

    }



    if ($output_handler == 'ob_gzhandler')

    {

        // forcing a flush with this is very bad

        return;

    }

Hmm. I'm really not sure what's causing the output. Try installing it again, and make sure you get the whole error message. It looks like the previous one was referencing something in includes/functions.php.

Right this moment, i'm in the process of swapping hosts - but, when installing, the error messages & vanishes so quickly - i had to do it gawd knows how many times just to get that much copied LoL.
as soon as all is done here with the swapping hosts, i'll get onto checking the re-installation.

You could try just taking a screenshot.

Thanks Cap for a great mod.

I have installed it and made a few changes to the display which I hope is ok but I am not a coder as such but the attached screen shot is what I was trying to achieve and it works in both IE and Firefox.

The Quote_ListBit has been changed to:

Code:

 

<tr><td class="quoterow {$quoteclass}" align="left" id="quote{$quote['quoteid']}-{$globalcounter}">

<table>

<tr>

<td width="15%" align="Top">

 <if condition="$_REQUEST['do'] != 'preview' AND !$sidebar">

  Quote #:<a href="quotes.php?{$vbulletin->session->vars['sessionurl']}do=view&amp;quoteid={$quote['quoteid']}">{$quotedisplayid}</a><br>

  {$vbphrase['added_by']}: <a href="member.php?{$vbulletin->session->vars['sessionurl']}userid={$quote['userid']}">{$quote['username']}</a><div class="date">{$quote['date']}</div>

  <if condition="$quoteitoptions['reportquotes'] AND $quoteitpermissions['canreportquotes']">

   <a id="report{$quote['quoteid']}-{$globalcounter}" rel="nofollow" href="quotes.php?{$vbulletin->session->vars['sessionurl']}{$quotedisplay['querystring']}{$quotedisplay['orderstring']}&amp;page={$quotedisplay['page']}&amp;do=report&amp;quoteid={$quote['quoteid']}" onclick="reportQuote(event, {$quote['quoteid']});return false;"><img class="inlineimg" src="{$stylevar['imgdir_button']}/report.gif" alt="{$vbphrase['report_this_quote']}" /></a>

  <br>

  </if>

  </div>

 <else />

  <if condition="$sidebar">

   Quote #:<a href="quotes.php?{$vbulletin->session->vars['sessionurl']}do=view&amp;quoteid={$quote['quoteid']}">#{$quotedisplayid}</a>

  </if>

 </if>

</td>

<td>

<img src="{$stylevar['imgdir_misc']}/quotation-open.png" alt="“" width="60px" height="51px">&nbsp;

</td>

<td width="60%" align="center">

<span class="smallfont" id="quotetext{$quote['quoteid']}-{$globalcounter}">{$quote['quote']}

<div>

 <b><if condition="!empty($quote['author'])">

  <div class="author" id="author{$quote['quoteid']}-{$globalcounter}">- {$quote['author']}</div>

 </if>

 <if condition="$quoteitoptions['enablecontext'] AND !empty($quote['context'])">

  <span class="context" id="context{$quote['quoteid']}-{$globalcounter}">({$quote['context']})</span>

 </if></b>

</div></span>

</td>

<td>

<img src="{$stylevar['imgdir_misc']}/quotation-close.png" alt="“" width="60px" height="51px">&nbsp;

</td>

<td width="15%" align="right" valign="top">

  <if condition="($quote['userid'] == $vbulletin->userinfo['userid'] AND $quoteitpermissions['caneditownquotes']) OR ($quote['userid'] != $vbulletin->userinfo['userid'] AND $quoteitpermissions['caneditotherquotes'])">

   <a rel="nofollow" href="quotes.php?{$vbulletin->session->vars['sessionurl']}{$quotedisplay['querystring']}{$quotedisplay['orderstring']}&amp;page={$quotedisplay['page']}&amp;do=editquote&amp;quoteid={$quote['quoteid']}" onclick="editQuote(event, {$quote['quoteid']}, {$globalcounter});return false;"><img class="inlineimg" src="{$stylevar['imgdir_button']}/edit.gif" alt="{$vbphrase['edit_this_quote']}" /></a>

  <br>

  </if>

  <if condition="($quote['userid'] == $vbulletin->userinfo['userid'] AND $quoteitpermissions['candeleteownquotes']) OR ($quote['userid'] != $vbulletin->userinfo['userid'] AND $quoteitpermissions['candeleteotherquotes'])">

   <a rel="nofollow" href="quotes.php?{$vbulletin->session->vars['sessionurl']}{$quotedisplay['querystring']}{$quotedisplay['orderstring']}&amp;page={$quotedisplay['page']}&amp;do=delquote&amp;quoteid={$quote['quoteid']}" onclick="deleteQuote(event, {$quote['quoteid']});return false;">{$vbphrase['delete_this_quote']}</a> 

  <br>

  </if>

  <if condition="$quoteitpermissions['canmoderatequotes'] AND THIS_SCRIPT == 'quotes'">

   <input class="inlineimg" type="checkbox" name="modquotes[{$quote['quoteid']}]" id="modquotes{$quote['quoteid']}" value="y" onclick="selectQuote({$quote['quoteid']});"{$checked[$quote['quoteid']]} />

  </if>

</td>

</tr>

<tr>

<td colspan="5" align="center">

<if condition="$_REQUEST['do'] != 'preview' AND !$sidebar">

 <if condition="$quoteitoptions['ratings']">

  <span id="rating{$quote['quoteid']}-{$globalcounter}">{$ratethis}</span>&nbsp;&nbsp;

  <span id="stats{$quote['quoteid']}-{$globalcounter}">{$vbphrase['total_rating']}: {$quote['rating']} - {$vbphrase['votes']}: {$quote['votes']} - {$vbphrase['average']}: {$quote['average']}</span>

 </if>

 <span class="inlineimg unapproved" id="unapproved{$quote['quoteid']}-{$globalcounter}">

 <img src="{$stylevar['imgdir_misc']}/moderated.gif" alt="{$vbphrase['unapproved_quote']}" <if condition="$quote['approved']">class="approved" </if>/>

 </span>

</div>

</if>

</td>

</tr>

</table>

</td>

</tr>

The quote_randomquote has been changed to:

Code:

 

<if condition="!defined('QUOTE_FORM_ADDED') AND ($quoteitpermissions['caneditownquotes'] OR $quoteitpermissions['caneditotherquotes'] OR $quoteitpermissions['candeleteotherquotes'] OR $quoteitpermissions['candeleteownquotes'])">

<form action="quotes.php" method="post" id="sneakyform">

 <input type="hidden" name="s" value="{$vbulletin->session->vars['sessionhash']}" />

 <input type="hidden" name="do" value="edit" />

 <input type="hidden" name="quoteid" id="hiddenquoteid" />

 <input type="hidden" name="quote" id="hiddenquote" />

 <input type="hidden" name="author" id="hiddenauthor" />

 <input type="hidden" name="context" id="hiddencontext" />

 <input type="hidden" name="category[]" id="hiddencategory" />

 <input type="hidden" name="all" id="hiddenall" value="{$sneaky['all']}" />

 <input type="hidden" name="searchtext" id="hiddensearchtext" value="{$sneaky['searchtext']}" />

 <input type="hidden" name="searchauthor" id="hiddensearchauthor" value="{$sneaky['searchauthor']}" />

 <input type="hidden" name="searchcontext" id="hiddensearchcontext" value="{$sneaky['searchcontext']}" />

 <input type="hidden" name="sortby" id="hiddensortby" value="{$sneaky['sortby']}" />

 <input type="hidden" name="order" id="hiddenorder" value="{$sneaky['order']}" />

</form>

</if>

<table id="forumhome_randomquote{$quotecount}" class="randomtable tborder" cellpadding="0" cellspacing="0" width="{$stylevar['tablewidth']}" align="center">

<thead>

 <tr><td class="tcat">

  <div class="quoteheading">

   <if condition="$sidebar">{$vbphrase['quote']}

   <else />

   <a href="quotes.php?{$vbulletin->session->vars['sessionurl']}do=list"><if condition="$sidebar">{$vbphrase['all']}<else />{$vbphrase['random_quote']}</if></a>

   </if>

  </div>

  <div class="collapsebutton">

   <a href="#top" onclick="return toggleMultiCollapse('forumhome_randomquote');"><img id="collapseimg_forumhome_randomquote{$quotecount}" src="{$stylevar['imgdir_button']}/collapse_tcat{$vbcollapse['collapseimg_forumhome_randomquote']}.gif" alt="{$vbphrase['collapse_this']}" class="inlineimg" /></a>

  </div>

 </td></tr>

 

 <tr><td class="thead">

  Random Quote

 </td></tr>

 

</thead>

<tbody id="collapseobj_forumhome_randomquote{$quotecount}" style="{$vbcollapse['collapseobj_forumhome_randomquote']}">

{$quotelistbit}

</tbody>

</table>

<!--

Powered by QuoteIt! {$quoteitoptions['version']} 

{$quoteitdebug}

-->

The only thing now is how to hide the Moderation drop down box to show only for moderators - any suggestions?

Just like the last time I upgraded your mod, the mod no longer shows quotes and the 3 quoteit sheduled tasks became disabled. I re-enabled those 3, ran them and still does not show up. Any reason?

Try saving the QuoteIt! Options and a set of Usergroup Permissions. Like I said, you don't need to worry about the scheduled tasks.

I have already done both with usergroup permissions and quoteit settings. Still does not work.

iBaker - I don't see what you mean about a moderation dropdown. If you're talking about people being able to moderate quotes, you can just use a conditional to check $quoteitpermissions['canmoderatequotes'].

chadi - Well, if it's the site in your signature, I see the quotes just fine when I go to quotes.php. I don't see where you performed the edit on your index page, though.

I'm not talking about quotes.php I'm talking about the random quotes that should (and used to) appear on top of each forum home, which I double checked to make sure that $showrandomquote DOES appear in forumdisplay template, just where it always was and always worked before the upgrade.

$header
$navbar
$showrandomquote

This is the 2nd time this happened after an upgrade. What's the fix please?

I wish I knew what your problem was, but I can't think of anything. Do you know how you fixed it last time? Also, could you list all the other mods you have installed?

How can I make the main page of the Quotes show random quotes every time the page loads ?
It's really boring to have the old quotes always in the beginning and the newest in the last pages..

You could add &sortby=random to the View All Quotes link.

chadi - Go to the Plugin Manager and see if there are any plugins besides "Random Quote" set to use the hook "forumhome_start" and post their contents if you can. You can also try following the instructions in the README file for adding a random quote to any page.

I just wanted to make a note that this hack totally screwed up my forum after the latest vB upgrade. I had to disable it in order to get anything to work. Might wanna look into that. ;)

I was afraid of that. I'll look into it, but it might take a while, so if you want to keep using this hack you might want to install the patch rather than the full upgrade.

I'm at 3.6.7 pl1 and I haven't had a problem? Although, I'm not using all the features either.

Maybe being specific might be helpful since not all of it doesn't work, at least I'm not having trouble. You do have to re-edit your templates, but that's not a big deal.

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.02358 seconds Memory Usage 1,865KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (4)bbcode_code_printable (2)bbcode_php_printable (8)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (40)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: