![]() |
Another bug:
When posting, none of the WYSIWYG editor functions work correctly. All functions that refer to another file (i.e. misc.php for displaying the smiley list), return 404 errors. I'm not sure where it's coming from either. I can't see the full URL it's trying to access. |
Hi everyone.
I didn't see this answered anywhere already so I'm posting it now. I believe that I previously installed Deans hack and had the same problem so I uninstalled and installed this one and if I remember correctly the same thing happened. In my forumhome everything is rewritten properly except only the first LAST TOPIC title and author are rewritten. All others below are not. Please see example below. Any advice or pointers please let me know. https://vborg.vbsupport.ru/ |
Hmmm, I had installed this lastnight and woke to find my users complaining that when they clicked page 2 of a thread they would be brought to a completely different thread!! I checked and sure enough that's what was happening.
So even if I fix the fact that on the main page only the first threads are rewritten, apparently if there is more than 1 page of posts in a thread, there is a bug making it so you get transported to the wrong thread instead of page 2 of the right thread. Anyone else have this problem? I didn't see this in here already. |
Quote:
EDIT: Here's a function I used a long time ago to strip characters that could cause problems when I was scanning a URL. It might be useful for this extension. Code:
function make_url_safe($text) { |
Quote:
Quote:
Quote:
Quote:
Quote:
Quote:
Quote:
Quote:
|
Quote:
Quote:
endtofriend-arcade-release-2738.html And it's working just fine for me. Quote:
Quote:
Quote:
|
Quote:
Quote:
Quote:
|
Quote:
|
Anyone else having problems where it starts to randomly make the URL's bad?
Such as http://www.gsnforce.com/forum/commen...s/newreply.php Obviously that URL wouldn't exist...any explaination? |
Quote:
|
Was that directed towards me aftermath?
|
http://www.supercarforums.org/f-ferreri-13.html works but when you click on a thread in a subfolder, http://www.supercarforums.org/ferrer...eri-f60-4.html it doesnt work.
Any idea? |
Quote:
|
Quote:
|
Quote:
Quote:
Quote:
http://www.supercarforums.org/ferreri-13/newthread.php I can tell you did not apply all necessary template changes... |
Immortal, I'm on my sidekick right now, so I can't enable the rewrite, but yes it does write like that. It even makes it so that when I click to go to my forum index it rewrites it so it looks like this
http://www.gsnforce.com/forum/commen...ions/index.php |
Not bad, but most certaily could get better :)
- Fix only first rhread/etc. being rewritten - queries to get titles seems BAD The data is already avialable in Hooks threadbit_process, etc. - use it there - searches are not covered - could avoid the template edits by doing $headinclude = '<base href="' . $vbulletin->options['bburl'] . "\" />\n$headinclude"; |
Quote:
Quote:
Quote:
Quote:
Quote:
|
Quote:
But, those are all the threads being displayed, so this information already has been queried before, which makes this unnecessary overhead. The threadids, titless and forumids are available in Hoo0k threadbit_process for example (could also use threadbit_display if it's just for forumdisplay.php). So you could build an array there, and use this to lookup the titles in global_complete to save the query. Same goes for showthread.php, abd probably other pages as well. Especially querying the forum table from forum titles is wasteful, as the forumcache does contain this information - and is available on every page. Quote:
|
Quote:
Quote:
http://www.trilliummud.com/holos/gen...-out-1150.html I click on Thread Tools, Email this Page, and it fouls up. Quote:
Quote:
It gives me 404 errors when I start a new thread. Probably because something is wrong with this URL: http://www.trilliummud.com/holos/the.../newthread.php Guest posting is allowed at the above URL, try it for yourself with the WYSIWYG editor. It does NOT have issues when replying in a thread. The reply URL is not rewritten, thus it works fine. |
Add this line of code to your .htaccess if it doesn't already exist:
Code:
RewriteRule ^sendtofriend-(.*)-(.*).html sendmessage.php?do=sendtofriend&t=$2 [L] [high]* Immortal thinks he must be going mad[/high] |
Quote:
Code:
<base href="$vboptions[bburl]/" /> |
Immortal: I think I know what's causing these problems. It's the order of the rewriterules in the .htaccess file.
I turned on rewrite logging for my Apache server, and saw this entry when i tried to send a thread to a friend: rewrite sendtofriend-trillium-clothing-shop-1090.html -> showthread.php?goto=1090&t=shop So I looked at the rules in the .htaccess and saw this rule about midway through: RewriteRule ^(.*)-(.*)-(.*).html showthread.php?goto=$3&t=$2 [L] That should be the LAST Rewriterule in the .htaccess file, so it catches anything that falls through the other rules. I moved it to the bottom of my .htaccess and it fixed the problem with sending email to a friend. So that problem is resolved. Now to figure out the WYSIWYG problem. Edit: I found proof that the editor problem might be related to Internet Explorer. I loaded Firefox, and tried a New Topic, and everything worked (smilies popup, attachment manager, etc..) In IE, the smilie popup and attachment manager does NOT work. I did some research and I'm guessing it has something to do with the <base> tag. Maybe because IE6 is not fully XHTML compliant? Firefox understands it and is fine. Is there a workaround? |
Quote:
BUT (ya you knew there had to be one :D ) I am having this very same issue, is there some kind of solution? or trouble shooting process or.. or.. Thanks for the hack and your time :cool: |
Quote:
Previous page has a solution. https://vborg.vbsupport.ru/showpost....&postcount=316 Replace the plugin with that code he posted, it should resolve the multiple page problem and the not rewriting past the first forum issue. |
Quote:
|
Quote:
Thanks for that, the problem of only the first url being rewitten seem to be gone However, I still am having the issue of the 2nd page of a thread being sent off to some other thread, And another issue if I am on the main index page (forum home) and click the latest post link for any forum the url is not rewritten? Thanks |
hi guys
ive used this hack onnmy old forum with no problems but on my new forum this plugin is making i threads go to ~"page cannot be displayed" yet as soon as i disable the plugin it works fine any ideas? |
Quote:
Quote:
|
|
And you're sure mod_rewrite is enabled?
|
yes ive used your hack before with no problems, just seems to be playing up now
|
ill enable your hack now and try going directly to a thread
|
<a href="http://www.extreme-mobile.com/introductions/t-here-we-go-again-14.html" target="_blank">http://www.extreme-mobile.com/introd...-again-14.html</a> Works just fine?
|
<a href="http://www.extreme-mobile.com/showthread.php?goto=newpost&t=10" target="_blank">http://www.extreme-mobile.com/showth...o=newpost&t=10</a>
this say page can not be displayed yet as soon as i disable the product it goes to the post fine |
ok ive just worked out taht if you go in to the post by clicking the forum main title then selecting the post it works how ever if you click the post from forum display directly it hangs and wont show
|
Whoa, I think you enabled something that shouldn't be enabled. Make sure you are only enabling vRewrite in global_complete and vRewrite WOL in the who's online hook (I forget and I'm too lazy to look).
|
Quote:
|
vBulletin ACP->Plugin Manager
There should be 3 plugins that concern vRewrite. Make sure only vRewrite (it is under the global_complete hook), and the vRewrite WOL (under online_preprocess or something like that). Then there is a 3rd one, disable this. This should not be enabled as it does not work correctly currently. |
[Immortal,
Thanks for the response but when i apply the code change as is outlined in post 300 it fixes everything except the page 2 of a thread being sent to some other thread. So I over wrote that with the chance in post 316 and that gives me an error of Code:
Parse error: parse error, unexpected '}' in..../www/html/forums/includes/functions.php(4320) : eval()'d code on line 606 |
All times are GMT. The time now is 08:26 PM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
![]() |
|
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|