vb.org Archive
Page 9 of 22 « First 78 9 101119 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin.org Site Feedback (https://vborg.vbsupport.ru/forumdisplay.php?f=7)
-   -   To enforce a valid coding style in the community! (https://vborg.vbsupport.ru/showthread.php?t=93400)

Revan 08-02-2005 11:23 AM
You are missing the majority of my post. I think that message to be sent to pariticipants of the validation system was well written and not hurtful in any way.
After all, it IS opt-in, and people who choose never to opt-in just have to face having their hacks marked as "Unvalidated" (or similar). It's their choice.

Paul M 08-02-2005 11:24 AM
Five pages already, and for what ? This basically seems to be a few people who think they are better than everyone else wanting to mark down those who they think are not "good enough". What on earth is "php valid". If it works then it's valid - and "vB hackers will be encouraged to code properly" ?? properly in whose opinion ? Most people write hacks for their own boards and then release them here for others. When I do this I write in my style, no one elses, and I sure as hell will not put up with a "Warning" tag because it doesn't happen to suit someone else. Such labels will not help anyone, they will cause division and drive people away to release their work in more friendly places.

Boofo 08-02-2005 11:26 AM
Well, I'm not for it if you guys are going to publicly use labels of any kind. It's just not right, no matter how you look at it. And I for one won't be releasing any more hacks here if that happens. 'Nuff said. ;)

Revan 08-02-2005 11:27 AM
This is funny, phpBB has a much stricter version of what we are proposing, yet I don't know of as many non-official major hack forums as there's vBulletin ones.
Maybe vB coders have been pampered for too long...

Logikos 08-02-2005 11:28 AM
Quote:
Originally Posted by Paul M
Five pages already, and for what ? This basically seems to be a few people who think they are better than everyone else wanting to mark down those who they think are not "good enough". What on earth is "php valid". If it works then it's valid - and "vB hackers will be encouraged to code properly" ?? properly in whose opinion ? Most people write hacks for their own boards and then release them here for others. When I do this I write in my style, no one elses, and I sure as hell will not put up with a "Warning" tag because it doesn't happen to suit someone else. Such labels will not help anyone, they will cause division and drive people away to release their work in more friendly places.
Exactly! Why should I indent my code? Because vBulletin does? Why should I add comments? Because vBulletin does? I will not recode my code to the standards to some team who thinks there code is better or easier to read. 80% of installers don't look at the code like that, they just follow instructions.

Whos to say that this is not valid
PHP Code:
$hacks = $DB_site->query("
        SELECT *
        FROM " . TABLE_PREFIX . "forum
        WHERE forumid = $forumid
"); 
Or that this isn't valid
PHP Code:
$hacks = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "forum WHERE forumid = $forumid"); 
Both do the same thing, one is just eaiser to read.

sabret00the 08-02-2005 11:28 AM
Quote:
Originally Posted by Revan
You are missing the majority of my post. I think that message to be sent to pariticipants of the validation system was well written and not hurtful in any way.
After all, it IS opt-in, and people who choose never to opt-in just have to face having their hacks marked as "Unvalidated" (or similar). It's their choice.
all i'm saying is to get my support for something like this is;
PHP Code:
if (automated) // my preference for the system
{
echo "do not mark at all unless it passes the validation and then marked \"validated\"";
}
else
{
echo "all 'validators' must have a record of helping the needy before they go about putting down the people that make this site what it is";
} 
:)

Boofo 08-02-2005 11:30 AM
I'll have the number 2, Sabe, to go. ;)

Logikos 08-02-2005 11:30 AM
Quote:
Originally Posted by sabret00the
all i'm saying is to get my support for something like this is;
PHP Code:
if (automated) // my preference for the system
{
echo "do not mark at all unless it passes the validation and then marked \"validated\"";
}
else
{
echo "all 'validators' must have a record of helping the needy before they go about putting down the people that make this site what it is";
} 
:)
[sarcasm]Your wrong! Its $automated Now don't code anymore cause its not 'valid php' :p[/sarcasm]

Revan 08-02-2005 11:31 AM
Still you are saying "putting down". You seem to be unable to understand how it's gonna be done, in spite of my best attempts at showing you a nice, friendly way of doing it. That is highly annoying.

And I think that such a position should be awarded based on skill and actual familiarisation with the things they would be working with, rather than how much time they have spent in the help forums.

Boofo 08-02-2005 11:31 AM
oooohhhhh, LW used the sarcasm tags. I'm telling! ;)


All times are GMT. The time now is 07:09 PM.
Page 9 of 22 « First 78 9 101119 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01191 seconds
  • Memory Usage 1,750KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_php_printable
  • (3)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete