vb.org Archive - VbTeams/Clubs Hack

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.0 Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=33)

- - VbTeams/Clubs Hack (https://vborg.vbsupport.ru/showthread.php?t=72448)

Quote:

Originally Posted by yoyoyoyo

the first one uses:

PHP Code:


		
			
$bbuserinfo[teamid]

and the second one uses:

PHP Code:


		
			
$userinfo[teamid]

Blind me, I am sorry! I knew it was too late to check these things out.

new version will be realsed soon with all of the fix's....

Quote:

Originally Posted by eXtremeTim

This is simple to fix I just fixed it on my site.

do the following

Find in member.php

PHP Code:


		
			
$bbteam =  $DB_site->query_first("

            SELECT *

            FROM " . TABLE_PREFIX . "teams

            WHERE teamid = $bbuserinfo[teamid]

        ");

Replace with

PHP Code:


		
			
$bbteam =  $DB_site->query_first("

            SELECT *

            FROM " . TABLE_PREFIX . "teams

            WHERE teamid = $userinfo[teamid]

        ");

Miz if you want I can release all the changes I did to my files to your for your next version so that you have a load optimized version. My sites url is http://www.extremechatforums.com/forums/index.php I cleaned up the code on forumdisplay using left joins. I cleaned up the code for showthread (required changes to showthread and functions_showthread) I also cleaned up the not in team list which now runs at 11 (4 of which are from some stats tracking code im using on my site so its really 7 queries) queries on my site no matter how many users as displayed.

Could you please release those changes? I want to apply this hack to my site, but I do not have the time to optimize it.

Thank you.

Quote:

Originally Posted by eXtremeTim

This is simple to fix I just fixed it on my site.

do the following

Find in member.php

PHP Code:


		
			
$bbteam =  $DB_site->query_first("

            SELECT *

            FROM " . TABLE_PREFIX . "teams

            WHERE teamid = $bbuserinfo[teamid]

        ");

Replace with

PHP Code:


		
			
$bbteam =  $DB_site->query_first("

            SELECT *

            FROM " . TABLE_PREFIX . "teams

            WHERE teamid = $userinfo[teamid]

        ");

Although, it is again one of those times that my mind does not function pretty well, I do not think that this fix is the proper one. bbteam is the team to which a team admin is inviting the user, not the team to which the user belongs.

A more appropriate fix would be the following in member.php:

Find:

PHP Code:


		
			
$bbteam =  $DB_site->query_first("

            SELECT *

            FROM " . TABLE_PREFIX . "teams

            WHERE teamid = $bbuserinfo[teamid]

Replace that with:

PHP Code:


		
			
if ($bbuserinfo['teamadmin'])

{

$bbteam =  $DB_site->query_first("

            SELECT *

            FROM " . TABLE_PREFIX . "teams

            WHERE teamid = $bbuserinfo[teamid]

        ");

}

With this mod, if the user of the program is a team admin, he can invite the member whose profile he is viewing, to his team.

My 2 Eurocents only.

Has anyone tested the chat function? In my system, it works OK with Firefox Mozilla, but not with Internet Explorer (version 5). It does not refresh properly.

Also, I have found several small bugs. For example, when a user asks to be removed from a team, he is not set to teamid='1' but to no team id. This creates problems.

Features I would like to see implemented:

- a report with the status of the join requests.
- Some sort of control panel, where the admin can define if he wants a team avatar, or an admin message (the scrolling thing), or the team reputation (I haven't managed to understand how it goes up and why) etc.

I am anxiously waiting for the new version, as it is at the moment, I am not sure I want to install it on my live system.

Quote:

Originally Posted by sv1cec

first thank you for reporting bugs
2nd - i as coder of the hack not recommand you to install the hack if you have installed it yet, this days im working on next version of the hack which will include new featurs (like team privte forum) and bug fix's
also i might replace the privte chat with something else with less bugs
a report is good idea i can tell you that ill add it
about the last thing - i didnt exscaly got what you wanted to say but you can edit any team options via team admin area..

yours MiZ.

Quote:

Originally Posted by miz

Miz,

First of all, very nice hack, I really like it. Although my needs are for a far less sophisticated system (all I want is a "club" list of selected few from my members), this is just great.

As for the bugs, they are not many, but they exist. Let me point out one more, in your instructions, you say somewhere to add something above a certain line. That line exists in several places in that file. The user who tries to install the hack, does not know where to place it. Of course, users with coding experience will figure it out, but those without the knowledge will be hard pressed to find the answer.

You do not have to thank me for reporting bugs, it's the least I can do, to help you out, I know, I have a hack of my own here, and I know how important user's input is. Unfortunatelly, I haven't kept a log of all the small changes and edits I made, although I reported one here.

As for the chat feature, I do like it. I can't understand why it does not work with Internet Explorer, it works like a charm with Firefox Mozilla, maybe it has something to do with IE's security settings, I do not know, but I wouldn't like to see it go, it's a nice feature.

Finally, let me explain the last point of my previous post. What I would like to see, is a page, where the administrator can select which features of the hack he would like to use. For example:

Do you want to use the chat feature : Yes/No
Do you want to use a scrolling admin message : Yes/No
Do you want to use the reputation feature : Yes/No
Do you want to use a Team's avatar : Yes/No
Who can see the links to the Teams : All/Mgm+User

These options can be saved in a separate table, and according to these, the hack can show the appropriate sections. Check out the following picture, it comes from my Advanced Warning System and it is exactly that, a page where the user selects which features he would like to use.

https://vborg.vbsupport.ru/attachmen...chmentid=21859

The report would be a nice addition, especially for users who plan to use the "Invite" feature. Also, a list of the pending applications (users who have asked to join a team) would be nice too.

Well, I told you, I am anxiously waiting for the new release. At the time, I am playing with the hack in a test system. If I come up with some other bugs, I'll let you know.

Rgds
---------

John

do we need to uninstall this version in order to install the new version?

and when u gonna release the new version?
Thanks

sv1cec - thank you for feed back i will surly consider your sujestions
kevinnguyen - you wont be able to remove old hack cuse i will provide and update script
and the next version will rls when i will finish to code and to test it.

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (8)bbcode_php_printable (5)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01832 seconds Memory Usage 1,774KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (8)bbcode_php_printable (5)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: