![]() |
Quote:
Just my personal opinion and a suggestion or advice. Please keep the code hacks and modifications to a minimum, more code change in each hack is not good, start running into problems and it makes it harder to do VB version upgrades at a later date. I learned this from dealing with PHPBB. Too many modifications just to get a default installation of PHPBB to do what you want it to do, im sure Vbulletin could go the same way with the code hack issues if you modify it far enough. What Im trying to say is lets not add anymore code changes to a hack then what the hack was originally designed to do, that way we keep the code modification to a minimum. If we want to add another feature and it really doesnt belong with that original hack, (restricting user name lenght in a user name change/user id history for example, especially if its already included in the admin cp) then create a seperate hack just for that feature. Some people may not want that "extra" feature included in the main hack thus reducing the amount of code alterations on their board. The less code modification the better. :) Doug |
I must say that i totally agree with this. If i get a request that doesn't fit the idea of the original hack, or would make the core hack unneeded difficult/heavy, or would only be used by a few users, then i would deny that request. (You can even check on some of my hacks where i have done this).
Also hacks should try to rely on basic standard vB settings. If there is a standard setting to limit the username length (and there is), and my hack would not follow that 'rule', i would change my hack to follow the limits set by standard vB (i didn't have time to double check yet). If it does follow the standard settings, but a second limit for usernames set by my hack was requested (as it seems here), then i will deny that. |
I just installed this hack on my development board again and tested this issue. My hack follows the username length limit as set in AdminCP->vBulletin Options->User Registration->Maximum Username Length.
If you want to limit the length of usernames, just set this setting. This will also restrict usernames when new members register. No need to change my hack. |
Regarding the cpnav problems in conjunction with my Enhanced ACP Navigation Hack:
By setting mater="true", your XML effectively becomes the parent of navgroup users, if it is loaded before cpnav_vbulletin.xml - which is the case on UN*X-systems, but not on Windows: Code:
[110] => Array You should not set master, if you are adding to existing groups. Though I will modify my code to add an additional check for known vBulletin groups. |
Hmm a valid point. Will change this in the next version.
|
Ok there is a problem. I ran Update Usernames in the Update Counters section of the admincp, and guess what it did? It marked every single member on the board that I changed their name. The log in profiles just say changed from and to the same name, but recorded a log showing I did it.
Also it looked bad on the addon whats going on bit where it shows recent changes. It not right here.... Any fix for this? |
Quote:
|
Sorry i just returned from a trip out of the country. I saw your reply in my mail and have already a fixed version for it. Will try to zip it up and release later today.
To provide also cleaning instructions to remove those history records that where added by updating the usernames, it would really help me if you could supply me with a dump of your history table (mh_unm_history) and you user table (only need the userid & username columns i guess. |
Version 1.04 released.
Changes: 23-12-2005 v1.04 - Changed master="true" to false in cpnav file. - Fixed bug where history was generated when running Update User Names from Update Counters v1.03 - Changed the size of the 'mh_unm_changelimit' & 'mh_unm_changelimit' columns in the usergroup table from TINYINT to SMALLINT to support values > 255 |
You know what would make this hack perfect? If you could make it only for users who have been registered for a certain amount of time.
|
All times are GMT. The time now is 02:24 AM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
![]() |
|
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|