FYI db->query is depreciated as of 3.6. You should be using db->query_read and db->query_write. Not that this changes functionality but sticks with the vBulletin coding style.

I also noticed that you don't free the result of the database queries with db->free_result. db->query_first should be used in a number of places since you only want the value of one field. This will make remove the need for db->fetch_array and db->free_result.

Please use db->escape_string instead of addslashes. addslashes doesn't catch all cases nor does it take into account the SQL connection encoding.

For the datediff consider db->query_first_slave as we don't need to be hitting the master db server with that query.

rsw686 thanks for the heads up :)

Excellent with 4.0.1 Thank you.
I had similar experience with 3.84
J.R.

I installed this, on multiple forums, and it's working great! I've had a couple spammers slip through, but it has drastically slowed them down.

I do have a problem though, and I don't know what's causing it. Many of my members are now complaining that they need to log in daily, or sometimes even every time they visit the forum now. I don't know how it could be related, but it started afer installing this plug-in. Anyone else seen this? Anyone have a clue how to fix it?

I'm running 3.84 patch level 2

Gotta say, thanks!
In 2 days, this plugin caught 88 spammers trying to register!

As of today I have had 25+ new members complain that the plugin isn't working. The stop forum spam database check step doesn't complete and registration is blocked.

I wonder if we're blocked, the database down, or the plugin needs an update or whatever?

I for now have turned off this mod so I do not lose 50 potential registrations in a day from valid members.

There are two settings in case of connection errors: "Query Connection Errors" (What should happen if the remote connection times out when querying the new registration?) and "Data Fetching - Cache" which help to identify these type of errors.

I've just installed StopForumSpam. It was super-easy. After carefully studying what it does, I realized it essentially automates most of the successful bot-blocking strategies I've been using manually here for over 2 or 3 years. Wish I'd found this add-on l-o-n-g ago. Duhhh!

It has blocked a dozen spambot registrations in its first hour. I have every expectation it will eliminate 99% of all spambot registrations and cut the risk of spam-posts to a minimal level. I suspect I'll be able to stop moderating new registrations almost completely. We'll see. But that's my guess.

Thanks a lot! :)

Here's a very minor bug in vbstopforumspam.php

Database error in vBulletin 3.8.2:

Invalid SQL:

SELECT * FROM vb3_vbstopforumspam_log AS logs

ORDER BY ip ASC, date DESC
LIMIT 0, 15;

MySQL Error : Unknown column 'ip' in 'order clause'
Error Number : 1054
Request Date : Monday, January 25th 2010 @ 04:50:55 PM
Error Date : Monday, January 25th 2010 @ 04:50:56 PM
Script : http://myforums.com/forums/admincp/v...erby=ip&page=1
Referrer : http://myforums.com/forums/admincp/v...am.php?do=view
IP Address : xx.xxx.xxx.x
Username : webmaster
Classname : vB_Database
MySQL Version : 5.1.30

The column-name reference in this query should be to "ipaddress" and NOT to "ip". I fixed it here. But it should be fixed in the released code too.

Unistalled, the server seems to be down most of the time now causing no one to be able to register. This works really well!
https://vborg.vbsupport.ru/showthread.php?t=183917