vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Administrative and Maintenance Tools - Import External Images (https://vborg.vbsupport.ru/showthread.php?t=253309)

Hostboard 12-13-2019 12:31 AM

The plugin in itself is not insecure as I do not believe that the intention of scanning files for malicious code was ever its intent. That being said you can then say vBulletin is not secure in that the way it allows you to have attachments and upload avatars. There is a known exploit:

The following issues exist in vBulletin itself, reported by us to vBulletin support over 60 days ago(years now). Since vBulletin has not patched or disclosed the issues since that time, we now do so here:
An image decompression bomb vulnerability exists when vBulletin Options > Message Attachment Options > Resize Images = Yes. Disable it to protect your site.
An image decompression bomb vulnerability exists when allowing user uploads for avatars and profile pictures. To protect your site, change your forum's permissions so that users cannot upload custom avatars or profile pics.
An image decompression bomb vulnerability exists when using ImageMagick for images and allowing uploads. Currently known issues are for PDFs and TIFFs; however, because the filename of the incoming upload is not trustworthy, removing entries from the Attachment Manager or changing Attachment Permissions are not viable options. The following mitigation options exist:
Change vBulletin Options > Image Settings > Image Processing Library = GD, OR
Change your forum's permissions so that no users can upload anything.

In an attempt to figure the best way to resolve this sort of thing would be to update the Fractalizer Plugin to work with VB 4: https://vborg.vbsupport.ru/showthread.php?t=187482

Hostboard 02-21-2020 01:10 PM

Any fix for PHP 7.1+

PHP Fatal error: [] operator not supported for strings on line 324 in /home/........./public_html/forums/includes/cron/iei_cron.php

shka 02-21-2020 01:54 PM

Edit
PHP Code:

if(!count($image_tags))
{
    
$image_tags[] = 'img';


to
PHP Code:

if(!count($image_tags))
{
$image_tags = [] ;    
$image_tags[] = 'img';


Or better to
PHP Code:

if(!count($image_tags))
{
    
$image_tags = ['img'];


so the following code line numbers are the same. I expect there are more than one fatal errors in.


Edit:
former edit of line 342 was stupid. Deleted

Hostboard 02-21-2020 04:51 PM

Thank you for the quick reply :)
File edits made. Will check the log file latter on tonight and see if anything pops back up.

Still getting (1) error with this...

NOTICE: PHP message: PHP Fatal error: syntax error, unexpected ';', expecting ']' on line 334 in /home/........./public_html/forums/includes/cron/iei_cron.php"

This did not work...

Code:

if(!count($image_tags))
{
    $image_tags = ['img'];
}

Trying the first notation...

y2ksw 02-22-2020 07:58 AM

I'm very unhappy with PHP 7, which converts the untyped language in a typed one. Having said this, you may test

if (isset($iei_ignore)) ...

in order to see if the variable was actually set, or better, use a different variable to read the value, and use

$iei_ignore = array();

beforehand. E.g.:

$iei_ignore = array();
$x_ignore = explode("\r\n", $input_ignore);
if (!is_array($x_ignore))
{
$iei_ignore[] = $bburl;
}
else
{
$iei_ignore = $x_ignore;
}

shka 02-22-2020 08:43 AM

Quote:

Originally Posted by Hostboard (Post 2602119)
Still getting (1) error with this...

NOTICE: PHP message: PHP Fatal error: syntax error, unexpected ';', expecting ']' on line 334 in /home/........./public_html/forums/includes/cron/iei_cron.php"

This did not work...

Code:

if(!count($image_tags))
{
    $image_tags = ['img'];
}


Then you made a typing error. "syntax error, unexpected ';', expecting ']'" is not a php7 error or so. And you ar sure line 334? the qoted lines are in 324. Your quoted code can't be your inserted code.

But of course you can use the other version or from y2ksw (but the if conditions there is wrong I think)

y2ksw 02-23-2020 06:53 AM

$image_tags = array('img');

As far as I know, implicit arrays are not allowed for a long time by now, but explicit arrays like above, must work.

Hostboard 04-24-2020 10:15 AM

Is there anyway to get this to support a URL such as:

Code:

https://scontent-lax3-1.xx.fbcdn.net/v/t1.0-9/fr/cp0/e15/q65/94475070_10213603321997797_6910232200327725056_o.jpg?_nc_cat=108&_nc_sid=ca434c&efg=eyJpIjoidCJ9&_nc_oc=AQlsUa106dvp0CMIRD8nGvIE-2Hc9WyOAf3nmJ0ANiOGTbUAnpGlycnsQFC5Sbpeq-4zdhQUmJqUb9BVRXAP4Uvg&_nc_ht=scontent-lax3-1.xx&_nc_tp=14&oh=ee495fa093d4139e821daa867b450a8e&oe=5EC82DE0
If I try it comes back as invalid as I suspect it is looking for an image extension such as .jpg, .png, etc.

djbaxter 04-24-2020 10:23 AM

I was going to suggest you strip off everything after the .jpg extension so it would just be this:

Code:

https://scontent-lax3-1.xx.fbcdn.net/v/t1.0-9/fr/cp0/e15/q65/94475070_10213603321997797_6910232200327725056_o.jpg
but that URL gives an error: Bad URL timestamp

Maybe because it's a CDN, possibly a private CDN?

Hostboard 04-24-2020 10:28 AM

Quote:

Originally Posted by djbaxter (Post 2602676)
I was going to suggest you strip off everything after the .jpg extension so it would just be this:

Code:

https://scontent-lax3-1.xx.fbcdn.net/v/t1.0-9/fr/cp0/e15/q65/94475070_10213603321997797_6910232200327725056_o.jpg
but that URL gives an error: Bad URL timestamp

Maybe because it's a CDN, possibly a private CDN?

Not sure, but it should be able to pull down the image or at least I was hoping it would...


All times are GMT. The time now is 03:13 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01902 seconds
  • Memory Usage 1,752KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (5)bbcode_code_printable
  • (3)bbcode_php_printable
  • (2)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete