vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - iTrader v2.8 - Powerful Rating System (https://vborg.vbsupport.ru/showthread.php?t=232044)

entertain 08-17-2011 08:27 AM

Hello Baja,

i can reproduce both of your issues. I will try to fix them. I've already spent a lot of time in finding the reason for the second one, but i didn't find anything. I'll give it an other try!

And thank you for your very kind donation!

NarutoFTW 08-17-2011 05:57 PM

Quote:

Originally Posted by entertain (Post 2234429)
Hello Baja,

i can reproduce both of your issues. I will try to fix them. I've already spent a lot of time in finding the reason for the second one, but i didn't find anything. I'll give it an other try!

And thank you for your very kind donation!

Entertain, the 'Deal Thread URL is invalid' with vBSEO url format was never fixed, juts letting you know.

Guthatron 08-17-2011 06:28 PM

VERY nice work on this mod!! Thank you so much

R.Solutions 08-18-2011 12:12 PM

is there a way to add a border around the itrader feedback score as well as bold certain part of the text. im stumped.

Baja 08-18-2011 02:37 PM

Quote:

Originally Posted by entertain (Post 2234429)
Hello Baja,

i can reproduce both of your issues. I will try to fix them. I've already spent a lot of time in finding the reason for the second one, but i didn't find anything. I'll give it an other try!

Entertain, can you explain how to reproduce the blank white page? I recently copied the site to a new server and noticed the problem is not occurring on the new box. The db, phrases, templates, and files are all identical, so I was surprised the problem appears to have resolved itself. Three differences that come to mind are: APC, vBSEO, and Sphinx (digitalpoint plugin) have not been setup on the 2nd server yet.

sevenmix 08-19-2011 05:26 PM

It would be nice that in version no. 3, itrader could alter the usergroups like the promotions system of vbulletin.

Baja 08-23-2011 01:35 AM

Entertain, I figured out what's causing the blank white page -> Digital Point Sphinx Search v1.2.2 (Note: v1.2.1 works fine).


When the DP Sphinx v1.2.2 plugin is enabled, iTrader generates the following error when someone submits a feedback:
Quote:

PHP Fatal error: Class 'vB' not found in /home/user/public_html/includes/class_dm_pm.php(706) : eval()'d code on line 1

Here is a list of changes in DP Sphinx v1.2.2:
Quote:

  • Fixed cosmetic issue with search results that have a title that contains unicode characters
  • Better handling of non-standard latin characters (makes German, Spanish, Swedish and Norwegian work without needing setting)
  • Changed how delta indexes are threaded within distributed indexes
  • Fixed issue where a specific server setup could cause delta indexing of article comments to fail
  • Fixed rare issue where a delta index would be ignored as part of a distributed index
  • Sorting threads or posts by number of views works properly
  • Searching posts for all threads started by a user give correct results
  • Override $search_core class if using vBulletin 4.1.5+ (better way to disable vBulletin's search result cache)
  • Added setting to disable searching of private messages
  • Better handling of distributed indexes for non-suite installations
  • Added word stemming/morphology support (a search for "fly" will return "flies" and "flying" for example)
  • Fixed issue when searching for threads started by a specific user within a specific forum


P.S. Not sure if it's related, but here's an old bug report mentioning the "Class 'vB' not found" error:
https://www.vbulletin.com/forum/proj...?issueid=32002

entertain 08-24-2011 06:57 PM

Quote:

Originally Posted by Baja (Post 2236840)
Entertain, I figured out what's causing the blank white page -> Digital Point Sphinx Search v1.2.2 (Note: v1.2.1 works fine).


When the DP Sphinx v1.2.2 plugin is enabled, iTrader generates the following error when someone submits a feedback:



Here is a list of changes in DP Sphinx v1.2.2:



P.S. Not sure if it's related, but here's an old bug report mentioning the "Class 'vB' not found" error:
https://www.vbulletin.com/forum/proj...?issueid=32002

Please try to open itrader_feedback.php and change the following line:
Code:

$vbphrase['itrader_pm_message_x'] = construct_phrase($vbphrase['itrader_pm_message'], $itrader['phrase_rating'], $vbulletin->userinfo['username'], $vbulletin->options['bburl'], $userinfo['userid']);
into
Code:

$vbphrase['itrader_pm_message_x'] = construct_phrase($vbphrase['itrader_pm_message'], $itrader['phrase_rating'], $vbulletin->userinfo['username'], $this->registry->options['bburl'], $userinfo['userid']);
Fix is integrated in my current developement build.

Baja 08-25-2011 06:58 AM

Thanks for the quick reply! I tried the "$this->registry" tweak, but received the following error:
Quote:

Fatal error: Using $this when not in object context in /home/user/public_html/itrader_feedback.php on line 292


However, Shawn with DigitalPoint mentioned some changes in 4.1.5:
Quote:

I suspect vBulletin removed one of the places they were initializing the bootstrap framework (which is what also implements the class auto-load method). The bootstrap framework SHOULD be loaded always, but for some reason it's not and they instead load it in like 90 different places "as needed".

Vote for this to get it always loaded and you will make programmers happy.

http://tracker.vbulletin.com/browse/VBIV-8198

I'll wrap up an updated Sphinx package in the morning (it's 4am now, and I need to go to bed before I fall over) that just does what the test plug-in I had to make does... that way others don't run into the issue. Terribly annoying though if you ask me... shouldn't even need to happen. And terrible they decided to NOT load it in 4.1.5, but they were loading it in earlier versions.


The Sphinx hook that's conflicting (pmdata_postsave) contains the following code:
PHP Code:

require_once(DIR '/includes/class_bootstrap_framework.php'); 
vB_Bootstrap_Framework::init(); 



^Adding that code to the "REQUIRE BACK-END" section of itrader_feedback.php resolves the problem:

FIND:
PHP Code:

require_once(DIR '/itrader_global.php'); 


ADD BELOW:
PHP Code:

require_once(DIR '/includes/class_bootstrap_framework.php'); 
vB_Bootstrap_Framework::init(); 


entertain 08-25-2011 07:28 AM

Okay, thanks, then I will not integrate this fix. Everyone who use this mod can embed it by himself.

I was able to fix this issue why error messages are not shown. Update is coming asap.


All times are GMT. The time now is 04:36 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02107 seconds
  • Memory Usage 1,757KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (3)bbcode_php_printable
  • (7)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (3)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete