vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Board Optimization - United-Forum CSS Sprites - ludicrous speed - NOW! (https://vborg.vbsupport.ru/showthread.php?t=266696)

DNCL 08-09-2011 12:52 PM

Thanks :)

there is a similar issue in WOL

https://vborg.vbsupport.ru/external/2011/08/58.jpg

https://vborg.vbsupport.ru/external/2011/08/59.jpg

Osbes 08-09-2011 01:21 PM

Hello DCNL,

thanks, this is a similar problem.

vBulletin defines a css-rule like
Code:

.columnsort a, .columnsort span
there, but since we replace an img with a span, this rule also changes the behavior with our sprite.

A quick fix would be to rewrite it to
Code:

.columnsort a, .columnsort > th > span
but i will think about a better solution for this and implement it in 0.8.0 :)

If there will be more such problems i will release an additional version 0.7.3 to cover this, so it isnt delayed to long cause of the support for SHOWTHREAD in 0.8.0.

Best regards
Sebastian

Osbes 08-09-2011 02:08 PM

Hello BadgerDog,

BIG THANKS for your donation, i am really happy about your support :up:

Best wishes,
Sebastian

Taurus1 08-09-2011 02:58 PM

I am sorry for this question in here, so please forgive me. I asked my hosting company what version of GD-Library I have, and they answered me this:

Quote:

You have gd-2.0.33-9.4.el5_4.2, the latest from CentOS 5
Is this correct? That it is the latest version? Because on some of my styles I also see those weird looking images.

Thanks.

Osbes 08-09-2011 03:35 PM

Hello Taurus1,

the latest version of the gd library is 2.0.36 (from 2007) in which this bug was fixed.

I think gd 2.0.33 was released 2004. It may be the latest version with CentOS 5.

Debian uses gd 2.0.36 since Debain Lenny.

Best regards
Sebastian

Taurus1 08-09-2011 03:48 PM

Quote:

Originally Posted by Osbes (Post 2231406)
Hello Taurus1,

the latest version of the gd library is 2.0.36 (from 2007) in which this bug was fixed.

I think gd 2.0.33 was released 2004. It may be the latest version with CentOS 5.

Debian uses gd 2.0.36 since Debain Lenny.

Best regards
Sebastian

Thank you very much. (Sent you some bucks to say thanks for everything!)

Taurus1 08-09-2011 03:55 PM

Sorry, I have one question. If I disable TMS now, after this is already installed, will I loose all template edits?
And then can I just enable it again if there is an update?

Thanks.

steeler7 08-11-2011 02:43 PM

Question..

My "goto last post" button isn't showing up which is likely caused by me forgetting to edit code... any idea what bit of code there was to edit in order to get this to appear?

Osbes 08-12-2011 12:12 PM

Hello Taurus1,

THANKS for your donation, its really really nice, big thanks!

I which i could have answered sooner, but i had a lot work to do this week.

I dont know if TMS will remove the template-changes if you disable it, but i think it will remove them, if you deinstall it.
I think Andreas will answer this, if you ask him in the corresponding thread: https://vborg.vbsupport.ru/showthrea...152931&page=44

Again, Thank you very much!

Best wishes
Sebastian

Osbes 08-12-2011 12:16 PM

Hello steeler7,

sorry for my late answer.

It seems you have already find the solution? Just to make sure, this are the needed template changes:

Code:

6c14
<    <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><img src="{vb:stylevar imgdir_button}/lastpost-{vb:stylevar right}.png" alt="{vb:rawphrase go_to_last_post}" /></a>
---
>    <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><span class="sprite_button_lastpost" title="{vb:rawphrase go_to_last_post}"></span></a>
18c26
<    <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><img src="{vb:stylevar imgdir_button}/lastpost-{vb:stylevar right}.png" alt="{vb:rawphrase go_to_last_post}" /></a>
---
>    <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><span class="sprite_button_lastpost" title="{vb:rawphrase go_to_last_post}"></span></a>

Best regards
Sebastian

steeler7 08-12-2011 03:16 PM

Quote:

Originally Posted by Osbes (Post 2232610)
Hello steeler7,

sorry for my late answer.

It seems you have already find the solution? Just to make sure, this are the needed template changes:

Code:

6c14
<    <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><img src="{vb:stylevar imgdir_button}/lastpost-{vb:stylevar right}.png" alt="{vb:rawphrase go_to_last_post}" /></a>
---
>    <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><span class="sprite_button_lastpost" title="{vb:rawphrase go_to_last_post}"></span></a>
18c26
<    <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><img src="{vb:stylevar imgdir_button}/lastpost-{vb:stylevar right}.png" alt="{vb:rawphrase go_to_last_post}" /></a>
---
>    <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><span class="sprite_button_lastpost" title="{vb:rawphrase go_to_last_post}"></span></a>

Best regards
Sebastian

Thanks!

i'll go check those out.

One other question. I've been having the issue with the Attachment clip graphic that was mentioned earlier in this thread. I asked my host to upgrade my GD to 2.0.36 like you had recommended and this was the response I received :

Quote:

The version of the 'gd' package installed on your VPS is 2.0.33. As we have found out from the official repository https://bitbucket.org/pierrejoye/gd-libgd, this is the latest stable version. So the version 2.0.36 of this library couldn't be installed.

Osbes 08-12-2011 04:15 PM

Hello steeler7,

the versioning in the repo is a little bit messed up, since the tags shown by bitbucket (latest 2.0.33 / 2.0.34RC1) dont correspond to the .hgtags (latest 2.0.35) and it also didnt correspond to the NEWS (latest 2.0.36).

To bring some order in this mess, its best to look at the official site for this. Since this site is currently down, please us the waybackmachine for this:
http://web.archive.org/web/201012240....org/Main_Page

As you can see, the latest official release is 2.0.36 RC1 and the latest stable release is 2.0.35.

Since 2.0.36 RC1 is now nearly 4 years old and fixes some security issues, it is mostly addressed as 2.0.36 and - as example - used by the stable release of debian (http://packages.debian.org/squeeze/libgd2-noxpm) and was even used two years before by the oldstable release (http://packages.debian.org/lenny/libgd2-noxpm).

If you use gd2 embeded in php and want to know which is the minimum required php-version which had this patch embeded, we need to look a little bit closer.

This was the patch for the support of png "gray+alpha": https://bitbucket.org/pierrejoye/gd-...g-src/gd_png.c
Now we need to look into the php repo to make sure since which php version this patch was included.

You will find, that this patch is included in the embeded version since PHP 5.3.0 (https://svn.php.net/repository/php/p...libgd/gd_png.c).

For comparison PHP 5.2.17 (latest version before 5.3.0) in which this patch wasn't included: https://svn.php.net/repository/php/p...libgd/gd_png.c


If it isn't possible to update the gdlib, you can always switch your images from "gray+alpha" with an version using "color RGBA". But i mostly recommend the update of the gdlib, since 3.0.36(RC1) also fixes some serious security issues.

I hope this helps you :)

Best regards
Sebastian

steeler7 08-12-2011 08:46 PM

Quote:

Originally Posted by Osbes (Post 2232685)
Hello steeler7,

the versioning in the repo is a little bit messed up, since the tags shown by bitbucket (latest 2.0.33 / 2.0.34RC1) dont correspond to the .hgtags (latest 2.0.35) and it also didnt correspond to the NEWS (latest 2.0.36).

To bring some order in this mess, its best to look at the official site for this. Since this site is currently down, please us the waybackmachine for this:
http://web.archive.org/web/201012240....org/Main_Page

As you can see, the latest official release is 2.0.36 RC1 and the latest stable release is 2.0.35.

Since 2.0.36 RC1 is now nearly 4 years old and fixes some security issues, it is mostly addressed as 2.0.36 and - as example - used by the stable release of debian (http://packages.debian.org/squeeze/libgd2-noxpm) and was even used two years before by the oldstable release (http://packages.debian.org/lenny/libgd2-noxpm).

If you use gd2 embeded in php and want to know which is the minimum required php-version which had this patch embeded, we need to look a little bit closer.

This was the patch for the support of png "gray+alpha": https://bitbucket.org/pierrejoye/gd-...g-src/gd_png.c
Now we need to look into the php repo to make sure since which php version this patch was included.

You will find, that this patch is included in the embeded version since PHP 5.3.0 (https://svn.php.net/repository/php/p...libgd/gd_png.c).

For comparison PHP 5.2.17 (latest version before 5.3.0) in which this patch wasn't included: https://svn.php.net/repository/php/p...libgd/gd_png.c


If it isn't possible to update the gdlib, you can always switch your images from "gray+alpha" with an version using "color RGBA". But i mostly recommend the update of the gdlib, since 3.0.36(RC1) also fixes some serious security issues.

I hope this helps you :)

Best regards
Sebastian

Here's my hosts response after providing to them your explanation :

Quote:

As you know you have cPanel on the server and we use all libraries from the official repositories. And the latest version of GD library in the official repositories is 2.0.33-9.4, which is currently installed on your VPS. Any custom install may cause problems to Apache + PHP, so this can be done at your own risk and we can't guarantee that everything will be working properly after the upgrade.
I';m to novice to install stuff like this myself :D, but I figured posting this for you and others just in case anyone else happens to run into this issue

FReeSTER 08-13-2011 01:10 AM

I might be dumm but do I have to do all those template edits on the dfff file?

I dont get the way is been done, which templates I edit, or remove?

FReeSTER 08-13-2011 04:38 AM

damn the more I try with this mod the more problems I get. errr

Osbes 08-13-2011 07:38 AM

Hello FReeSTER,

the easiest way is to install the Template Modification System and than install this addon. Than all template-changes will be done automatically.



If you do it manually you need to do all the template-changes within the TEMPLATE_CHANGES.diff.

In the diff-format, "<" means remove and ">" means add. in a combination like

Code:

Template: block_blogentries
5c5
<    <img src="{vb:stylevar imgdir_cms}/widget-blog.png" alt="" />
---
>    <span class="cms_widget_blog"></span>

It would mean

replace
Code:

<img src="{vb:stylevar imgdir_cms}/widget-blog.png" alt="" />
with
Code:

<span class="cms_widget_blog"></span>
Best regards
Sebastian

kingMOB 08-13-2011 03:22 PM

Up there is saying "vB Version: 4.x.x", but when trying to install in a 4.0.8 version the plugin says it is incompatible.

Mooff 08-13-2011 03:28 PM

nvm.

Osbes 08-13-2011 03:39 PM

Hello kingMOB,

the addon has internally vBulletin 4.1.3 and above as depency.

product-sprite-0.7.2.xml
Code:

<dependency dependencytype="vbulletin" minversion="4.1.3" maxversion="" />
You can change this to
Code:

<dependency dependencytype="vbulletin" minversion="4.0.8" maxversion="" />
or lower to run it with vBulletin 4.0.8.

I have set this thread to vB Version: 4.x.x, since it should work with 4.x.x theoretically (as far as i can see), but until now it wasnt independent and practically confirmed, thats why the minversion is currently set to 4.1.3, the lowest vBulletin version for which it was confirmed in a live system.

Best regards
Sebastian

FReeSTER 08-14-2011 02:23 AM

Quote:

Originally Posted by Osbes (Post 2232915)
Hello FReeSTER,

the easiest way is to install the Template Modification System and than install this addon. Than all template-changes will be done automatically.



If you do it manually you need to do all the template-changes within the TEMPLATE_CHANGES.diff.

In the diff-format, "<" means remove and ">" means add. in a combination like

Code:

Template: block_blogentries
5c5
<    <img src="{vb:stylevar imgdir_cms}/widget-blog.png" alt="" />
---
>    <span class="cms_widget_blog"></span>

It would mean

replace
Code:

<img src="{vb:stylevar imgdir_cms}/widget-blog.png" alt="" />
with
Code:

<span class="cms_widget_blog"></span>
Best regards
Sebastian

Got it mate, thanks

I went to page speed from google and Im getting this

Suggestions for this page
The following images served from myfreeneeds.com should be combined into as few images as possible using CSS sprites.

Suggestions for this page

The following images served from myfreeneeds.com should be combined into as few images as possible using CSS sprites.
I also have this problem on the subforums showing no images

https://vborg.vbsupport.ru/external/2011/08/33.jpg

Osbes 08-14-2011 07:11 AM

Hello FReeSTER,

most of the icons you listed are introduced by your style, if you want to add them you need to do this via the sprite_add_icon Hook. Please read "Google pagespeed still tells me that i should combine icons into sprites." in the FAQ for further information :)

I am currently working on 0.8.0 an have changed the Array for adding Icons a little bit, so i would advise to wait until the release of 0.8.0 before you add icons to the sprite, so you didnt need to change them a second time.


Regarding the not displayed threadicons, i think you forget this template-change:
Code:

Template: threadbit
1c1
<    <li class="threadbit {vb:raw thread.statusstring}<vb:if condition="$show['paperclip']"> attachments</vb:if><vb:if condition="!$thread['postuserid'] AND !$thread['del_userid']"> guest</vb:if><vb:if condition="$thread['moderatedprefix']"> unapproved</vb:if>" id="thread_{vb:raw thread.realthreadid}">
---
>    <li class="sprite_statusicon_thread_30 threadbit {vb:raw thread.statusstring}<vb:if condition="$show['paperclip']"> attachments</vb:if><vb:if condition="!$thread['postuserid'] AND !$thread['del_userid']"> guest</vb:if><vb:if condition="$thread['moderatedprefix']"> unapproved</vb:if>" id="thread_{vb:raw thread.realthreadid}">

Best regards
Sebastian

FReeSTER 08-14-2011 01:50 PM

Quote:

Originally Posted by Osbes (Post 2233301)
Hello FReeSTER,

most of the icons you listed are introduced by your style, if you want to add them you need to do this via the sprite_add_icon Hook. Please read "Google pagespeed still tells me that i should combine icons into sprites." in the FAQ for further information :)

I am currently working on 0.8.0 an have changed the Array for adding Icons a little bit, so i would advise to wait until the release of 0.8.0 before you add icons to the sprite, so you didnt need to change them a second time.


Regarding the not displayed threadicons, i think you forget this template-change:
Code:

Template: threadbit
1c1
<    <li class="threadbit {vb:raw thread.statusstring}<vb:if condition="$show['paperclip']"> attachments</vb:if><vb:if condition="!$thread['postuserid'] AND !$thread['del_userid']"> guest</vb:if><vb:if condition="$thread['moderatedprefix']"> unapproved</vb:if>" id="thread_{vb:raw thread.realthreadid}">
---
>    <li class="sprite_statusicon_thread_30 threadbit {vb:raw thread.statusstring}<vb:if condition="$show['paperclip']"> attachments</vb:if><vb:if condition="!$thread['postuserid'] AND !$thread['del_userid']"> guest</vb:if><vb:if condition="$thread['moderatedprefix']"> unapproved</vb:if>" id="thread_{vb:raw thread.realthreadid}">

Best regards
Sebastian

Thank you mate, that did the job. :):up:
and yes i will wait for 0.8.0

klaus 08-14-2011 08:30 PM

I also had the problem post#300 had where icons don't show up in forumdisplay.

I relied on the TMS to automate my Template modifications for this product but it didn't modify the first line of threadbit because of another plugin/product I was running. Separate Sticky from NonSticky threads is the plugin that previously changed line1 in threadbit preventing the TMS from doing its job.

So if you have that plugin installed then the automated install of this product does not work and you need to modify threadbit by hand or uninstall the other plugin. I simply reverted threadbit to default (loosing the sticky plugin), but it did the trick.

Taurus1 08-15-2011 12:48 PM

I am sorry, but I had to disable this mod. TMS caused me to almost not being able to edit any template. And disabling TMS renders this mod useless. I really hope you can come up with a fix here. Thanks.

Osbes 08-15-2011 01:32 PM

Hello Taurus1,

if you have problems with TMS, please write them down in https://vborg.vbsupport.ru/showthrea...152931&page=44. I cant help you with the TMS.

Without TMS, maintaining the templateedits is very time-consuming. I knew it, since i do this manually on our forum.

Best regards
Sebastian

rajubd 08-17-2011 12:13 PM

When thread display version will be added? Then I will add it on my live board..

Mooff 08-17-2011 12:25 PM

Osbes is working on SHOWTHREAD right now, an alpha is running on our live board.

SHOWTHREAD is really tricky and needs a lot of creative thinking, therefore it unfortunately takes a bit longer than expected to weed out the unavoidable bugs. But it's going to be awesome. =)

Eagle Eyes 08-19-2011 06:07 PM

Do you have a live board running this?

Thank you.

rajubd 08-19-2011 06:44 PM

Alpha version working on here www.united-forum.de/?

datoneer 08-19-2011 11:30 PM

upon installation a new stylevar imgdir_sprite will be created. Update this stylevar based on your file structure - default value is the vbulletin sprite directory. Make sure the folder is writable, else the sprites can't be saved!

I don't understand this?? What do you mean with ths update stylevar what do need to do, i'm newbie for this stuff. How to make folder to be writeable

Osbes 08-20-2011 06:41 AM

Hello datoneer,

addon will create a new stylevar named imgdir_sprite. If you didnt changed your stylevars until now, the default value (images/sprites) should be ok for you.

Also in most cases this folder is already writeable if this isn't the case or another error occurs, the addon will tell it you during the creation/refresh of the sprites.

Best regards
Sebastian

Osbes 08-20-2011 06:52 AM

Status update:

We have added a lot icons for 0.8.0 but there are still 15 images left which we want to add.

Since we are currently in cologne at the gamescom, there won't be much support until monday and 0.8.0 won't be released before the next weekend.

datoneer 08-26-2011 05:49 PM

How to remove copyright from footer?

masterweb 08-28-2011 12:07 PM

Hello Osbes, i am very interested on this mod and personally i think you did a great job (congratulations for such great solution), but before installing it i have some questions:

I run on my forum the following mods and i would like to ask if there's any known issue between them and yours:

DownloadsII

DownloadsII Create Thread

iTrader

Members who have Visited

More Share Options for VB4 by BOP5

Most popular downloads

SevenSkins Image Resizer

Tabs en vBulletin 4.x

vBSEO

I have disabled the CMS also due as homepage we are running Wordpress with our own Style (you can check it at http://www.onlinewebmarket.net/forum.php)... so from the moment i would avoid installing TMS i have also another question: are you eventually available for installing your mod on my board and editing all templates manually (for a paid fee of course)?.

Thanks in advance for your reply and sorry for boring so much with all these questions Lol.-

Seductor 09-03-2011 10:34 PM

Hi guys, I haven't understood it at all. Do I need to change EVERYTHING that it is shown in TEMPLATE_CHANGES.diff or only the code under the ## Version 0.7.1 ## tag?

Thanks in advance.

apaydin2148 09-04-2011 09:58 AM

but tms is for 3.8.x? is there any version for vb4?

Mooff 09-04-2011 03:14 PM

@masterweb
We are running DownloadsII, Sevenskin Image Resizer, vBseo, v3arcade, vbExperience and there are no conflicts. Most likely there won't be any conflicts with the rest of them either.

@Seductor
Everything in Template_changes.diff needs to be changed. If you are using the TMS those changes will be done automatically during installation.

@apaydin2148
The latest TMS Version does work with vB4. For TMS Support please ask in the TMS mod topic.

Regards Mooff

K!nG 09-04-2011 03:35 PM

Is it working on 4.1.5 ??????

Seductor 09-04-2011 04:46 PM

It works, King.

By the way, Moof, I sugges to add this:

Template: forumhome_forumbit_level1_nopost

< <img src="{vb:stylevar imgdir_button}/collapse_40b.png" alt="" title="{vb:rawphrase collapse_this_category}" />
---

> (I don't know what It should be here).

Mooff 09-04-2011 06:31 PM

@Seductor

That icon has a javascript attached to it (to collapse the categories). Replacing the icon would mean modifing the javascript aswell, which in this case is pretty ugly, so we won't add that icon.


All times are GMT. The time now is 03:42 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02010 seconds
  • Memory Usage 1,897KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (14)bbcode_code_printable
  • (8)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete