Hi folks,

sorry for the long delay in answering questions and getting out a new version, but I'm really busy at the moment :)

This is really just a smaller release, including some bug fixes suggested in this thread. Thanks for all the work and thought that went into those! Be sure I try to keep up and integrate what you come up with!


Version 3.1

• new/updated product config files:
  • cnd garage (thanks to wottech for cooperation)
  • photoplog categories (for pro version)
  • photoplog albums (for pro version)
  • photoplog (updated, for lite version)
• some additional cookie error checking
• error checking in AdminCP removed
• bugfixes from this thread:
  • corrected error in installation.txt (see)
  • applied safemode-fix for vbG (see)
  • Popup-focus-fix (see)
  • fixed errors in config_photoplog.php (see and see more)

Note on Photopost support

• The config file thats just named photo_popup_photoplog is for the lite version. It works for me, although there have been problems reported. I can't reproduce these problems here.
• I decided to use two config scripts for Photoplog Pro. This means that PPlog categories and PPlog useralbums will be handled as two different products. Some errors have been fixed thanks to hints from Stoebi and bjhung in this thread. Thanks!
• though I have installed Photoplog for testing and I do offer a integration with this mod, I do not use either Lite nor Pro and have limited time to "get into it". Support for Photoplog is therefore limited and on an "as is" basis. If someone comes up with a better solution than mine, I'll gladly integrate it, as long as it does not force me to change the main code (minor changes would be considered, though).
• Baseline: As you can see, Photoplog is the weak point at the moment. This is partly due to my lack of time (and, I have to confess, to some extent also willingness) to digg myself into it's sturctures. Sorry folks, but I hope that the two new config files work for you. If not, everyone is welcome to come up with a solution (preferably in form of a working config file ;))

Other:

• Attachments will not be supported at the moment, with v4 and the new attachment management system pending. This may change once v4 is out.
• The problem reported in this post concerning not needed /.../ in image-paths can partly be reproduced. I do not experience it when inserting images from the albums (the folder is a subfolder of forum root), but always if the chosen product resides in a folder that is not a subfolder of forum root. This seems to be caused by the injection script that is part of the forum software and that this mod uses. I do not see a way around this.

Two errors in the Photoplog Categories setup:

In the PHP file, this:

Should read:

and this:

should read:

The count seemed wrong, and the moderate = 1 flag would only show those items that are under moderation.

You're right, I uploaded a wrong file version for the Photoplog configs - shame on me...
Your point about the moderation is valid and was to be fixed anyway, it was mentioned somewhere in the thread I think. That might also fix some of the problems there were with Photoplog usage.

But to do a count over the whole fieldset (by using *) seems not the best thing to do. Fileid is a unique key.

zip-file updated. If you downloaded before this post and inted to use Photoplog, please redownload.

It works now! Fantastic!!! :D

You're on Photoplog Lite, right?

Yep :)

thanks! now it works again!

Still does not work. Oh well

Had the same problem as well.

I had to copy the png file into my template styles editor folder not the vBulletin editor folder.
So instead of images/editor/photo_popup.png
It was images/<TemplateStyle>/editor/photo_popup.png.

Hope it helps.

Great MOD thank you.

thank you so much for that amasing Add-ons

The information you provide makes bugfixing somewhat - difficult ;)
What version of vB and vBG? Heaviliy modified skin? Which browser? Why don't you paste the debug-information the mod provides?
Have you tried it on a clean out-of-the-box installation?

The display of the button or the link to open the popup window in the editors is independent of products used. If you did the template edits and upload of the image file properly, it will show up. If it does not, there may be several causes you have to check for yourself, since nobody here knows your independant setup:

• you use a custom made style or custom buttons and therefore use a different than standard directory for your button image files. This mod looks for the image file in the directory you have defined in AdminCP->StyleManager->StyleVars->Imagepaths->Button Images Folder.
• Your style is heavily modified. If this is the case, the reference code given (i.e.: insert after XY, replace XY) may not work for you. In this case, you'll have to find out yourself or ask the person who provided your style
• You use another mod that modifies the editors - there are quite some of them out there. If this is the case, read the note in the second post of this thread.

I made some changes to the config file for vBGallery. Up to now there was an issue I was not aware of concerning user categories: user categories not belonging to the current user were visible in the albums drop down menu as an empty line. This should be fixed now: only user categories belonging to the user are shown and, of course, with title.

The .zip file in the first post has been updated. If you already downloaded 3.1, you can download just the attached config file and upload it to your includes folder. If you modified your vBG config file (because you use an older version and needed to account for the different data folder structure), you can also do the following file edit:

Find:
Replace with:


File removed for newer version. Check following posts! Please note that there are further improvements going on, so it is recommended not to do the file edit, but to upload the updated config file.

thanks....

I did say this earlier, but it needs saying again, this is one of the most useful and practical mods for vB for a long time.

It provides another much needed "link" between the vb album functionality and the forum posts, which is sadly lacking in many ways by default. It also works perfectly out of the box and looks like it came as part of vB.

The default nonsense about copying and pasting URLS from the album into the post is just impractical and nobody uses it. Now lots of my members are utilising the albims a lot more.

On that basis I have now nominated this mod for "Mod Of The Month".

A note for the future, it would be good to have something similar for "Add picture to group" as that also requires this nonsense of pasting in a URL which you don't at that point have access to. It's messy.

cellarius,

a) i've made russian translation for this hack, there are two language files since it is customary to run cyrillic forums either in windows-1251 (ansi) codepage or utf-8. i've attached them to this message.
b) i've made a little patch to make the script itself more friendly to non-ansi codepages. the diff is attached as well.

I second these comments. This is going to be one of those must have mods. Probably one of the ones you would think twice about upgrading your forums if it no longer worked.

That's what I think anyway as my members would hate me if they lost it. :)

Can I just say I love this mod? It was always such a pain before when I want to post images in a certain order, and with attachments you cant, theyre just all on the bottom - no way to say "ok here is what happened first", and "then in this pic this happened" and "this is the pic I took last tuesday". Now with this mod, I can place pics wherever I want - love it :) and yeah, my members are suddenly using their photo albums a lot more :cool:

Your vbgallery directory structure is not parsed correctly. For example I have a member who selected a photo and he gets this:

http://www.planetporsche.net/gallery...tige_thumb.jpg

What it "should" be is the following:

http://www.planetporsche.net/gallery...tige_thumb.jpg

The number corresponding to the memberid isn't a single directory (like 170 in this case for member #170) but rather it is parsed by each digit 1/7/0

Please fix and distribute an update! :)

Thx!

FYI I have the latest and greatest vbgallery, and it needed this too!

It is - for the newest release that I am running for testing purposes. Your directory structure reflects an older version. A fix for this has been posted somewhere in this thread. Just search for it.

So maybe it does not change a directory structure that is already in place. Anyway, my installation uses the 1/2/3/4 format. If anyone can clarify when vBG uses which format and whether there is an easy way to detect it, I'll happily adapt the mod. As long as this is not the case, vBG-users who have 1234-structure will have to apply that patch.

the 1234-structure is used when php is in safe mode.

My gallery uses the 1/2/3/4 format (the format used when you are not using safemode) and this hack worked fine for me as my user ID is 1. When I switched to a test user with ID 123, the hack stopped working. I had to apply the patch provided by wottech here.

To determine whether a gallery is using safemode, in ACP, go to VbGallery -> Maintenance and scroll to the bottom.

BTW, this is a great hack ! :)

I have the same problem, i do the same on 2 of my site, one is working, the other does not, in the second i have the popup window but can't insert picture from album, and in the bottom of both popup windows i have error in page.

Thanks - for the compliments and the hint concerning safe mode.

New config file for vbGallery!
v 3.1b

So - there's just another new config file for vBGallery with the following fixes and new features:

• Photo Popup determins correct folder structure
  by checking whether vBG is running in safe mode environment and setting the folder structure accordingly. This is determined by a variable that vBG sets in its config database. The code for pulling together I borrowed from wottech, who posted a fix here.
• Photo Popup now checks whether vBG is set to save the originally uploaded images.
  If this is the case, all "original"-options for inserting the images are linked to those original images, the images shown in the Gallery are linked to the "medium" options. If original size images are not safed, the behaviour is as it was up to now: The images shown in the Gallery are linked to the "original" options, the "medium" options are disabled. If you have "save originals on upload" active but do not want to allow them to be inserted, you can set the new "original_override"-switch at the top of the config file to "TRUE".

Please check out the new config file and report any bugs here :)

File removed for a later version, check next posts!

But wait there's more! Sorry but you have another error in the code as well with vbgallery.

If a user uploads a photo titled MyPhoto.JPG into vbgallery, vbg will create a thumbnail called MyPhoto_thumb.jpg by default.

However, your code in the pop up window is looking for MyPhoto_thumb.JPG (extension in caps like the original file) and so the user will see red x's instead of thumbnails when they look through their images because Linux treats the file extensions in a case sensitive manner.

Now if you click on that red x inserted thumbnail it WILL take you to the correct full size photo because the full size photo does end in .JPG or whatever the all caps extension happened to be.

This should be as easy as making the _thumb file always end in a lowercase version of whatever the original extension is or else storing the actual thumbnail file name or checking it in some way.

For now I have told my members NOT to choose the thumbnail insertion when looking through their vbgallery files to insert but to choose full size insertion until the code can be fixed to handle the file extension case problem.

Thanks in advance for the fix, sorry to keep piling these on you, but my members are a picky bunch and usually find any issues with any code with any browser, etc... :)

Correct. So far I follow you when trying to reproduce this.

Hm, that's where I'm losing you: the code for the thumbnails is genereted by strtolower-ing the file extension, thus it is always lowercase.
Actually, the path and filename used to show the thumbnails in the popup window and for the insertion process come from exactly the same variable - they can not be different. Their extensions both have to be lowercase.
By the way: If I'm uploading an image that has a uppercase extension, vBG changes the original uppercase extension to lowercase.


That's what the script does at the moment, actually...


No problem, really. Since I do not use vBG in a productive environment, I don't have the ability to do such intensive testing. This way, sooner or later we'll get it goin' :D

So, after some more thinking, I decided to take more information directly from the database. All filenames - thumbs, originals, everything including extensions - are now taken directly from the database and thus should mirror exactly what vBG uses. If it works there, it should also work with this mod. Please test the attached config file and see whether it solves the problem. If not, please check whether vBG indeed saves original files with uppercase extensions (which it does not for me - and I was unable to find an option in the vBG settings, tho I did not look too hard) and provide the content of the debug table field for "Code".

Since the error descriptions on this have been more than vague up to now, there really is no way to address this issue. I do not experience any errors. At least state which browser you are using and what the error is (exact error message!). Are you sure you have uploaded the latest version of photo_popup.php?

Thanks for looking into this. Since I've had vbgallery for a couple of years there is some chance that vbgallery has changed over time. I have confirmed that a member who uploaded a photo ending in .JPG has a thumb ending in .jpg and hence has a red x problem. I am out of town currently but will return tomorrow and will try your new config file to see if it takes care of the problem by pulling the names directly from the database. I would hope that it would since the database could contain photos that vbgallery has stored differently at different times.

I was going to ask about your config setting for storing the original file. While there IS a setting for that in vbgallery to apply universally I don't use it. By default if someone uploads it creates a thumbnail and resizes to say 800x600 or whatever my default settings are. However, you can override that with settings for each category and in fact I do that. So I have some categories where say an image that is 3000x2000 will be uploaded and a thumbnail is created, an 800x600 version is created and the original 3000x2000 image is also saved. I don't know if running vbgallery in this way poses a problem for your mod if users try to insert say a medium sized photo or the original, etc. I just wanted to point out that some of us don't use the save original setting universally, but rather use it for only certain categories. Hope that helps!

Had a look at the database. I fear, the per category setting is too complex to handle it within the limitated structures of this mod. That's the downside of supporting more than one product - it's not flexible enough to support everything for every product. The problem is: Though it would probably be possible to add an additional query to the config that detects whether there are original images or not - as soon as the user clicks on "show all my images", there will be problems.

Sorry, this mod will have to handle it either as allow it or disable it...

I installed the mod on two forum with vb 3.8.2, i used IE7 And Firefox, i have no error message, the photo popup windows open normally on both with all the photos in the popup but on one of the forum when you click on a photo nothing happend.

Understood, it was just something that I was pointing out could be different in different configurations. I typically would never want to insert the full size original image anyway as it would likely be too large for the forum and throw the screen out of whack. I just uploaded the most recent vbgallery config file to the server and will ask my members to test.

One other suggestion I have for this mod is that in the instance where the user has no photos uploaded in the Vbulletin Albums not only should it say no photos found, but it should also have a link to:

http://www.yourwebsitehere.net/album.php?do=addalbum

So the user could go "oh that's where I can upload a photo to insert into this message" otherwise if they aren't familiar with where the photo albums are they have to hunt around or ask, why not give them some pointers.

Likewise for vbulletin there should be the message that no photos are found but then also a link such as:

http://www.yoursitehere.net/gallery/upload.php?&c=

So the user can be taken to the vbgallery and start uploading to some category they choose.

As for the CND garage if they have no photos uploaded the link would depend on whether they had a car in the garage yet or not, so in that instance I would probably just suggest a link to the garage: http://www.yoursitehere.net/garage.php and let it go at that.

I suppose if you wanted to be more flexible you could make these links both optional and customizeable through your admincp options for this mod, let the admin decide whether or not to display "helper links" and if so what link they want for each (I would provide defaults which they could then change as needed).

I hope all that makes sense.

Last, but not least in the standard reply box rather than just the text that says My Pictures, there ought to be some sort of picture graphic above that text.

O.k., I explored some more and this problem seems to be connected with the use of vbSEO, and indeed it only happens in Firefox. Robi_Kanobi, if you're still around, can you confirm that you are using vbSEO (or some other sort of SEO-Solution?). Confirmation from anybody else will be appreciated, too, of course.

I'll see whether I can get this fixed.

I see the usefulness of such links, yes. They'll probably make it into some next release.

To get things in AdminCP not too confusing with all the products, I'll probably define a default setting in the config files that can then be changed if the need arises. I guess that most of the users will be happy with the standard upload page.

You can always insert the icon already shipped with that mod ;)

hi to all

sorry for my english

i'm newbie

i had just installed this product and made the modification. no problem

i work with vb 3.8.1 and photopost but when click on icona ,the message is this

"You have set the product "photopost" to use a different database than your forums. However, the script cannot connect to this other database. Please check your database settings.!

in photo_popup_config_photopost.php , i have this

"The values for the following settings can be found in Photopost Administration
// Center
// Full URL path to Gallery: http://www.yoursite/path/to/gallery/
//
$url_path = "http://news.tecnocomputer.it/forums/photopost/";
//
// Full URL path to Data Dir: http://www.yoursite/path/to/gallery/data/
// Look for this in PP-Administration->Global Options->URL to PhotoPost data directory
//
$data_dir = "http://news.tecnocomputer.it/forums/photopost/data/";
//
// Table prefix. pp_ is the default setting.
// You may have changed this on installation of Photopost Pro.
// Look for this in PP-Administration->Edit Config->PhotoPost Database Prefix
//
$db_prefix = "pp_";
//
// If you do not save medium sized images with Photopost Pro or want to disable
// medium image insertion for this product only, set this to TRUE;
//
$medium_override = FALSE;
//
// If you do allow albums selection in popup, but want to disable it for this
// product, set this to TRUE;
//
$album_override = FALSE;"

is it correct? thanks to all

It's probably not correct - else there would not be this error ;)

All the settings you pasted have nothing to do with database setup, tho. But that's where the error probably is. The database settings come right after the part you copied.

Do the following:

• find out whether you have your Photopost data in the same database as vBulletin.
• If this is the case, make sure line 49 reads "$other_db = FALSE;" (w/o the "). If this is now set to TRUE, this is most likely to cause your problem.
• If you indeed use another database for Photopost, set this variable to "TRUE" and make sure the settings that follow are correct.

thanks

now i have put FALSE like this

$medium_override = FALSE;
//
// If you do allow albums selection in popup, but want to disable it for this
// product, set this to TRUE;
//
$album_override = FALSE;
//
// ### If your vB and Photopost run from the same Database, ###
// ### skip the following. To use different database, set ###
// ### $pp_other_db to TRUE and fill in the variables ###
//
// Set to TRUE if using different database for vB and PP
$other_db = FALSE;
// Database Name
$db_name = "photopost";
// Database Host
$db_host = "localhost";
// Database Username
$db_user = "root";
// Database Password
$db_pass = "";

this is the error now

Database error in vBulletin 3.8.1:

Invalid SQL:

SELECT id, catname
FROM pp_categories
WHERE cattype = 'a' AND parent = 1418
ORDER BY catname;

MySQL Error : Table 'tcportal.pp_categories' doesn't exist
Error Number : 1146
Request Date : Thursday, April 16th 2009 @ 11:23:42 AM
Error Date : Thursday, April 16th 2009 @ 11:23:42 AM
Script : http://news.tecnocomputer.it/forums/...e=vB_Editor_QR
Referrer : http://news.tecnocomputer.it/forums/...ad.php?t=20763
IP Address : XXXXXXX
Username : XXX
Classname : vB_Database
MySQL Version : 5.0.45

As the error states: There is no table pp_categories in your database tcportal.

I'm sorry, but I cannot say what your database setup looks like - that's something you'll have to know ;).

Is the prefix "pp_" correct? Are you sure you installed Photopost into the same database as vBulletin (the one called "tcportal") - it does not seem to be there?