Code:
for($i = count($rss_allItems) - 1; $i >= 0; $i--) {
$rss_allItems[$i][OLD] = false;
}
That fixed the problem right up, indeed.
Now, there are a couple more things that are issues. For one there's no check for mysql_escape_string which will be bad if you actually grab rss feeds from, say a site that uses " or '. I've already run into this one tonight;
Fix:
In includes/RSS/rss_update.php, look for
Code:
$rss_title = str_replace("'", "\'", $rss_title);
$rss_description = str_replace("'", "\'", $rss_description);
and change it to:
Code:
$rss_description=mysql_escape_string($rss_description);
$rss_title=mysql_escape_string($rss_title);
// $rss_title = str_replace("'", "\'", $rss_title);
// $rss_description = str_replace("'", "\'", $rss_description);
Essentially, this is the same thing, but for some reason the replace ' doesn't work as it should, in the longrun. I noticed this when I got feedback from the next script which I'll post:
In response to the cron thing, it's really a simple thing to do (until this is officially added to the cron somehow). Create a file in your public_html, call it rssfeed.php (or whatever), and in it, just add:
Code:
<?
require_once('./global.php');
require_once('./includes/functions_bigthree.php');
require_once('./includes/functions_forumlist.php');
require_once('./includes/RSS/rss_update.php');
?>
and for a cron entry, just call
Code:
*/5 * * * * php /path/to/your/file/rssfeed.php
This will update the news feeds every 5 minutes, rather than every time someone visits the forum, which would be more efficient. 5 minutes may (still) be too much, but I doubt it.
BTW, i've integrated this into vbadvanced, for those wanting info on how, let me know and if there's enough interest I'll post it here.
As far as forums and counts, I agree this is something that shouldn't be updated. However, if you (really) want to update your forums and posts, having this count in them, you can update your postcounts from admincp. This will fix that problem. Hopefully, I'll be able to come up with a workaround for that in the near future, but who knows.
Great code, glad to see it finally working!!
More Information