vb.org Archive - Administrative and Maintenance Tools - Mail Admin When fail to login to admincp V2

Page 8 of 10

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)

- - Administrative and Maintenance Tools - Mail Admin When fail to login to admincp V2 (https://vborg.vbsupport.ru/showthread.php?t=229231)

Sunray

08-22-2010 05:53 PM

Hi,

Great plugin ! Thanks a lot for it.
Installed and tested in vB 4.04, is working well.

Delphiprogrammi

08-23-2010 03:28 PM

hi,

nice one but couldn't this be made more real by the "VB_AREA" define something like

PHP Code:


		
			
if(defined('VB_AREA') AND (VB_AREA == 'admincp'))
{
    //****
}

OcR Envy

08-24-2010 06:15 PM

This is extremely misleading. You aren't checking if they are logging into the AdminCP at all. You're checking to see if they failed to login anywhere on the site. Poorly executed.

Delphiprogrammi

08-25-2010 05:13 PM

Quote:

Originally Posted by OcR Envy (Post 2088983)

This is extremely misleading. You aren't checking if they are logging into the AdminCP at all. You're checking to see if they failed to login anywhere on the site. Poorly executed.

i agree through it doesn't send an email when the "normal login" fails hmm i don't get it...

Delphiprogrammi

09-21-2010 06:45 PM

hi,

problem solved for those people that get emailed when there normal login fails open the plugin and the first line

PHP Code:


		
			
if($vbulletin->options['madkour_admin_login_fail_onoff'])
{

above that add

PHP Code:


		
			
if(!defined('VB_AREA'))
{
      die("error");
}

underneath the first code snippet code add

PHP Code:


		
			
VB_AREA ='AdminCP';

that's it now you only get emailed when the actual admincp login fails for some reason look at /includes/adminfunctions.php if you want more information about the VB_AREA constant

0verl0rd

10-25-2010 09:17 AM

Awesome! thanks!

Ary Braga

11-02-2010 06:48 PM

Quote:

Originally Posted by Delphiprogrammi (Post 2101528)

hi,

problem solved for those people that get emailed when there normal login fails open the plugin and the first line

PHP Code:


		
			
if($vbulletin->options['madkour_admin_login_fail_onoff'])
{

above that add

PHP Code:


		
			
if(!defined('VB_AREA'))
{
      die("error");
}

underneath the first code snippet code add

PHP Code:


		
			
VB_AREA ='AdminCP';

that's it now you only get emailed when the actual admincp login fails for some reason look at /includes/adminfunctions.php if you want more information about the VB_AREA constant

underneath????/

PHP Code:


		
			
if($vbulletin->options['madkour_admin_login_fail_onoff'])
{

Could put the code here ready?

I tried and failed. excuse my ignorance.:confused:
Parse error: syntax error, unexpected '=' in /home/clangsm/public_html/vb/login.php(114) : eval()'d code on line 5

Correct me if I'm wrong

PHP Code:


		
			
if(!defined('VB_AREA'))
{
die("error");
}  
VB_AREA ='AdminCP';
if($vbulletin->options['madkour_admin_login_fail_onoff'])
{

Delphiprogrammi

11-02-2010 07:45 PM

hi,

no you did it wrong it must be

PHP Code:


		
			
if($vbulletin->options['madkour_admin_login_fail_onoff'])
{
      VB_AREA =='AdminCP';
      // the rest of the code here(already there)
}

the first block is needed because if the VB_AREA constant is not defined PHP will throw error messages

Ary Braga

11-05-2010 12:51 PM

wow.

Thank you very much.
U save my day.

Regards.

Delphiprogrammi

02-18-2011 12:22 PM

hi,

I just noticed the plugin author is using values directly from $_POST[] superglobal array.This is a bad programming attitude certainly without any form of sanitization this could lead to XSS security holes he should use

PHP Code:


		
			
$vbulletin->GPC['variablename']

at least this way you're sure the values being submitted are clean

All times are GMT. The time now is 09:33 AM.

Page 8 of 10

« First

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01271 seconds Memory Usage 1,756KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (11)bbcode_php_printable (2)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: