vb.org Archive
Page 8 of 19 « First 67 8 91018 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   Major Additions - MySmilies vB (v3.8.0) (https://vborg.vbsupport.ru/showthread.php?t=220193)

Eric 08-08-2009 06:29 PM
Quote:
Originally Posted by Sador (Post 1863534)
About the showing in quotes stuff... it shows the smiley when you quote your own post with your own custom smiley, but it doesn't show when someone else quotes it, because they don't have the smiley so the text doesn't get parsed.

It would be nice if that could be fixed. Also, right now custom smileys are shown in the html box with all the other smileys. This looks kinda bad, so I disabled that, but it doesn't show in 'more smileys' either. Is there some way that could be fixed as well?

Otherwise, great mod, thanks a lot. :)
As stated earlier in this thread about "More Smilies", that will be in the next release.

Quote:
Originally Posted by nascartr (Post 1863524)
Ok, just making sure! :D
Quote:
Originally Posted by Oblivion Knight (Post 1863474)
Makes no difference, mine is default.. :)
Quote:
Originally Posted by nascartr (Post 1863396)
Same here. I am using a custom quote box though?
Quote:
Originally Posted by trotskid (Post 1863287)
Yes, you right Oblivion Knight.
As for the Quote issue - I'm looking into it, I'm not sure if it's going to be that easy of a fix.

Eric 08-08-2009 06:32 PM
Quote:
Originally Posted by Megatr0n (Post 1863158)
I've done that and it does show for all my users when they access their UserCP.

However, no one can see it when they're accessing their private message inbox, which would be this URL:

http://www.yourforum.com/forum/private.php

Try it on your board and see if you can still see the link on the left.
Not sure what to tell you, as it works on my board just fine. But give me some time, I'll try to see if I can find any possible causes.

Megatr0n 08-08-2009 10:32 PM
Quote:
Originally Posted by SecondV (Post 1863663)
Not sure what to tell you, as it works on my board just fine. But give me some time, I'll try to see if I can find any possible causes.
Hi Eric,

Sounds good. I look forward to a hopeful solution! :)

Sweeks 08-10-2009 10:35 AM
Works perfectly, thanks!

Oblivion Knight 08-10-2009 12:10 PM
Regarding the quote box bug..

It can be fixed by removing this from the query on the bbcode_parse_complete plugin:
Code:
                WHERE userid='{$GLOBALS['mysmiliesvb_userid']}'
..But it's not at all recommended if you have a large board with many users who make use of custom smilies. I've done it because I have a small board, with not so many users and have limited the smilies per user to 20.

Perhaps somehow grabbing the quoted user's userid and adding it to the query is a possibility?

I was looking at some code from an old "Who Quoted Me?" plugin. While it would need reworking for use here, I think it could be a possibility..

Eric 08-10-2009 02:16 PM
Try this for me?

Change the query in that plugin to:

PHP Code:
    if (isset($GLOBALS['postinfo']['userid']) AND $GLOBALS['postinfo']['userid'] > 0)
    {
        $smilies_where = "userid IN('{$GLOBALS['postinfo']['userid']}', '{$GLOBALS['mysmiliesvb_userid']}')";
    }
    else
    {
        $smilies_where = "userid = '{$GLOBALS['mysmiliesvb_userid']}'";
    }

    $smilies = $this->registry->db->query_read_slave("
        SELECT *
        FROM " . TABLE_PREFIX . "mysmiliesvb
        WHERE $smilies_where
    "); 
And see if that works for you.
Quote:
Originally Posted by Oblivion Knight (Post 1864527)
Regarding the quote box bug..

It can be fixed by removing this from the query on the bbcode_parse_complete plugin:
Code:
                WHERE userid='{$GLOBALS['mysmiliesvb_userid']}'
..But it's not at all recommended if you have a large board with many users who make use of custom smilies. I've done it because I have a small board, with not so many users and have limited the smilies per user to 20.

Perhaps somehow grabbing the quoted user's userid and adding it to the query is a possibility?

I was looking at some code from an old "Who Quoted Me?" plugin. While it would need reworking for use here, I think it could be a possibility..

Oblivion Knight 08-10-2009 02:45 PM
Unfortunately, it didn't work.. :(

I've a horrible feeling that an additional query may be needed, unless it can be done with joins?


Of course, another fault with my current "solution" is that all users can use anyone's custom smilies, using the replacement.

Eric 08-10-2009 03:13 PM
What's weird is when debugging, it works just fine - when posting as another (test) user, without the debugging code in place, it doesn't parse the smilie. :|

Eric 08-11-2009 08:11 PM
MySmilies vB will not support parsing smilies in a quoted users post, unfortunately. I've tried several things without success, maybe I'm over thinking it.

Aside from that, thinking about it - any work around for it would potentially cause several queries per post, and that's not good.

Oblivion Knight 08-12-2009 07:31 AM
Quote:
Originally Posted by SecondV (Post 1865351)
MySmilies vB will not support parsing smilies in a quoted users post, unfortunately. I've tried several things without success, maybe I'm over thinking it.

Aside from that, thinking about it - any work around for it would potentially cause several queries per post, and that's not good.
I noticed that when I changed the query (forgot to post), so quickly reverted it.. ;)


--EDIT--
I've had to uninstall this, it's causing a couple of nasty conflicts - executing additional queries. On v3arcade; for a game's high scores, it was running an extra query for every score on a page.


All times are GMT. The time now is 11:50 AM.
Page 8 of 19 « First 67 8 91018 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01964 seconds
  • Memory Usage 1,759KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (1)bbcode_php_printable
  • (9)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete