| mfyvie |
07-05-2007 11:59 PM |
Quote:
Originally Posted by Aclikyano
(Post 1279846)
YOU CAN QUICK BAN THE THREAD STARTER.. but you cannot QUICK UNBAN him. (users that are banned)
|
I think you are reporting an issue which I provided a solution to on post #61. I even wrote the heading in huge bold letters.
Quote:
Originally Posted by Seiyaboy
(Post 1280357)
I sure did. The ban image only appears for membersgroups 9 and under. When the group number is 10 or above, those images do not appear for them. Btw, I use 3.6.7 PL1 of vbulletin. But it's not really a big deal since the trolls are usually just members with 1 to 5 posts. As long as the basic member group can be easily banned, that's good enough for me.
|
I had a look and found the cause:
Code:
<!-- QUICKBAN BUTTON SHOWED FOR USERGROUPS -->
<if condition="$post[usergroupid]== $vboptions['ugroups_ban']{0} OR $post[usergroupid]== $vboptions['ugroups_ban']{2} OR $post[usergroupid]== $vboptions['ugroups_ban']{4} OR $post[usergroupid]== $vboptions['ugroups_ban']{6} ">
<!-- END QUICKBAN BUTTON SHOWED FOR USERGROUPS -->
See those {0}, {2}, {4} and {6}? The correspond to a character position in a string. So imagine your string is 1,2,3,4 - those character positions would match up. But as soon as you have 10,2,3,4 the whole thing falls apart. because those values will return 1 , , ,
I'll leave you to decide whether you think this was a good idea... I could rewrite this section, but then, given my previous rewrites, that would be almost the last part of the mod which I haven't totally rewritten. Given that this mod is marked as supported but the author hasn't shown up in some time to fix all the problems, I'm not inclined to bother! |
More Information