OK, will investigate - I wish software didn't take on a life of its own!!

This is indeed an interesting question.

The jukebox worked correctly through version 1.61 and that version still works correctly today. However, I find that I cannot get the version 2.0.x to work at all. I'm not sure why, as I don't think I've changed any of the code (obviously I must have). It fires up the windows media player correctly but refuses to play anything.

I wrote this as an add-on for someone who said that it was very important to him, and then decided that he didn't want it after all. I wonder - is this actually a very useful feature? If you have an mp3-aware application on your pc, then this will load and run anyway when you click on an mp3 file. I'm not sure what advantage there is to having it play inside an embedded media player running in the browser.

If anyone can give me good reasons for this feature, I'll continue to try to fix it, otherwise it seems like a feature that could be removed.

Bug confirmed. As you say, it occurs when there is a value other than zero in the review frequency field. It will be fixed in 2.0.6, but in the meantime, if this is urgent, the fix in version 2.0.5 is as follows.

Edit local_links.php. Go to line 1881 to 1893, which read as follows:

Move line 1893 immediately before 1881, ie just before the if test, so that the code reads as follows:

My version 2.0.5 already reads like the fix.

Check again! I've just looked at the code sitting on this site and it reads as I said. It's a subtle change - just moving one line up a dozen lines.

When I tried this feature recently, it worked approximately 1/20 times. My point here is that it does work on occasion, although I am not sure what is the variable that allows it to work or not.

I do not see a very important reason for this function to remain. I believe there are better "jukebox" modifications out there made expressly for that purpose.

I know, sir. I've checked it over and over again and it is already fixed in the version I have. ;)

Lol, this is a funny one. :)

NOOOOOOOO! Keep it i need it coz as you might remember i plan to play mp3s thru this addon. and my artists dont want people to be able to download there mp3's just stream them. i dunno if it would be possible with the media player thing / or will be possible in some other way but i was gonna make a flash player so users can only stream music from my site not download it... this is kinda crutal to my site. unless you have anyother ideas that is :rolleyes: :D


cheers andrew

Now I understand. I broke this between the beta 2.0.5 and the final 2.0.5. You must have got the beta code installed.

OK, will investigate.

Hey andrew,having a bit of a problem here,I just upgraded our forums and installed the update for this mod and everything works fine on the outside but on the inside when i try to change anything in the "settings and permissions" area of the admin page i get the following error

i have tried changed the option for "days seen on portal" to many different ones from 0 and up but it still get this error.I think it may be because i upgraded from the old 1.60 but im not sure.any help would be appreciated :)

Do you get exactly the same error regardless of the value you put in the option field? If so, I think that the form must be returning the wrong value to the code. Take a look at your main admincp/style manager and see if the system is showing rthat you mave multiple versions of templates like links_admin_onesetting_start, etc. If so, it's picking up the wrong template - perhaps the old versions were not cleared out during the upgrade (should have happened automatically).

If this is the not the problem, go to the links admin/settings page, do a 'view source', and email me the result - ad_rodin (at) noos.fr. Also a dump of the local_linksadmin table from your database.

is there any word on an UPLOAD feature in future update? that feature is still killing me in my going back and forther between this and the vbDownloads hack. ;)

The word is *mark this very carefully and pay me in gold coins* - the alpha code is written and running on my PC and should be ready for beta testing soon.

To briefly explain:

Upload will be handled as an additional field on the 'add link' form. It is only visible when
a) the current user's usergroup has *can_upload_files* permission
b) the master switch *uploads_enabled* is turned on
c) the total disk space used for uploads is less than a per-site maximum

Uploads will only be available for file with recognised mimetypes according to the standard vb admin settings.

OK

No i don't get the same error exactly depending on the value.The error looks like this.
with the number "30" before ",0" changing to whatever value i put in for "days seen on portal"

I checked templates and nope only one set of templates for LDM is showing up.I will e-mail you the source in a moment but i wont have access to get you the mysql dump until our admin is online.Thanks for the help.

I am having the same problem, just a little more info to help, whatever I imput into that field it aphends ,30 to it ie: I put 0 in I get 0,30 as the error and if I put 30 in I get 30,30. Hope this helps in diagnosis.

yep that is the same thing i get,i have determined that the two numbers in the error message are from

"days_seen_on_portal"=0 and "default_forumid"=0
Which looks like this 0,0 in the error message.

Besides this everything else seems to work perfectly.

:EDIT: e-mail sent

i also notice when i go to edit/create a new link that in the "Parent Forum" portion in the old version it used to have a list of all my forums on vB but now the only thing there is "Parent Forum,None" :ermm:

andrews a legend ;)

Precisely .. that is what I must track down.

I see,thanks for the replies and help by the way.Also note that i just tried uninstalling and reinstalling LDM through the admin panel but didnt help any.I still get the same issues.

On a more positive note i really love the way the new version is set up,It's so easy to customize templates in the version.I made a similar setup in vB as well to make it a bit easier for myself.Last time on 3.0 i was hard coding all my templates which took up a lot of time.

I would just say the heck with it and reinstall the mod from scratch (as it worked perfectly fine when i installed it for testing on another server) but if i were to do that i would have to re-add the 2000 links in my database and re-create the catagories/sub catagory structure :ermm: good luck.I will get you that mysql dump asap.

You've turned off the Forum Jump menu in the main vb admincp , haven't you... For the time being, the problem should go away if you turn if back on - at least for long enough to set the value you want for the days_seen_on_portal and default_forum_id parameters. I'll investigate further - I had handled this situation correctly with VB3.0, but I need to work out the fix for vb35.

Some of you are experiencing problems with setting the days_seen_on_portal and default_forumid parameters. I think you will find that you have switched off the forumjump in your main vb admin. You can fix the problem in one of two ways:

Either
a) Turn Use Forum Jump back on for the length of time you need to set these parameters

or

b) Patch local_linksadmin.php. At line 184, change
to read
The same bug also hits the add link, edit link, add category and edit category forms, which may lack a forum selection list is you have turned off forum jumps. The solution is exactly the same, at the relevant places in local_links.php.

This will be fixed in the next release of LDM.

Hey Andrew,Yes thats what it was alright.We have the ForumJump menu disabled on our forums because we really have to use for it as all links are clearly accessable on menu's and such on our forums/site.I applied your fix and it's now working perfectly.Thanks alot for helping with the problem. :) i love the new version so far.lots of nice features.

Iam having one small problem, thumbnail images are not being shown, set to 64, not using tables but the other option, i get a white square with unable and i cannot read rest of message, what am i doing wrong.

Also is there a way to link it with ftp site with username and password as it will not connect to one.

About the image problem,I had the same issue a while back and it was because we didnt have GD installed on our server.Do you know if you have it?

Links and Downloads Database
Code 2.0.5
MySQL 4.0.25-standard
PHP 4.4.0
allow_url_fopen Yes
cURL Yes
GD2 Yes

looking at the table at bottom of settings its says yes and i dont have problems displaying thumbnails on the forum

The string probably reads 'unable to load ...' which means that the thumbnail display script has not been able to read the file. Try creating a new link in which you use the image filename as the link itself, and see if clicking on it works. Do any thumbnails work or is it just this one?

I have not tried this, but I had not coded anything special for usernames/passwords. Are you using the fopen or curl interface? Curl, if available, is used by default.

Just noticed another small problem which is more then likely the same issue in another file.In any "edit" menu for catagories,sub catagories or mass edit's the same problem with only "Parent Forum" and "none" showing up.I checked out the Local_links.php file and noticed it uses the same code "construct_forum_jump();" so i tried adding the same fix but it didnt seem to work lol thought it would be easy but i guess not.Any possible fix for that as well?

Here's a suggestion for this to make searching the database more accurate and useful.

When you add or edit a link, offer the ability to associate the link with a an item from the users profile. For instance, lets say the user is from California, and there's a user profile field with a list of states, one being California. When I add a link, I could choose California and other states and that creates an association between that link and the user. For that matter all uses who have California in their profile.

The point here is to associate the information in the users profile field with links in the links database. When the user returns to the links database they can optionally search for new links and be shown what's relevant to them. This association can be useful with many types if links or downloadable content. You could have profile fields for locations, hobbies, vehicles, schools, etc, and put groups of links together based on the users apparent interest.

AndrewD: I wanted to take a moment to say thank you, both for the wonderful module for my site, and the amazing amount of assistance that you have offered to everyone.
I just went through and read all 19 pages of conversation, and even when people have been rude to you, you've been quietly helpful. I have just installed it, and got it working with a little bit of twiddling around. The only reason I had trouble is my own foolishness, (goofed the permissions) and I now have a nice private list of links on my site.
I'm working on figuring out a way to add an image to each category.

So, to sum up, thank you for your hard work and your kind words. Have a wonderful day. :_)

Thank you - you're well ahead of me here :) In fact, when I get the requested extensions and bug fixes done, I intend to start work on a new hack or module or something to do more or less what you are suggesting:

- allows keyword associations - just as you say - to point directly at entries in LDM, and ideally also at posts/threads
- allows users to define keywords of interest to them and to manage those lists
- provide a generic interface between these and, e.g., vbAdvanced, so that the user can see what's new, etc
- use this also as the guts of a glorified version of the apache error 404 trap, so that requests to go to /yoursite/keyword either take the user directly to a particular page or carry out a keyword search.

Any further ideas? I don't know how long this will take me and/or if part of the job is already done.

and thank you too

have you tried using a bbcode, i.e an img tag in the category description or extended description?

Yes, it is the same issue - I had tried this yesterday and thought the same fix worked, but will check again - it's at lines 766, 891, 1230 and 1351 in local_links.php

Thanks once again for the reply Andrew.I will give it another shot and let you know my results.

@at the above suggestion of associating keywords.I must say i love that idea!I think it would be an exellent addition.I have tried many different hacks here and of them all i have to say yours are the best.Your one of the few i have seen that think everything through before tossing a hack/mod online.I look foward to seeing your future mods.Thanks again.

:EDIT:yes you were 100% correct Andrew,It seems i missed one of the lines around line 1400 which needed to be moddified with the code you provided.All is now working :)

Here's another suggestion.

If a user doesn't have access to view a link, I would like to let me know this before they tried to view it. For instance, next to the link display a message like (Register to View) or (Subscribe to View) whatever. This sounds like something you could do in the templates, but I'm not sure.

The default vB no permission template that users are shown when they have no access to a link just doesn't do it for this application.

Aye. I am looking to put the image directly beneath the category name, making it a clickable link, just like the category name itself. As a test, I enabled HTML and added the img src=/dir/file.png to it, which I thought worked wonderfully. Then I actually clicked the link, and up top, the HTML was part of the displayed category name. So it showed up like:
Library <img src=/dir/file.png>
I'll keep plugging away at it. :_)

Thank you again.

I'd come to the same conclusion myself. It is an easy template change, which I will add.

Yes, the code traps bbcodes in the title, but doesn't trap html. You're the first that has pointed this out.

here's a thread with a list of suggestions/features that people were requesting if you wanted to go through it.

https://vborg.vbsupport.ru/showthread.php?t=77446