vb.org Archive - Board Optimization - United-Forum CSS Sprites - ludicrous speed

Page 7 of 17

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)

- - Board Optimization - United-Forum CSS Sprites - ludicrous speed - NOW! (https://vborg.vbsupport.ru/showthread.php?t=266696)

Mooff

08-05-2011 08:24 AM

Output does look fine.
Since you left your url in i checked the main sprite - and it does look fine aswell (aside the GD 2.0.35 version - guys please update, that version is 4 years old).
So what exactly is not working?
Did you do the required template changes?

stephen1976

08-05-2011 10:16 AM

1 Attachment(s)

okay installed on 4.1.5 PL1

there is only one slight error the Paperclip icon on threads now appears a little odd ( i think it now stands out more! )

see pic

Mooff

08-05-2011 10:27 AM

We will update the FAQ with that question soon. Really shocked it does affect so many servers.

Quote:

Originally Posted by Osbes (Post 2228914)

If you have some image like

http://dl.dropbox.com/u/246391/Robin.png

which looks like

http://dl.dropbox.com/u/246391/Robin_result.png

in the Sprite (it is stretched and vertical lines are added), than you possible use a GD Libary older than 2.0.36.

GD had a problem handling grayscale images with alpha channel correctly, wich was fixed with GD 2.0.36 in the Year 2007.

https://bitbucket.org/pierrejoye/gd-...361a31aab/NEWS

The solution is to update the GD-Libary to 2.0.36 (or later) or replace every file which uses "gray+alpha" with an version using "color RGBA".

I would advise to update the GD-Libary, cause there is also a serious security problem, that was fixed in the Year 2009 by Debian.

I am totally shocked by this, since there seem to be a whole bunch of people with this kind of problem and this fix is 4 years old and since 2 years known als high security fix by debian.
So there seems to be a lot problem within the maintenance of servers, if some serious security issue isnt solved since 2-4 years. If you pay money for server maintenance i would be deeply shocked, if i were you.

Best regards
Sebastian

Crotan

08-05-2011 02:00 PM

Quote:

Originally Posted by Mooff (Post 2229612)

We will update the FAQ with that question soon. Really shocked it does affect so many servers.

I'm not, most hosts get by on the bare minimums, overloading shared hosting boxes and the like. Having 4 year outdated image libraries with a security hole sounds just right.

sadiq6210

08-05-2011 02:32 PM

Could you explain this step more?

Quote:

upon installation a new stylevar imgdir_sprite will be created. Update this stylevar based on your file structure - default value is the vbulletin sprite directory. Make sure the folder is writable, else the sprites can't be saved!

Crotan

08-05-2011 04:11 PM

1 Attachment(s)

Quote:

Originally Posted by sadiq6210 (Post 2229716)

Could you explain this step more?

Look in the style Manager in the admincp, installing this mod will create a new stylevar named "imgdir_sprite" Make sure the folder is chmod 755, is what it means by make sure it's writable so that vbulletin can save the new sprite images it creates.

giorgino

08-05-2011 10:22 PM

1 Attachment(s)

One strange issue: "Moved" topic hasn't icons

Osbes

08-05-2011 11:41 PM

Hello,

version 0.7.2 is currently running on our liveforum. If nothing wrong happens, i will release it tomorrow.

Best regards
Sebastian

fukdawrld

08-05-2011 11:58 PM

Thanks for all your help. It built the sprites.

Osbes

08-06-2011 12:03 AM

Hello giorgino,

thanks for the info, i missed to integrate the following template change within the TMS rules.

Code:

Template: threadlist.css

<    .threadbit.moved .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_moved-30.png); }

I have integrated it to 0.7.2.

If you didnt want to wait, you can remove the css-rule .threadbit.moved .threadstatusfrom within the template threadlist.css manually.

Best regards
Sebastian

Osbes

08-06-2011 07:11 PM

Version 0.7.2 (06.08.2011)

now supporting folders for forum prefixes

sprite generation splittet to avoid timeouts on sites which a huge number of styles

checks if the gd version is 2.0.36 or higher (experimental)

Crotan

08-06-2011 07:25 PM

Quote:

Originally Posted by Osbes (Post 2230214)

Version 0.7.2 (06.08.2011)

now supporting folders for forum prefixes

sprite generation splittet to avoid timeouts on sites which a huge number of styles

checks if the gd version is 2.0.36 or higher (experimental)

hmmm, refreshing with this new version causes a database error:

Code:

Warning: mysqli_query() [function.mysqli-query]: (42S22/1054): Unknown column 'language.phrasegroup_sprite' in 'field list' in [path]/includes/class_core.php on line 1352

Osbes

08-06-2011 07:35 PM

Hello Crotan,

thanks for the info, i tested something during the deployment of 0.7.2 and dropped this later. But it seems i forgot to remove

PHP Code:


		
			
$phrasegroups = array('sprite');

from the sprite.php

I have updated the zip file.

Best regards
Sebastian

bilgicc

08-06-2011 07:58 PM

Working very well. Thank you.

DNCL	08-06-2011 09:07 PM

The new version fixed the "move redirect icon" issue it was not appearing, thanks, nominated :)

Taurus1

08-07-2011 05:08 AM

1 Attachment(s)

Awesome! The latest upgrade worked great. Thank you very very much! :up:

Just one very small issue on some of my skins. If you look at the attached screenshots you will see that my little search icon is missing. How can I get that back please?

Attachment 131752

Attachment 131753

Thank you!

EDIT: I also use this mod: http://www.vbcover.com/icart.php?do=...t&productid=56

and on it's main page the icons are also gone:

Attachment 131754

Crotan

08-07-2011 05:18 AM

Quote:

Originally Posted by Taurus1 (Post 2230388)

check out https://vborg.vbsupport.ru/showpost....&postcount=138

Taurus1

08-07-2011 05:31 AM

Quote:

Originally Posted by Crotan (Post 2230389)

check out https://vborg.vbsupport.ru/showpost....&postcount=138

Thanks Crotan, but I don't quite understand how to change this? Sorry for my noobness! :o

EDIT: lol, OK, I get it. I am a slow learner. If I remove that part in the additional.css the search icon shows but the little block is gone. Yet I can change the image in forums>images>buttons>search.png, but will that not then change it on all other skins also?

Osbes

08-07-2011 05:54 AM

Hello Taurus1,

each HTML-Element can only have one background.

The css-rule for the sprite is:

Code:

.sprite_button_search {

    background: url("images/sprites/sprite-61-main.png") no-repeat scroll -34px -18px transparent;

    display: inline-block;

    height: 22px;

    width: 22px;

}

Your style adds an additional background for the magnification glass:

Code:

.globalsearch .searchbutton {

    background: url("images/Seamus/gradients/back3.png") repeat-x scroll left top transparent;

    border: 1px solid #1B518F !important;

    border-radius: 7px 7px 7px 7px;

    box-shadow: 0 0 2px #1A1A1A;

    margin-left: -5px;

    margin-top: -2px;

}

So the Browser will use as background-image either "images/sprites/sprite-61-main.png" or "images/Seamus/gradients/back3.png".

You need to remove

Code:

background: url("images/Seamus/gradients/back3.png") repeat-x scroll left top transparent;

so it can display the magnification glass using sprites.

Since you will loss your background for the magnification glass if you do this, you can merge your background with the magnification glass, to get it back. And dont forget to refresh the sprite after this.

###

For the Ticket-like addon.

You need to make an additional template edit for this, based on the one for the threadbit:

Code:

Template: threadbit

1c1

<    <li class="threadbit {vb:raw thread.statusstring}<vb:if condition="$show['paperclip']"> attachments</vb:if><vb:if condition="!$thread['postuserid'] AND !$thread['del_userid']"> guest</vb:if><vb:if condition="$thread['moderatedprefix']"> unapproved</vb:if>" id="thread_{vb:raw thread.realthreadid}">

---

>    <li class="sprite_statusicon_thread_30 threadbit {vb:raw thread.statusstring}<vb:if condition="$show['paperclip']"> attachments</vb:if><vb:if condition="!$thread['postuserid'] AND !$thread['del_userid']"> guest</vb:if><vb:if condition="$thread['moderatedprefix']"> unapproved</vb:if>" id="thread_{vb:raw thread.realthreadid}">

Please note, that the difference is only the addition of sprite_statusicon_thread_30.

With 0.8.0 this wont be necessary anymore, since the sprite will than use for these icons threadbit and dont need sprite_statusicon_thread_30 anymore. But until than, this needs to be done to get it working :)

Best regards
Sebastian

Taurus1

08-07-2011 06:06 AM

OK, I understand. Is it possible to just refresh this one sprite? Or I must just click the refresh button again, refreshing all? Thanks.

PS: What about my second issue with the icons missing on my iSupport page?

Taurus1

08-07-2011 06:11 AM

EDIT: Disregard. Sorry, I get it now. I just need to add the one part of that code in my threadbit templates.

Osbes

08-07-2011 06:13 AM

Hello Taurus1

Quote:

EDIT: lol, OK, I get it. I am a slow learner. If I remove that part in the additional.css the search icon shows but the little block is gone. Yet I can change the image in forums>images>buttons>search.png, but will that not then change it on all other skins also?

If the other Styles use this path also for the stylevar imgdir_button, than this will also change the other styles.

So i think it would be better to use antoher folder for the style with the special background for the magnification glass.

Best regards
Sebastian

Osbes

08-07-2011 06:16 AM

Quote:

Originally Posted by Taurus1 (Post 2230404)

So do I just add this to my threadbit template, and where?

Code:

1c1 <    <li class="threadbit {vb:raw thread.statusstring}<vb:if condition="$show['paperclip']"> attachments</vb:if><vb:if condition="!$thread['postuserid'] AND !$thread['del_userid']"> guest</vb:if><vb:if condition="$thread['moderatedprefix']"> unapproved</vb:if>" id="thread_{vb:raw thread.realthreadid}"> --- >    <li class="sprite_statusicon_thread_30 threadbit {vb:raw thread.statusstring}<vb:if condition="$show['paperclip']"> attachments</vb:if><vb:if condition="!$thread['postuserid'] AND !$thread['del_userid']"> guest</vb:if><vb:if condition="$thread['moderatedprefix']"> unapproved</vb:if>" id="thread_{vb:raw thread.realthreadid}">

You need to search in the templates for the iSupport for "threadbit".

There should be something like

Code:

<li class="threadbit ...">

there, add the sprite_statusicon_thread_30, so it looks like

Code:

<li class="sprite_statusicon_thread_30 threadbit ...">

Since i didnt know this addon, i cant tell you which is the themplate they use.

Edit:
You need to refresh all styles, there is currently no option to refresh a single style.

Best regards
Sebastian

NgocTam

08-07-2011 07:08 AM

pls add
post_old.png
post_new.png

Osbes

08-07-2011 07:20 AM

Hello NgocTam,

support for icons within SHOWTHREAD will be added in 0.8.0.

Best regards
Sebastian

Taurus1

08-07-2011 07:32 AM

Thank you very much for all your help. I think I got everything sorted now. If you have a moment sometime, I would really appreciate it if you could just check on my forum, and see if everything is correct. Thank you!

Andyrew

08-07-2011 07:45 AM

Can you tell me why the icons on forum home are broken in IE. They seem to be OK in firefox now but not IE. http://www.airgunforum.co.uk/forums/forum.php

Osbes

08-07-2011 08:12 AM

1 Attachment(s)

Hello Andyrew,
i cant reproduce this, everthing seems fine for me (see attached screenshot).

What exactly did you mean by "broken" and what is the version of your IE?
Maybe this is a problem with your browser cache?

Best regards
Sebastian

Andyrew

08-07-2011 09:24 AM

1 Attachment(s)

That's odd. I have deleted cache and it still looks the same. I am using IE 9, here is what I see.

Update: I have told IE to reset to default settings and everything is now working fine. :up::D

Must have been something I changed a while ago.

NgocTam

08-08-2011 01:25 AM

Sprite was not created ????

Quote:

0 imageprefixes for forums found.
Processing post icons.
14 post icons found.
116 icon candidates added.
Starting with styles/summer/sprites/sprite-2-main.png.
93 icons added.
Creating sprite (width:1000px height:117px).
Sprite saved, updating css-rules.
Starting with styles/summer/sprites/sprite-2-main_rtl.png.
93 icons added.
Creating sprite (width:1000px height:117px).
Sprite saved, updating css-rules.
CSS template successfully updated.
Starting with styles/summer/sprites/sprite-2-forumdisplay.png.
0 icons added.
Sprite was not created.
Starting with styles/summer/sprites/sprite-2-forumdisplay_rtl.png.
0 icons added.
Sprite was not created.
CSS template successfully updated.
Starting with styles/summer/sprites/sprite-2-forumhome.png.
0 icons added.
Sprite was not created.
Starting with styles/summer/sprites/sprite-2-forumhome_rtl.png.
0 icons added.
Sprite was not created.
CSS template successfully updated.
Starting with styles/summer/sprites/sprite-2-showthread.png.
0 icons added.
Sprite was not created.
Starting with styles/summer/sprites/sprite-2-showthread_rtl.png.
0 icons added.
Sprite was not created.
CSS template successfully updated.

BadgerDog

08-08-2011 10:01 AM

1 Attachment(s)

Quote:

Originally Posted by stephen1976 (Post 2229609)

okay installed on 4.1.5 PL1

there is only one slight error the Paperclip icon on threads now appears a little odd ( i think it now stands out more! )

see pic

I have this exact same problem .... :confused:

Running version 0.7.2 on vBulletin 4.1.3pl1 ....

Anything I can do to address it?

Thanks for the mod ... :up:

Regards,
Doug

Osbes

08-08-2011 12:12 PM

Hi NgocTam,

this isnt a problem, as long as the main-sprite is created.

Since 0.6.3 it is possible to add icons to specific sprites (main, forumdisplay, forumhome, showthread). I have introduced it, to gain a better ratio between the icons that are added in a sprite and the icons that are used on a page.
Currently, this isnt used and wont be used in 0.8.0. Maybe in 0.9.0.

Best regards
Sebastian

Osbes

08-08-2011 12:14 PM

Hello BadgerDog,

i dont want to be rude by answering with a quote, but i have answered this problem a lot and this quote has all the information and solution :)

Quote:

I will add it to the FAQ now.

Best regards
Sebastian

sivaganeshk

08-08-2011 01:01 PM

TMS is available in 3.8.x
how to for 4.1.5 ?

Osbes

08-08-2011 01:27 PM

Hello sivaganeshk,

Andreas has uploaded TMS 1.2.0 Beta 2 on vBulletin-Germany.org, but it seems that TMS 1.1.5 is also working with vBulletin 4.

Please ask questions regarding the TMS in the corresponding thread :)

Best regards
Sebastian

tarzan22

08-08-2011 03:00 PM

Hello

Sorry for my English

0.7.2 installed and running but have this problem

http://img35.imageshack.us/img35/139...nshot004er.png

anyway, great job, thanks

DNCL	08-09-2011 11:50 AM

Found a bug in Visitor Message pagination arrow:

https://vborg.vbsupport.ru/external/2011/08/60.jpg

Mooff

08-09-2011 11:58 AM

@tarzan22
sorry for the late reply - we will update the faq regarding this question once we find the time.
And sorry if i keep myself short, but since that has been asked numerous times already in this thread i think a short answer will suffice:
Despite covering hundreds of icons our addon can't cover everything. Especially gradients can't be automatically replaced since they differ a lot in custom styles. But, we do offer a hook so you can add your own icons into the sprite, based on the needs your board has. A how to can be found somewhere in this thread.

@DNCL
please read the FAQ in post two. This 'bug' isn't caused by the addon but by a very old GD version which besides this 'signature' also contains a security risk, which was fixed 4 years ago.

Osbes

08-09-2011 12:36 PM

Hello DNCL,

thanks for the information. Beside the GD-Problem, there is a small bug with the position of this field, it shouldn't be so low.

It caused by an overlap with an original vb css-rule. I will fix this in 0.8.0.

Best regards
Sebastian

BadgerDog

08-09-2011 12:51 PM

Quote:

Originally Posted by Osbes (Post 2230860)

Hello BadgerDog,

i dont want to be rude by answering with a quote, but i have answered this problem a lot and this quote has all the information and solution :)

I will add it to the FAQ now.

Best regards
Sebastian

Not rude... I should have seen it myself ... :up:

I contacted our Unix tech support group ...

Here's their response ...

Quote:

Unix Tech Support feedback ..

I just looked at your config and you're not actually running GD 2.0.34. You're running the embedded GD that is built into PHP. It's the same version that would be installed running an "up2date php-gd". In CentOS (and modern RedHat implementations) it would actually be "yum install php53-gd" rather than up2date.

In any case; rather than breaking PHP and linking it to a standalone GD implementation I ran a major update to PHP. This new version SHOULD have the support you're looking for. Although the phpinfo command still says (2.0.34 compatible) that does not mean you're actually running 2.0.34.

Hopefully the plugin will run with the updated PHP (and php53-gd package) without having to go to a source-compiled implementation.

Let me know if this works for you.

Strange graphics are now fixed, but I thought I'd post the above feedback for everyone's benefit here, just in case they're in a similar position to us running embedded GD with Redhat Linux .... :)

By the way, sent you a PayPal donation to say thank you for your efforts on this excellent mod ... :up:

Regards,
Doug

All times are GMT. The time now is 12:19 AM.

Page 7 of 17

« First

Last »

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01896 seconds Memory Usage 1,863KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (9)bbcode_code_printable (1)bbcode_php_printable (14)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (40)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: