vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Forum Display Enhancements - Collapsable First Post using AJAX (or Last Post!) (https://vborg.vbsupport.ru/showthread.php?t=145187)

Tralala 05-02-2007 02:58 PM

Quote:

Originally Posted by magnus (Post 1239272)
.. let's see if that fixes it.

It did not. :(

magnus 05-02-2007 03:23 PM

Quote:

Originally Posted by Tralala (Post 1239788)
It did not. :(

Uh... ok. Well, enough messing around, change the Hook Location for the plugin above to usercp_start (instead of usersub_start). Let's just nip this sucker right in the bud..

Tralala 05-02-2007 05:20 PM

Quote:

Originally Posted by magnus (Post 1239810)
Uh... ok. Well, enough messing around, change the Hook Location for the plugin above to usercp_start (instead of usersub_start). Let's just nip this sucker right in the bud..


Okay, well, now I no longer get the error... the UserCP page loads fine... which is obviously a step in the right direction. :up:

But, unfortunately, I'm back where we started in that the expand/collapse button that appears in the title of the subscribed threads doesn't actually do anything. Clicking on it has no effect. It still works fine in the regular forum view, though.


I do also see the same thing that was mentioned earlier, with regards to spoilers and my particular spoiler BB code. When clicking on the expand/collapse button in regular forum view, if the post that is revealed has a spoiler in it, the state of that spoiler is set to "show" instead of "hide." The spoiler button works fine, mind you. It's just that it should default to "hide" the spoilerized text rather than show it... just like it appears in the regular post.

Here is my BB replacement code, if that helps any:

PHP Code:

<div style="margin:5px 20px 20px 20px">
  <
div class="smallfont" style="margin-bottom:2px">
   <
input type="button" value="Show" style="width:50px;font-size:10px;margin:0px;padding:0px;" onclick="if (this.value=='Show') {this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = '';this.value='Hide';} else {this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display='none'; this.value='Show';}">
  </
div>
  <
div class="alt2" style="margin: 0px; padding: 6px; border: 1px inset;">
    <
div style="display: none;">{param}</div>
  </
div>
</
div

FWIW, I am running vBulletin 3.6.4 on this particular forum.

magnus 05-02-2007 05:42 PM

Quote:

Originally Posted by Tralala (Post 1239918)
Okay, well, now I no longer get the error... the UserCP page loads fine... which is obviously a step in the right direction. :up:

But, unfortunately, I'm back where we started in that the expand/collapse button that appears in the title of the subscribed threads doesn't actually do anything. Clicking on it has no effect. It still works fine in the regular forum view, though.


I do also see the same thing that was mentioned earlier, with regards to spoilers and my particular spoiler BB code. When clicking on the expand/collapse button in regular forum view, if the post that is revealed has a spoiler in it, the state of that spoiler is set to "show" instead of "hide." The spoiler button works fine, mind you. It's just that it should default to "hide" the spoilerized text rather than show it... just like it appears in the regular post.

Here is my BB replacement code, if that helps any:

PHP Code:

<div style="margin:5px 20px 20px 20px">
  <
div class="smallfont" style="margin-bottom:2px">
   <
input type="button" value="Show" style="width:50px;font-size:10px;margin:0px;padding:0px;" onclick="if (this.value=='Show') {this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = '';this.value='Hide';} else {this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display='none'; this.value='Show';}">
  </
div>
  <
div class="alt2" style="margin: 0px; padding: 6px; border: 1px inset;">
    <
div style="display: none;">{param}</div>
  </
div>
</
div

FWIW, I am running vBulletin 3.6.4 on this particular forum.

Would it be possible for you to make me a temporary account on your forum and PM me the details? I'd like to check this out first hand if possible.

Tralala 05-02-2007 09:43 PM

Quote:

Originally Posted by magnus (Post 1239931)
Would it be possible for you to make me a temporary account on your forum and PM me the details? I'd like to check this out first hand if possible.

Sure. I'm assuming you'll need it to be an admin account? Happy to send you details via PM.

I'd just want to time it appropriately so I enable the mod during the precise time you're available to log in. (If I leave it on, I'll get a slew of questions from my members dying to know about the new feature, and I'm just not ready for that. :D )

aggiefan 05-03-2007 01:08 AM

I had to disable this because some of our users (actually a very small few were getting an error when they tried to access the usercp)

Quote:

Fatal error: Call to undefined function fetch_coventry() in C:\AGGIEFANS\WEB\forums\usercp.php(500) : eval()'d code on line 16

Any clue to what this is? We have the latest version installed so im guessing its not a issue thats been fixed.

It was also documented here which is where i found out that it was this addon which was causing it: http://www.myhattiesburg.com/forums/...d.php?p=233020

magnus 05-03-2007 01:35 AM

Ok, apparently this is less isolated than I thought. I'm going to dive into this with force tomorrow and get a fix out.

Sorry guys!

nymyth 05-03-2007 11:31 AM

this is sweetass...thanks a lot for this....having no problems so far

Peace

beduino 05-03-2007 03:04 PM

Hi Magnus!
A suggestion, maybe useful.
If you remember [a few posts before] i talk about a 'mystery' - whith 2 images [+] etc.
The problem [as you said] is fixed, but this make me a ideia.
A hack [new one] with the first AND the last post. :D
Then the user with click in first [+] see the first post and, click in second [+] read the last post.

It's sound possible? Or useful?
[your hack is working here ]
A great day,
Joao Barroca
aka beduino

LockeAG 05-03-2007 05:38 PM

Hey Magnus I will wait for the correction for the Usergroups and then we can continue with the little issue of the SPILER TAG...

Thanks again!

wolfe 05-03-2007 08:51 PM

is it possible to change the layout that shows when you click on expand like just displaying title and text no avatar etc

Mark.B 05-03-2007 09:49 PM

Quote:

Originally Posted by wolfe (Post 1240866)
is it possible to change the layout that shows when you click on expand like just displaying title and text no avatar etc

Just edit the vbpost_postbit template, and remove the avatar section, you can then move the username and title code into the other section.

l3it3r 05-03-2007 09:58 PM

I installed, did the edits, imported, no errors, but nothing happens. Have the .js in the right spots and everything.. is there something else to look for?

magnus 05-04-2007 01:04 AM

Quote:

Originally Posted by l3it3r (Post 1240907)
I installed, did the edits, imported, no errors, but nothing happens. Have the .js in the right spots and everything.. is there something else to look for?

Elaborate on "nothing happens" please..

Lea Verou 05-04-2007 12:56 PM

Quote:

Originally Posted by magnus (Post 1239014)
But it's also in USERCP and search_results.. :p

So, rather than pigenholing myself, I can be ambiguous and leave it as it.

Yes but as it is I understood that you meant on showthread and I thought "how useless!" when I saw the title. It was out of sheer luck that I clicked on the title to figure out what it was. And it's a pity cause it's a wonderful idea!

magnus 05-04-2007 01:33 PM

Quote:

Originally Posted by Michelle (Post 1241307)
Yes but as it is I understood that you meant on showthread and I thought "how useless!" when I saw the title. It was out of sheer luck that I clicked on the title to figure out what it was. And it's a pity cause it's a wonderful idea!

Like I said, I'm open to ideas. :)

I'm a programmer, not a marketer unfortunately.

You're right, though. The name is pretty bland and uninteresting..

KoC 05-04-2007 06:54 PM

How to disable the avatar and signature of the user? There must be a option to do this in future versions.

magnus 05-04-2007 07:22 PM

Quote:

Originally Posted by KoC (Post 1241506)
How to disable the avatar and signature of the user? There must be a option to do this in future versions.

Edit the vbpost_postbit template to look however you want.

morpheusXIIX 05-04-2007 11:57 PM

have you thought of adding the option to show "all unread posts"? or would that be too intensive to run?

Tralala 05-05-2007 12:07 AM

Quote:

Originally Posted by morpheusXIIX (Post 1241677)
have you thought of adding the option to show "all unread posts"? or would that be too intensive to run?

My first thought on that is... why bother? At that point, why wouldn't the user just go into the thread itself?

I'm thinking this AJAX display is meant to be a preview, not a complete replacement for forum navigation.

skooby 05-05-2007 01:27 AM

Awesome mod :)

l3it3r 05-05-2007 12:39 PM

Quote:

Originally Posted by magnus (Post 1241006)
Elaborate on "nothing happens" please..

The + shows up next to all the threads, click on it, nothing happens, no errors, nothing. I uninstalled, reinstalled. still nothing. :confused:

magnus 05-05-2007 01:49 PM

Quote:

Originally Posted by l3it3r (Post 1241849)
The + shows up next to all the threads, click on it, nothing happens, no errors, nothing. I uninstalled, reinstalled. still nothing. :confused:

First, verify that the files vbulletin_vbpost.js and jquery.js are in your [b]/clientscript/[b] directory. If the are, then do the following:

Activate the mod. Browse to your forumdisplay page. In your browser, right click. Select View Source. Copy and paste the entire source to a .txt file.

Attach the text file to a post here, or give it to me in a PM. I need to look at it.

BANDiT600 05-05-2007 04:28 PM

My options sets to show last post, but... When I edit any post of the thread and next try to see last post it shows me last edited post, not the last one... It happens in serach results.

BANDiT600 05-05-2007 04:31 PM

"by createdate" change to "order by id"???

Not good that this mod doesn't show last post in search result!!!

But thanks anyway...
/me installed...

BANDiT600 05-05-2007 05:38 PM

And another little bug with alignment of "subscribed" and other icons, see screenshot!

With AJAX:
Attachment 64017

Without AJAX:
Attachment 64016

Timelord 05-06-2007 05:10 AM

Hi Magnus! First of all, I just wanted to say this is a great idea, and from what I've seen, you've implemented it very well. However, I cannot get this to work on my forums. I have determined that it is because of the style I am using, as I have tested it under the default vBulletin style and it works there. However on the style I am using, a slightly modified version of Chestnut (by Allan), no [+] boxes appear to the left of the thread titles. I have attempted manually editing all the templates and letting it do it automatically, both times to no avail. I'm not sure what it is that's causing it but it would seem to relate directly to my style. Is there anything you can suggest that might fix this?

Thanks very much!

Dr. Bantham 05-06-2007 11:55 AM

This looks like a wonderful mod, but it is not working for me. The graphic appears in my default template, but clicking on it results in opening the full thread as normal. I suspect this is a conflict with the following mod:

Change Forum Cell Colour on Mouseover

I really enjoy using the first mod, but would compromise highlighting the cell only without the zoned click selection if absolutely necessary. I am assuming this is the problem, however.

UPDATE
I reinstalled and used manual template edits, as I assumed this could possibly remedy my issue. This resulted in no graphic and no effect. I then realized that the images/buttons directory had to be uploaded to the custom image folder I had set up for my template. End result: same as original installation for default template (clicking on the image results in opening the full thread as normal).

magnus 05-06-2007 02:17 PM

Wait, the full thread opens, with replies and everything? That's.. odd. I don't even see how that's possible. Either way, I'd need to see it, in action, on the forum in question before I could even begin to fathom a fix.

magnus 05-06-2007 02:19 PM

Quote:

Originally Posted by Timelord (Post 1242282)
Hi Magnus! First of all, I just wanted to say this is a great idea, and from what I've seen, you've implemented it very well. However, I cannot get this to work on my forums. I have determined that it is because of the style I am using, as I have tested it under the default vBulletin style and it works there. However on the style I am using, a slightly modified version of Chestnut (by Allan), no [+] boxes appear to the left of the thread titles. I have attempted manually editing all the templates and letting it do it automatically, both times to no avail. I'm not sure what it is that's causing it but it would seem to relate directly to my style. Is there anything you can suggest that might fix this?

Thanks very much!

You need to upload the image files included in the zip to your style's (chestnut) specific image directory as well. No reason to use manual edits, as the automatic ones will work just fine once the image files are put into the proper directories.

Dr. Bantham 05-06-2007 02:38 PM

Quote:

Originally Posted by magnus (Post 1242467)
Wait, the full thread opens, with replies and everything? That's.. odd. I don't even see how that's possible. Either way, I'd need to see it, in action, on the forum in question before I could even begin to fathom a fix.

What was happening was that the previous mod's mouse click reaction was taking presedence over your mod, as it was effective for the entire table cell. I removed the following snippet from threadbit template and everything works fine:
Code:

onclick="window.location.href='<if condition="$show['gotonewpost']">showthread.php?$session[sessionurl]goto=newpost&amp;t=$thread[threadid]<else />showthread.php?$session[sessionurl]t=$thread[threadid]$thread[highlight]</if>';"
This was the offending code from the previous mod. I now get the benefit of your mod while only sacrificing the regional cell click sensitivity for the previous mod. The cell color still changes as I still wished it to. Brilliant mod!

magnus 05-06-2007 03:07 PM

Quote:

Originally Posted by Dr. Bantham (Post 1242478)
What was happening was that the previous mod's mouse click reaction was taking presedence over your mod, as it was effective for the entire table cell. I removed the following snippet from threadbit template and everything works fine:
Code:

onclick="window.location.href='<if condition="$show['gotonewpost']">showthread.php?$session[sessionurl]goto=newpost&amp;t=$thread[threadid]<else />showthread.php?$session[sessionurl]t=$thread[threadid]$thread[highlight]</if>';"
This was the offending code from the previous mod. I now get the benefit of your mod while only sacrificing the regional cell click sensitivity for the previous mod. The cell color still changes as I still wished it to. Brilliant mod!

Ahh.. there was another onclick event. Yea, that would definately bugger things up. Glad you figured it out, and thanks for posting the fix. I'm sure it will benefit someone else!

l3it3r 05-06-2007 03:40 PM

Did you receive my PM with the forumdisplay? The mod is still installed, and the + is still there, but not functioning. And there are still no other errors. .js are in place, etc.

magnus 05-06-2007 04:47 PM

Quote:

Originally Posted by l3it3r (Post 1242510)
Did you receive my PM with the forumdisplay? The mod is still installed, and the + is still there, but not functioning. And there are still no other errors. .js are in place, etc.

I replied to your PM on 05. May 2007 @ 19:12. I verified it was sent, as there's a copy in my Sent Items folder.

daloosaa 05-06-2007 09:47 PM

Works fine! You did a good job, magnus.

l3it3r 05-07-2007 01:19 AM

Quote:

Originally Posted by magnus (Post 1242545)
I replied to your PM on 05. May 2007 @ 19:12. I verified it was sent, as there's a copy in my Sent Items folder.

My apologies, I don't have the notifications setup for vbulletin.org

I set it to last post. It works. so you're right. I'll look into it further tomorrow as I have much to do right now.

thanks!

sensimilla 05-07-2007 08:24 AM

What if neither automated file edits or manual file edits dont work for me ?
Only default vbulletin template is working with it.. ?

TIA, great hack

magnus 05-07-2007 10:31 AM

Quote:

Originally Posted by sensimilla (Post 1242941)
What if neither automated file edits or manual file edits dont work for me ?
Only default vbulletin template is working with it.. ?

TIA, great hack

Be sure to copy the images included in the zip to you custom style's image directory.

dbembibre 05-08-2007 09:20 AM

work perfect in my forum, the only problem is that is incompatible with Plugin Based Template cache, because i need set off.

dbembibre 05-08-2007 09:58 AM

Quote:

Originally Posted by dbembibre (Post 1243544)
work perfect in my forum, the only problem is that is incompatible with Plugin Based Template cache, because i need set off.

I solver set to NO Enable Automatic template editing and make the template changes manually.

Good work, the mod is amazing :up: :D


All times are GMT. The time now is 06:28 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01805 seconds
  • Memory Usage 1,860KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (2)bbcode_php_printable
  • (21)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete