It is worth noticing how you have pointed the negative part of my post at yourself. :)

Bless you. :)

Dead wrong if you think that I've come here did not come here to earn installs. I have come to share my work. Might have as well left it for my own use, like Bane.

Thanks. :)

Read: https://vborg.vbsupport.ru/showpost....&postcount=227

Anthony, I hope you feel better having said that - the best thing I can say is to let the stuff just roll off your back. Ignore anything negative, take the positive and look at the suggestions/fixes. If anyone is unappreciative or negative, just move on to the next post and forget all about that one.

It really isn't worth getting worked up over - you've got a good thing going here and with a little help it should be just fine.

@Psionic Vision, lots of respect for you mate, I know it can be hard in cases like this, there are always some "less pleasant" people around who think they can demand things.

Keep in mind your work is appreciated but don't forget your other doings either ;)

It doesn't appear Netscape is getting picked up in the browser types.

I change the Netscape portion slightly and am getting some Netscape versions now.

I'm still getting about 5% of unknown operating systems, will have to try and track down those.

Psionic Vision, Firstly thanks for this great hack, been using it since the first release..
However the Cron seems to be missing.. after I added the cron (like:https://vborg.vbsupport.ru/showpost....&postcount=191) my stats performed perfectly..
I couldn't find any evidence of this in the readme..

Once again cheers

is there anyway i can remove the MEMBER STATS from the general statistics thing ? like i dont want it to show the first thing, abt activity and all

anyways nice hack, thanks :)

[high]* sidekick installed[/high]

I was referring to your response! I used to drive coaches professionally for almost 35 years and if I spent my time throwing my toys out the pram at some of the stupid/silly/annoying comments from my passengers I would have been driving an empty coach all that time.
Relax, take it all with a pinch of salt. Of course you are going to get frustrating little tic-turds pestering you all the time, but thats life! Learn to live with it without embarrassing yourself.

Ok, after removing the hack I was still getting the problem.
I have since found that the problem was actually in another hack, mine :), (is there a smiley for embarrassed?).

So I might as well re-install the hack. But the way I see it, I might as well first make the changes that have been added all over this thread.
Would anybody have a list of all the changes that need to be made?
With all the posts I have lost count of what hacks need to be done.

I can try and come up with a list if need be, but if someone has one already that would be great.

FFMG

Just read pages 15 and 16. It's all there, no reason to redo them.

@MPDev Yorixz, Thank you :)

@MPDev:
The changes you introduced are not correct. Please look at the following two lines:

$deletions[] = "(`cdata` = '$ident[1]' AND `count` = '$data[0]' AND `ctype` = '$ident[0]' AND `cmisc` = '$data[2]')";
$insertions[] = "('$ident[1]', '" . ($data[0] + $data[1]) . "', '$ident[0]', '$data[2]')";

$data[0]+$data[1] is where the old count is added to the new count.

And I was referring to you pointing a finger at yourself :)
I'm sorry, son, but you are not in a position to preach anything to anyone around here.
You have been added to my ignore list.

Never mind, you carry on the way you do, the rest of the world will carry on ignoring you!

I believe you are incorrect - the reason is, as I pointed out for example, there are multiple US lines being printed; so for every US line, it overwrites the "old" value with a "new" value without taking into consideration that the results need to be cumulative during processing. In other words $data[1] needs to be a sum of all the results returned and not just the last result processed.

After alot of testing on my very busy site, I believe they are correct.

Hmm... Yes. I see what you mean now. :)
However, the initial query is supposed to group the results and there should be only one single row per value... And there should not be more than one row per value in cache anyway. Let me check it...

Yup, the query on my table gives the following results:

As you can see, there are no two same rows, so there should not be a need to count it twice.

Look closer at your data.

MSIE 6.0; Windows NT 5.1

Given your example with multiple MSIE 6.0 entries, how does your code keep a cumulation of those entries?

You do not resolve your IP addresses to countries until you process the cache. So, again, where are your results cumulative for, say, US based IP addresses as you process your cache? (Again, looking at the data I posted, you can see how you only account for a single US ip address per cache processing versus the sum of all US based ips.

So are you saying that there can be two same entries with the same sessionid?

Oh. Now I am convinced :) Will implement your fix.

As I just edited, same goes for IP addresses (as everything else); since you post process country codes you do not track the cumulative totals for country results; you only process the last entry (which is most likely only 1).

country_||_US will be processed hundreds of times, but since you don't increment the results, only the last record processed is every recorded.

Just as an FYI, because of the ip include scripts; larger sites like mine will need to process their cache with much more frequency than 1 hour or the memory requirements can be HUGE. (I had 15,000 records and not even 999MB of memory allocation would allow me to process it).

I'm a total data-junkie and love stuff like this - I hope you don't mind me picking it apart and finding this stuff because I want as accurate of results as possible; this kind of info is very important to advertisers and webmasters who really want to understand who is using their sites.

I'll probably add a referrer tracker to this because I really want to track actual links into my site from external sources.

So should I switch to a mysql-based IP database? Or just store the IP database in a single file? Or just make the cron run with 15 minute intervals?

Which would be most efficient?

My concern there would be the number of queries needed during the execution of the script - it could add hundreds of queries during processing. I'm not sure if it helps, but I added a "unset($ranges);" after the loop where it is used to try and minimize the amount of memory being used.

I don't think a DB solution would be "better"; but will let you know if I find something better than the unset().

What about putting everything into one file?
All IP files together are worth 2.47MB on disk...

I don't know about that; it all seems relative to how many records you have to process. I'm not sure I'd want to read in a 2.5mb array everytime, but I'm not sure that I'm not doing that anyways based on all the traffic I get.

is there anyway i can remove the MEMBER STATS from the general statistics thing ? like i dont want it to show the first thing, abt activity and all

anyways nice hack, thanks

Hi Psionic

not used the admincp Referring Sites Statistics for some time now
and just decided to take a look at it and it gave me this error, Any
ideas please?

@sidekick,
You edit the PSISTATS_HOME template and take out whatever you don't want to show up.

@bashy,
Make sure you upload the latest version of psistats_admin.php...

Thanks Psionic...
Not sure how i missed that 1 (no comments please :p)

All sorted again thanks :)

Quick question, should I be concerned about the performance overhead of this? I love the hack, but via webstats:

Top 30 of 926 Total URLs

# Hits KBytes URL
1 38294 4.31% 287139 5.80% /forum/image.php
2 37135 4.18% 1094015 22.09% /forum/showthread.php
3 32810 3.69% 334297 6.75% /forum/psistats.php

It's #3 on my usage list. I've had it installed for less than a week, and that's a stats snapshot of the same time period. It's not linked anywhere on my forums, I'm the only one that uses it as it takes a bit to load and slows my site down a touch when I hit it.

Can I make it viewable only to admins/mods or certain categories ? and also I was expecting the referers to be more specific, like the searches from google. It only shows google.com or the domain from where the referal came :( .

<font size="4">FAQ POST CREATED!</font>

Update done

I think its all working ok...
Gonna do a thorough check now..

EDIT: All is OK well done :)

Thanks Psionic :)

Thanks alot m8, the update went flawless, everything seems good so far, I will check it in an hour or so and see than, I appreciate all of your releases. :)

Broke the site :(

I'm getting this error after the upgrade:
MySQL Error : Table 'CMN.psistats_country' doesn't exist

I did an unistall and then reinstall. Any help?

Thanks!

Ahh -- that wasn't there a second ago ;)

Thanks!

Installed the update.
Just had to comment out the lock / unlock database lines again :)
The rest works great. I will monitor the stats for a while.

update *installed* thanx for your time and dedication

You don't need to uncomment those. Just either download latest copy of vb3.5.3 or fix that bug with the db being closed manually.