Should I be worried that talking to myself is solving all my problems?

So anyway, I got it installed, everything seemed to be working, except the weight limit function didn't seem to be catching things correctly. I left it set at the 35840 bytes that the query given in the mod has. I then attempted to load a sig pic that is about 218kB....and it let me. That seemed odd. So after a bunch of experimenting, I discovered that the remote_file_size function is returning value that's off by a factor of exactly 10. So it thinks my image (which is 223,554 bytes) is only 22,355 bytes (so the actual size, divided by 10). In another test, an image of size 134,154 was only blocked once the limit was set to 13,415 or below.

Combing through the function, nothing is jumping out to my untrained eye, but something is definitely wrong. For now, I'm just going to use the work around of changing if (remote_file_size($checkimage) > $vboptions['sigmaxweight']) to if (remote_file_size($checkimage)*10 > $vboptions['sigmaxweight']). I've tested this, and it works. But if anyone would like to debug the function and see where it's losing this factor of 10, be my guest.

I love this simplistic approach and am using it for dimensions
The only problem is it ALWAYS makes the signature area that big. Even if its just a couple of words.

Probably impossible but any way to do some sort of if statement to check if the signature contains an image?

I've figured out a solution

disable [img] tags in signatures
create a new bb code called sig

Title: Signature Image
Tag: sig
Replacement: <div style="width:500px;height:140px;overflow:hidden;"> <img src="{param}"></div> (change this as you see fit)
Example: [sig]http://www.yoursite.net/samplesig.gif[/sig]
Description:This is similar to the [img] tag but is used for signatures only.

This way only images take up the full space. If someone has a smiley or a short piece of text it wont make the signature area bigger than it needs to be.

I've modified the hack so that smilies do not count against the limit of number of images in the signature. The way I did it was quick and dirty, I'm sure there's a more elegant solution, but this works and entails just adding one line and modifying one other. I'm still a php novice, so I went with what works. If someone wants to clean it up, be my guest. My solution has 2 steps:

1) In the Quick Sig Image Size Limiter code, find the conditional:

Modify that to:

Make sure you replace [your domain] and [your board's root directory] with the proper values for your board.

2) Directly above the line you just modified, add:

You're done. Like I said, I'm sure this isn't the cleanest solution. Basically I just noticed a bit of existing code that uses a function call to parse the signature and check it agains the global post image limit. I used that and modified it to find images in the sig that are located in the smilie directory and subtracted it from the total images in the sig.

then people can post that sig bb code all over the forum, flooding it with images.

this is what happened when i tried to run
*EDIT* this is me being stupid... didnt notice I could only run one at a time :-P

Okay i must be doing something wrong... because i followed the instruction to the T ...and its still not working.. meaning it allows me to add limitation to the size height n width..but does not validate it..when members go beyond the size of 500 X 125 ?? why?.. i must be doing something wrong...its still allowing members to have large images in their signitures... :ermm:

thanks, I really needed this.

Alright, I'm trying to re-implement this hack on 3.0.7, and when I try to run the first query

it returns the following error:

Help? :nervous: Thanks!

IF you have installed it on a previous version of vB, you will probably only have to redo the file edits. You are now trying to insert a value into the database that already exit.